X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/500c1bddf2640c0b59e8d761534f4bb99a83fbec..49fac49f9d6a3d49c2cd56b605ee1ba9323dffb6:/app/controllers/api/changesets_controller.rb?ds=sidebyside diff --git a/app/controllers/api/changesets_controller.rb b/app/controllers/api/changesets_controller.rb index 3df7b75ce..517cff473 100644 --- a/app/controllers/api/changesets_controller.rb +++ b/app/controllers/api/changesets_controller.rb @@ -130,58 +130,6 @@ module Api end end - ## - # download the changeset as an osmChange document. - # - # to make it easier to revert diffs it would be better if the osmChange - # format were reversible, i.e: contained both old and new versions of - # modified elements. but it doesn't at the moment... - # - # this method cannot order the database changes fully (i.e: timestamp and - # version number may be too coarse) so the resulting diff may not apply - # to a different database. however since changesets are not atomic this - # behaviour cannot be guaranteed anyway and is the result of a design - # choice. - def download - changeset = Changeset.find(params[:id]) - - # get all the elements in the changeset which haven't been redacted - # and stick them in a big array. - elements = [changeset.old_nodes.unredacted, - changeset.old_ways.unredacted, - changeset.old_relations.unredacted].flatten - - # sort the elements by timestamp and version number, as this is the - # almost sensible ordering available. this would be much nicer if - # global (SVN-style) versioning were used - then that would be - # unambiguous. - elements.sort_by! { |e| [e.timestamp, e.version] } - - # generate an output element for each operation. note: we avoid looking - # at the history because it is simpler - but it would be more correct to - # check these assertions. - @created = [] - @modified = [] - @deleted = [] - - elements.each do |elt| - if elt.version == 1 - # first version, so it must be newly-created. - @created << elt - elsif elt.visible - # must be a modify - @modified << elt - else - # if the element isn't visible then it must have been deleted - @deleted << elt - end - end - - respond_to do |format| - format.xml - end - end - ## # updates a changeset's tags. none of the changeset's attributes are # user-modifiable, so they will be ignored.