X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/501d13e1c0936cc3ba3d9639620517bae34e5784..a254efb5ec6b30601aeb82cf6380ace02d71c4e8:/app/helpers/browse_helper.rb diff --git a/app/helpers/browse_helper.rb b/app/helpers/browse_helper.rb index f4b332f70..63f48a876 100644 --- a/app/helpers/browse_helper.rb +++ b/app/helpers/browse_helper.rb @@ -1,28 +1,26 @@ module BrowseHelper - def printable_name(object, version=false) - if object.id.is_a?(Array) - id = object.id[0] - else - id = object.id - end - name = t 'printable_name.with_id', :id => id.to_s - if version - name = t 'printable_name.with_version', :id => name, :version => object.version.to_s - end + def printable_name(object, version = false) + id = if object.id.is_a?(Array) + object.id[0] + else + object.id + end + name = t "printable_name.with_id", :id => id.to_s + name = t "printable_name.with_version", :id => name, :version => object.version.to_s if version # don't look at object tags if redacted, so as to avoid giving # away redacted version tag information. unless object.redacted? locale = I18n.locale.to_s - while locale =~ /-[^-]+/ and not object.tags.include? "name:#{I18n.locale}" - locale = locale.sub(/-[^-]+/, "") - end + locale = locale.sub(/-[^-]+/, "") while locale =~ /-[^-]+/ && !object.tags.include?("name:#{I18n.locale}") if object.tags.include? "name:#{locale}" - name = t 'printable_name.with_name_html', :name => content_tag(:bdi, object.tags["name:#{locale}"].to_s ), :id => content_tag(:bdi, name) - elsif object.tags.include? 'name' - name = t 'printable_name.with_name_html', :name => content_tag(:bdi, object.tags['name'].to_s ), :id => content_tag(:bdi, name) + name = t "printable_name.with_name_html", :name => content_tag(:bdi, object.tags["name:#{locale}"].to_s), :id => content_tag(:bdi, name) + elsif object.tags.include? "name" + name = t "printable_name.with_name_html", :name => content_tag(:bdi, object.tags["name"].to_s), :id => content_tag(:bdi, name) + elsif object.tags.include? "ref" + name = t "printable_name.with_name_html", :name => content_tag(:bdi, object.tags["ref"].to_s), :id => content_tag(:bdi, name) end end @@ -30,7 +28,7 @@ module BrowseHelper end def link_class(type, object) - classes = [ type ] + classes = [type] if object.redacted? classes << "deleted" @@ -46,30 +44,12 @@ module BrowseHelper if object.redacted? "" else - h(icon_tags(object).map { |k,v| k + '=' + v }.to_sentence) + h(icon_tags(object).map { |k, v| k + "=" + v }.to_sentence) end end - def format_key(key) - if url = wiki_link("key", key) - link_to h(key), url, :title => t('browse.tag_details.wiki_link.key', :key => key) - else - h(key) - end - end - - def format_value(key, value) - if wp = wikipedia_link(key, value) - link_to h(wp[:title]), wp[:url], :title => t('browse.tag_details.wikipedia_link', :page => wp[:title]) - elsif wdt = wikidata_link(key, value) - link_to h(wdt[:title]), wdt[:url], :title => t('browse.tag_details.wikidata_link', :page => wdt[:title]) - elsif url = wiki_link("tag", "#{key}=#{value}") - link_to h(value), url, :title => t('browse.tag_details.wiki_link.tag', :key => key, :value => value) - elsif url = telephone_link(key, value) - link_to h(value), url, :title => t('browse.tag_details.telephone_link', :phone_number => value) - else - linkify h(value) - end + def link_follow(object) + "nofollow" if object.tags.empty? end def type_and_paginated_count(type, pages) @@ -84,91 +64,11 @@ module BrowseHelper end end -private + private - ICON_TAGS = [ - "aeroway", "amenity", "barrier", "building", "highway", "historic", "landuse", - "leisure", "man_made", "natural", "railway", "shop", "tourism", "waterway" - ] + ICON_TAGS = %w[aeroway amenity barrier building highway historic landuse leisure man_made natural railway shop tourism waterway].freeze def icon_tags(object) - object.tags.find_all { |k,v| ICON_TAGS.include? k }.sort - end - - def wiki_link(type, lookup) - locale = I18n.locale.to_s - - # update-wiki-pages does s/ /_/g on keys before saving them, we - # have to replace spaces with underscore so we'll link - # e.g. `source=Isle of Man Government aerial imagery (2001)' to - # the correct page. - lookup_us = lookup.tr(" ", "_") - - if page = WIKI_PAGES[locale][type][lookup_us] rescue nil - url = "http://wiki.openstreetmap.org/wiki/#{page}?uselang=#{locale}" - elsif page = WIKI_PAGES["en"][type][lookup_us] rescue nil - url = "http://wiki.openstreetmap.org/wiki/#{page}?uselang=#{locale}" - end - - return url - end - - def wikipedia_link(key, value) - # Some k/v's are wikipedia=http://en.wikipedia.org/wiki/Full%20URL - return nil if value =~ /^https?:\/\// - - if key == "wikipedia" - # This regex should match Wikipedia language codes, everything - # from de to zh-classical - if value =~ /^([a-z-]{2,12}):(.+)$/i - # Value is : so split it up - # Note that value is always left as-is, see: https://trac.openstreetmap.org/ticket/4315 - lang = $1 - else - # Value is <title> so default to English Wikipedia - lang = 'en' - end - elsif key =~ /^wikipedia:(\S+)$/ - # Language is in the key, so assume value is the title - lang = $1 - else - # Not a wikipedia key! - return nil - end - - if value =~ /^([^#]*)(#.*)/ then - # Contains a reference to a section of the wikipedia article - # Must break it up to correctly build the url - value = $1 - section = $2 - else - section = "" - end - - return { - :url => "http://#{lang}.wikipedia.org/wiki/#{value}?uselang=#{I18n.locale}#{section}", - :title => value + section - } - end - - def wikidata_link(key, value) - if key == "wikidata" and value =~ /^[Qq][1-9][0-9]*$/ - return { - :url => "//www.wikidata.org/wiki/#{value}?uselang=#{I18n.locale}", - :title => value - } - end - return nil - end - - def telephone_link(key, value) - # does it look like a phone number? eg "+1 (234) 567-8901 " ? - return nil unless value =~ /^\s*\+[\d\s\(\)\/\.-]{6,25}\s*$/ - - # remove all whitespace instead of encoding it http://tools.ietf.org/html/rfc3966#section-5.1.1 - # "+1 (234) 567-8901 " -> "+1(234)567-8901" - valueNoWhitespace = value.gsub(/\s+/, '') - - return "tel:#{valueNoWhitespace}" + object.tags.find_all { |k, _v| ICON_TAGS.include? k }.sort end end