X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/56e7b269a094c77410bc2a95245dbc3836bbe0cc..4a38b3eea4bc36dcbcf625e46689688f3b5b12e2:/.github/workflows/lint.yml?ds=inline diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 0042817d8..8dd3d69a5 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -3,11 +3,11 @@ on: - push - pull_request concurrency: - group: ${{ github.workflow }}-{{ github.head_ref || github.ref }} + group: ${{ github.workflow }}-${{ github.head_ref || github.ref }} cancel-in-progress: true env: os: ubuntu-20.04 - ruby: 2.7 + ruby: '2.7' jobs: rubocop: name: RuboCop @@ -16,21 +16,10 @@ jobs: - name: Check out code uses: actions/checkout@v3 - name: Setup ruby - uses: actions/setup-ruby@v1.1.3 + uses: ruby/setup-ruby@v1 with: ruby-version: ${{ env.ruby }} - - name: Cache gems - uses: actions/cache@v3 - with: - path: vendor/bundle - key: bundle-${{ env.os }}-${{ env.ruby }}-${{ hashFiles('Gemfile.lock') }} - restore-keys: | - bundle-${{ env.os }}-${{ env.ruby }}- - - name: Install gems - run: | - gem install bundler - bundle config set deployment true - bundle install --jobs 4 --retry 3 + bundler-cache: true - name: Run rubocop run: bundle exec rubocop --format fuubar erblint: @@ -40,21 +29,10 @@ jobs: - name: Check out code uses: actions/checkout@v3 - name: Setup ruby - uses: actions/setup-ruby@v1.1.3 + uses: ruby/setup-ruby@v1 with: ruby-version: ${{ env.ruby }} - - name: Cache gems - uses: actions/cache@v3 - with: - path: vendor/bundle - key: bundle-${{ env.os }}-${{ env.ruby }}-${{ hashFiles('Gemfile.lock') }} - restore-keys: | - bundle-${{ env.os }}-${{ env.ruby }}- - - name: Install gems - run: | - gem install bundler - bundle config set deployment true - bundle install --jobs 4 --retry 3 + bundler-cache: true - name: Run erblint run: bundle exec erblint . eslint: @@ -64,16 +42,10 @@ jobs: - name: Check out code uses: actions/checkout@v3 - name: Setup ruby - uses: actions/setup-ruby@v1.1.3 + uses: ruby/setup-ruby@v1 with: ruby-version: ${{ env.ruby }} - - name: Cache gems - uses: actions/cache@v3 - with: - path: vendor/bundle - key: bundle-${{ env.os }}-${{ env.ruby }}-${{ hashFiles('Gemfile.lock') }} - restore-keys: | - bundle-${{ env.os }}-${{ env.ruby }}- + bundler-cache: true - name: Cache node modules uses: actions/cache@v3 with: @@ -81,17 +53,12 @@ jobs: key: yarn-${{ env.os }}-${{ hashFiles('yarn.lock') }} restore-keys: | yarn-${{ env.os }}- - - name: Install gems - run: | - gem install bundler - bundle config set deployment true - bundle install --jobs 4 --retry 3 - name: Install node modules - run: bundle exec rake yarn:install + run: bundle exec bin/yarn install - name: Create dummy database configuration run: cp config/example.database.yml config/database.yml - name: Run eslint - run: bundle exec rake eslint + run: bundle exec rails eslint brakeman: name: Brakeman runs-on: ubuntu-20.04 @@ -99,20 +66,9 @@ jobs: - name: Check out code uses: actions/checkout@v3 - name: Setup ruby - uses: actions/setup-ruby@v1.1.3 + uses: ruby/setup-ruby@v1 with: ruby-version: ${{ env.ruby }} - - name: Cache gems - uses: actions/cache@v3 - with: - path: vendor/bundle - key: bundle-${{ env.os }}-${{ env.ruby }}-${{ hashFiles('Gemfile.lock') }} - restore-keys: | - bundle-${{ env.os }}-${{ env.ruby }}- - - name: Install gems - run: | - gem install bundler - bundle config set deployment true - bundle install --jobs 4 --retry 3 + bundler-cache: true - name: Run brakeman run: bundle exec brakeman -q