X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/5761371a561f785e17e5403cd47f76ecd3604eff..566fb06709d75f12a4854748dd1f1425a4c0480b:/app/models/node.rb?ds=sidebyside diff --git a/app/models/node.rb b/app/models/node.rb index 5e799c8d9..1bec9a33c 100644 --- a/app/models/node.rb +++ b/app/models/node.rb @@ -27,13 +27,12 @@ class Node < ApplicationRecord include GeoRecord include ConsistencyValidations include NotRedactable - include ObjectMetadata self.table_name = "current_nodes" belongs_to :changeset - has_many :old_nodes, -> { order(:version) } + has_many :old_nodes, -> { order(:version) }, :inverse_of => :current_node has_many :way_nodes has_many :ways, :through => :way_nodes @@ -50,8 +49,6 @@ class Node < ApplicationRecord :numericality => { :on => :update, :only_integer => true } validates :version, :presence => true, :numericality => { :only_integer => true } - validates :changeset_id, :presence => true, - :numericality => { :only_integer => true } validates :latitude, :presence => true, :numericality => { :only_integer => true } validates :longitude, :presence => true, @@ -148,7 +145,7 @@ class Node < ApplicationRecord # shouldn't be possible to get race conditions. Node.transaction do lock! - check_consistency(self, new_node, user) + check_update_element_consistency(self, new_node, user) ways = Way.joins(:way_nodes).where(:visible => true, :current_way_nodes => { :node_id => id }).order(:id) raise OSM::APIPreconditionFailedError, "Node #{id} is still used by ways #{ways.collect(&:id).join(',')}." unless ways.empty? @@ -169,7 +166,7 @@ class Node < ApplicationRecord def update_from(new_node, user) Node.transaction do lock! - check_consistency(self, new_node, user) + check_update_element_consistency(self, new_node, user) # update changeset first self.changeset_id = new_node.changeset_id @@ -192,7 +189,7 @@ class Node < ApplicationRecord end def create_with_history(user) - check_create_consistency(self, user) + check_create_element_consistency(self, user) self.version = 0 self.visible = true @@ -202,12 +199,8 @@ class Node < ApplicationRecord save_with_history! end - def tags_as_hash - tags - end - def tags - @tags ||= node_tags.collect { |t| [t.k, t.v] }.to_h + @tags ||= node_tags.to_h { |t| [t.k, t.v] } end attr_writer :tags @@ -239,7 +232,7 @@ class Node < ApplicationRecord private def save_with_history! - t = Time.now.getutc + t = Time.now.utc self.version += 1 self.timestamp = t