X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/5f5f31ee7ecbc673af2bf21a14e76305d0e8355b..29f50775e4153757a50b81eee4735db4c9d9939d:/.rubocop_todo.yml?ds=sidebyside diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 576f6080a..05c4f63e2 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,93 +1,103 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2018-06-19 09:02:55 +0100 using RuboCop version 0.57.2. +# on 2020-08-09 18:49:49 UTC using RuboCop version 0.89.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 34 -Lint/AmbiguousOperator: - Exclude: - - 'test/controllers/amf_controller_test.rb' - - 'test/controllers/changeset_controller_test.rb' - - 'test/lib/bounding_box_test.rb' - - 'test/lib/country_test.rb' +# Work around erblint issues. +# https://github.com/openstreetmap/openstreetmap-website/issues/2472 +require: + - rubocop-minitest + - rubocop-performance + - rubocop-rails -# Offense count: 96 -Lint/AmbiguousRegexpLiteral: - Enabled: false +# Offense count: 568 +# Cop supports --auto-correct. +# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# URISchemes: http, https +Layout/LineLength: + Max: 370 -# Offense count: 32 +# Offense count: 36 # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: Exclude: + - 'app/controllers/api/traces_controller.rb' + - 'app/controllers/api/user_preferences_controller.rb' - 'app/controllers/application_controller.rb' - 'app/controllers/geocoder_controller.rb' - 'app/controllers/notes_controller.rb' - 'app/controllers/traces_controller.rb' - - 'app/controllers/user_controller.rb' - - 'app/controllers/user_preferences_controller.rb' + - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - - 'app/helpers/browse_helper.rb' + - 'app/helpers/browse_tags_helper.rb' + - 'app/mailers/notifier.rb' - 'app/models/client_application.rb' - - 'app/models/notifier.rb' - 'lib/nominatim.rb' - 'lib/osm.rb' - 'script/deliver-message' -# Offense count: 4 -Lint/HandleExceptions: - Exclude: - - 'app/controllers/amf_controller.rb' - - 'app/controllers/user_controller.rb' - -# Offense count: 2 -Lint/ShadowingOuterLocalVariable: - Exclude: - - 'app/views/changeset/list.atom.builder' - -# Offense count: 690 +# Offense count: 682 +# Configuration parameters: IgnoredMethods. Metrics/AbcSize: - Max: 280 + Max: 194 -# Offense count: 41 -# Configuration parameters: CountComments, ExcludedMethods. +# Offense count: 72 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods. +# ExcludedMethods: refine Metrics/BlockLength: - Max: 257 + Max: 71 -# Offense count: 11 +# Offense count: 15 # Configuration parameters: CountBlocks. Metrics/BlockNesting: Max: 5 -# Offense count: 63 -# Configuration parameters: CountComments. +# Offense count: 25 +# Configuration parameters: CountComments, CountAsOne. Metrics/ClassLength: - Max: 1795 + Max: 643 -# Offense count: 72 +# Offense count: 68 +# Configuration parameters: IgnoredMethods. Metrics/CyclomaticComplexity: - Max: 20 + Max: 26 -# Offense count: 688 -# Configuration parameters: CountComments. +# Offense count: 735 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods. Metrics/MethodLength: Max: 179 -# Offense count: 2 -# Configuration parameters: CountComments. -Metrics/ModuleLength: - Max: 135 - # Offense count: 4 # Configuration parameters: CountKeywordArgs. Metrics/ParameterLists: Max: 9 -# Offense count: 71 +# Offense count: 69 +# Configuration parameters: IgnoredMethods. Metrics/PerceivedComplexity: - Max: 23 + Max: 26 + +# Offense count: 540 +Minitest/MultipleAssertions: + Max: 81 + +# Offense count: 26 +# Cop supports --auto-correct. +Minitest/TestMethodName: + Exclude: + - 'test/abilities/api_capability_test.rb' + - 'test/controllers/api/nodes_controller_test.rb' + - 'test/controllers/api/old_nodes_controller_test.rb' + - 'test/controllers/api/relations_controller_test.rb' + - 'test/controllers/api/ways_controller_test.rb' + - 'test/helpers/browse_helper_test.rb' + - 'test/integration/client_applications_test.rb' + - 'test/integration/short_links_test.rb' + - 'test/integration/user_blocks_test.rb' + - 'test/integration/user_creation_test.rb' # Offense count: 6 Naming/AccessorMethodName: @@ -99,10 +109,10 @@ Naming/AccessorMethodName: - 'lib/potlatch.rb' # Offense count: 8 -# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros. +# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros. # NamePrefix: is_, has_, have_ -# NamePrefixBlacklist: is_, has_, have_ -# NameWhitelist: is_a? +# ForbiddenPrefixes: is_, has_, have_ +# AllowedMethods: is_a? # MethodDefinitionMacros: define_method, define_singleton_method Naming/PredicateName: Exclude: @@ -114,25 +124,16 @@ Naming/PredicateName: - 'app/models/user.rb' - 'lib/classic_pagination/pagination.rb' -# Offense count: 6 +# Offense count: 5 # Configuration parameters: Database, Include. # SupportedDatabases: mysql, postgresql # Include: db/migrate/*.rb Rails/BulkChangeTable: Exclude: - 'db/migrate/20111116184519_update_oauth.rb' - - 'db/migrate/20120208122334_merge_acl_address_and_mask.rb' - 'db/migrate/20120208194454_add_domain_to_acl.rb' - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' -# Offense count: 2 -# Configuration parameters: Include. -# Include: app/**/*.rb, config/**/*.rb, lib/**/*.rb -Rails/Exit: - Exclude: - - 'lib/**/*.rake' - - 'lib/daemons/gpx_import.rb' - # Offense count: 2 # Configuration parameters: Include. # Include: app/models/**/*.rb @@ -141,6 +142,21 @@ Rails/HasAndBelongsToMany: - 'app/models/changeset.rb' - 'app/models/user.rb' +# Offense count: 4 +# Configuration parameters: Include. +# Include: app/helpers/**/*.rb +Rails/HelperInstanceVariable: + Exclude: + - 'app/helpers/title_helper.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: Include. +# Include: app/mailers/**/*.rb +Rails/MailerName: + Exclude: + - 'app/mailers/notifier.rb' + # Offense count: 5 # Configuration parameters: Include. # Include: db/migrate/*.rb @@ -152,50 +168,56 @@ Rails/NotNullColumn: - 'db/migrate/025_add_end_time_to_changesets.rb' - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' -# Offense count: 20 +# Offense count: 19 Rails/OutputSafety: Exclude: - - 'app/controllers/user_controller.rb' + - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - - 'app/helpers/changeset_helper.rb' + - 'app/helpers/changesets_helper.rb' - 'app/helpers/geocoder_helper.rb' - 'app/helpers/note_helper.rb' - 'app/helpers/open_graph_helper.rb' - 'app/helpers/user_blocks_helper.rb' - - 'app/helpers/user_roles_helper.rb' - 'lib/rich_text.rb' - 'test/helpers/application_helper_test.rb' -# Offense count: 86 +# Offense count: 95 +# Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: strict, flexible Rails/TimeZone: Enabled: false -# Offense count: 1 -# Configuration parameters: AllowedChars. -Style/AsciiComments: - Exclude: - - 'test/models/message_test.rb' - -# Offense count: 229 -Style/Documentation: - Enabled: false - -# Offense count: 2 +# Offense count: 572 # Cop supports --auto-correct. -Style/IfUnlessModifier: - Exclude: - - 'app/controllers/way_controller.rb' +# Configuration parameters: EnforcedStyle. +# SupportedStyles: always, always_true, never +Style/FrozenStringLiteralComment: + Enabled: false -# Offense count: 70 +# Offense count: 78 # Cop supports --auto-correct. # Configuration parameters: Strict. Style/NumericLiterals: MinDigits: 11 -# Offense count: 3064 -# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. -# URISchemes: http, https -Metrics/LineLength: - Max: 1073 +# Offense count: 20 +Style/OptionalBooleanParameter: + Exclude: + - 'app/controllers/api/notes_controller.rb' + - 'app/controllers/application_controller.rb' + - 'app/helpers/browse_helper.rb' + - 'app/models/changeset.rb' + - 'app/models/node.rb' + - 'app/models/relation.rb' + - 'app/models/trace.rb' + - 'app/models/tracepoint.rb' + - 'app/models/way.rb' + - 'test/models/diary_entry_test.rb' + - 'test/models/trace_test.rb' + - 'test/models/tracetag_test.rb' + +# Offense count: 28 +# Cop supports --auto-correct. +Style/StringConcatenation: + Enabled: false