X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/603d1be4bdb849b4ab1afb53d29a2f59d06d150f..78243f6ab7141296e73d93251feb09dfc051fedd:/app/models/way.rb?ds=inline diff --git a/app/models/way.rb b/app/models/way.rb index c65119235..203d3b703 100644 --- a/app/models/way.rb +++ b/app/models/way.rb @@ -1,199 +1,286 @@ -class Way < ActiveRecord::Base - require 'xml/libxml' - - belongs_to :user - - has_many :way_segments, :foreign_key => 'id', :order => 'sequence_id' - has_many :way_tags, :foreign_key => 'id' - - has_many :old_ways, :foreign_key => 'id', :order => 'version' - - set_table_name 'current_ways' - - def self.from_xml(xml, create=false) - begin - p = XML::Parser.new - p.string = xml - doc = p.parse - - way = Way.new - - doc.find('//osm/way').each do |pt| - if !create and pt['id'] != '0' - way.id = pt['id'].to_i - end - - if create - way.timestamp = Time.now - way.visible = true - else - if pt['timestamp'] - way.timestamp = Time.parse(pt['timestamp']) - end - end - - pt.find('tag').each do |tag| - way.add_tag_keyval(tag['k'], tag['v']) - end - - pt.find('seg').each do |seg| - way.add_seg_num(seg['id']) - end - end - rescue - way = nil +# == Schema Information +# +# Table name: current_ways +# +# id :bigint(8) not null, primary key +# changeset_id :bigint(8) not null +# timestamp :datetime not null +# visible :boolean not null +# version :bigint(8) not null +# +# Indexes +# +# current_ways_timestamp_idx (timestamp) +# +# Foreign Keys +# +# current_ways_changeset_id_fkey (changeset_id => changesets.id) +# + +class Way < ApplicationRecord + require "xml/libxml" + + include ConsistencyValidations + include NotRedactable + + self.table_name = "current_ways" + + belongs_to :changeset + + has_many :old_ways, -> { order(:version) }, :inverse_of => :current_way + + has_many :way_nodes, -> { order(:sequence_id) }, :inverse_of => :way + has_many :nodes, :through => :way_nodes + + has_many :way_tags + + has_many :containing_relation_members, :class_name => "RelationMember", :as => :member + has_many :containing_relations, :class_name => "Relation", :through => :containing_relation_members, :source => :relation + + validates :id, :uniqueness => true, :presence => { :on => :update }, + :numericality => { :on => :update, :only_integer => true } + validates :version, :presence => true, + :numericality => { :only_integer => true } + validates :timestamp, :presence => true + validates :changeset, :associated => true + validates :visible, :inclusion => [true, false] + + scope :visible, -> { where(:visible => true) } + scope :invisible, -> { where(:visible => false) } + + # Read in xml as text and return it's Way object representation + def self.from_xml(xml, create: false) + p = XML::Parser.string(xml, :options => XML::Parser::Options::NOERROR) + doc = p.parse + pt = doc.find_first("//osm/way") + + if pt + Way.from_xml_node(pt, :create => create) + else + raise OSM::APIBadXMLError.new("node", xml, "XML doesn't contain an osm/way element.") end - - return way + rescue LibXML::XML::Error, ArgumentError => e + raise OSM::APIBadXMLError.new("way", xml, e.message) end - def to_xml - doc = OSM::API.new.get_xml_doc - doc.root << to_xml_node() - return doc - end + def self.from_xml_node(pt, create: false) + way = Way.new - def to_xml_node(visible_segments = nil, user_display_name_cache = nil) - el1 = XML::Node.new 'way' - el1['id'] = self.id.to_s - el1['visible'] = self.visible.to_s - el1['timestamp'] = self.timestamp.xmlschema - - user_display_name_cache = {} if user_display_name_cache.nil? - - if user_display_name_cache and user_display_name_cache.key?(self.user_id) - # use the cache if available - elsif self.user.data_public? - user_display_name_cache[self.user_id] = self.user.display_name - else - user_display_name_cache[self.user_id] = nil - end + raise OSM::APIBadXMLError.new("way", pt, "Version is required when updating") unless create || !pt["version"].nil? - el1['user'] = user_display_name_cache[self.user_id] unless user_display_name_cache[self.user_id].nil? + way.version = pt["version"] + raise OSM::APIBadXMLError.new("way", pt, "Changeset id is missing") if pt["changeset"].nil? - # make sure segments are output in sequence_id order - ordered_segments = [] - self.way_segments.each do |seg| - if visible_segments - # if there is a list of visible segments then use that to weed out deleted segments - if visible_segments[seg.segment_id] - ordered_segments[seg.sequence_id] = seg.segment_id.to_s - end - else - # otherwise, manually go to the db to check things - if seg.segment.visible? and seg.segment.from_node.visible? and seg.segment.to_node.visible? - ordered_segments[seg.sequence_id] = seg.segment_id.to_s - end - end - end + way.changeset_id = pt["changeset"] - ordered_segments.each do |seg_id| - if seg_id and seg_id != '0' - e = XML::Node.new 'seg' - e['id'] = seg_id - el1 << e - end - end - - self.way_tags.each do |tag| - e = XML::Node.new 'tag' - e['k'] = tag.k - e['v'] = tag.v - el1 << e + unless create + raise OSM::APIBadXMLError.new("way", pt, "ID is required when updating") if pt["id"].nil? + + way.id = pt["id"].to_i + # .to_i will return 0 if there is no number that can be parsed. + # We want to make sure that there is no id with zero anyway + raise OSM::APIBadUserInput, "ID of way cannot be zero when updating." if way.id.zero? end - return el1 - end - - def segs - unless @segs - @segs = Array.new - self.way_segments.each do |seg| - @segs += [seg.segment_id] - end + + # We don't care about the timestamp nor the visibility as these are either + # set explicitly or implicit in the action. The visibility is set to true, + # and manually set to false before the actual delete. + way.visible = true + + # Start with no tags + way.tags = {} + + # Add in any tags from the XML + pt.find("tag").each do |tag| + raise OSM::APIBadXMLError.new("way", pt, "tag is missing key") if tag["k"].nil? + raise OSM::APIBadXMLError.new("way", pt, "tag is missing value") if tag["v"].nil? + + way.add_tag_keyval(tag["k"], tag["v"]) end - @segs - end - def tags - unless @tags - @tags = Hash.new - self.way_tags.each do |tag| - @tags[tag.k] = tag.v - end + pt.find("nd").each do |nd| + way.add_nd_num(nd["ref"]) end - @tags + + way end - def segs=(s) - @segs = s + def nds + @nds ||= way_nodes.collect(&:node_id) end - def tags=(t) - @tags = t + def tags + @tags ||= way_tags.to_h { |t| [t.k, t.v] } end - def add_seg_num(n) - @segs = Array.new unless @segs - @segs << n.to_i + attr_writer :nds, :tags + + def add_nd_num(n) + @nds ||= [] + @nds << n.to_i end def add_tag_keyval(k, v) - @tags = Hash.new unless @tags + @tags ||= {} + + # duplicate tags are now forbidden, so we can't allow values + # in the hash to be overwritten. + raise OSM::APIDuplicateTagsError.new("way", id, k) if @tags.include? k + @tags[k] = v end - def save_with_history! - t = Time.now + ## + # the integer coords (i.e: unscaled) bounding box of the way, assuming + # straight line segments. + def bbox + lons = nodes.collect(&:longitude) + lats = nodes.collect(&:latitude) + BoundingBox.new(lons.min, lats.min, lons.max, lats.max) + end + def update_from(new_way, user) Way.transaction do - self.timestamp = t - self.save! + lock! + check_update_element_consistency(self, new_way, user) + raise OSM::APIPreconditionFailedError, "Cannot update way #{id}: data is invalid." unless new_way.preconditions_ok?(nds) + + self.changeset_id = new_way.changeset_id + self.changeset = new_way.changeset + self.tags = new_way.tags + self.nds = new_way.nds + self.visible = true + save_with_history! end + end - WayTag.transaction do - tags = self.tags + def create_with_history(user) + check_create_element_consistency(self, user) + raise OSM::APIPreconditionFailedError, "Cannot create way: data is invalid." unless preconditions_ok? - WayTag.delete_all(['id = ?', self.id]) + self.version = 0 + self.visible = true + save_with_history! + end - tags.each do |k,v| - tag = WayTag.new - tag.k = k - tag.v = v - tag.id = self.id - tag.save! - end - end + def preconditions_ok?(old_nodes = []) + return false if nds.empty? + raise OSM::APITooManyWayNodesError.new(id, nds.length, Settings.max_number_of_way_nodes) if nds.length > Settings.max_number_of_way_nodes - WaySegment.transaction do - segs = self.segs + # check only the new nodes, for efficiency - old nodes having been checked last time and can't + # be deleted when they're in-use. + new_nds = (nds - old_nodes).sort.uniq - WaySegment.delete_all(['id = ?', self.id]) + unless new_nds.empty? + # NOTE: nodes are locked here to ensure they can't be deleted before + # the current transaction commits. + db_nds = Node.where(:id => new_nds, :visible => true).lock("for share") - i = 1 - segs.each do |n| - seg = WaySegment.new - seg.id = self.id - seg.segment_id = n - seg.sequence_id = i - seg.save! - i += 1 + if db_nds.length < new_nds.length + missing = new_nds - db_nds.collect(&:id) + raise OSM::APIPreconditionFailedError, "Way #{id} requires the nodes with id in (#{missing.join(',')}), which either do not exist, or are not visible." end end - old_way = OldWay.from_way(self) - old_way.timestamp = t - old_way.save_with_dependencies! + true + end + + def delete_with_history!(new_way, user) + raise OSM::APIAlreadyDeletedError.new("way", new_way.id) unless visible + + # need to start the transaction here, so that the database can + # provide repeatable reads for the used-by checks. this means it + # shouldn't be possible to get race conditions. + Way.transaction do + lock! + check_update_element_consistency(self, new_way, user) + rels = Relation.joins(:relation_members).where(:visible => true, :current_relation_members => { :member_type => "Way", :member_id => id }).order(:id) + raise OSM::APIPreconditionFailedError, "Way #{id} is still used by relations #{rels.collect(&:id).join(',')}." unless rels.empty? + + self.changeset_id = new_way.changeset_id + self.changeset = new_way.changeset + + self.tags = [] + self.nds = [] + self.visible = false + save_with_history! + end end - def preconditions_ok? - return false if self.segs.empty? - self.segs.each do |n| - segment = Segment.find(:first, :conditions => ["id = ?", n]) - unless segment and segment.visible and segment.preconditions_ok? - return false + ## + # if any referenced nodes are placeholder IDs (i.e: are negative) then + # this calling this method will fix them using the map from placeholders + # to IDs +id_map+. + def fix_placeholders!(id_map, placeholder_id = nil) + nds.map! do |node_id| + if node_id.negative? + new_id = id_map[:node][node_id] + raise OSM::APIBadUserInput, "Placeholder node not found for reference #{node_id} in way #{id.nil? ? placeholder_id : id}" if new_id.nil? + + new_id + else + node_id end end - return true end + private + + def save_with_history! + t = Time.now.utc + + self.version += 1 + self.timestamp = t + + # update the bounding box, note that this has to be done both before + # and after the save, so that nodes from both versions are included in the + # bbox. we use a copy of the changeset so that it isn't reloaded + # later in the save. + cs = changeset + cs.update_bbox!(bbox) unless nodes.empty? + + Way.transaction do + # clone the object before saving it so that the original is + # still marked as dirty if we retry the transaction + clone.save! + + tags = self.tags + WayTag.where(:way_id => id).delete_all + tags.each do |k, v| + tag = WayTag.new + tag.way_id = id + tag.k = k + tag.v = v + tag.save! + end + + nds = self.nds + WayNode.where(:way_id => id).delete_all + sequence = 1 + nds.each do |n| + nd = WayNode.new + nd.id = [id, sequence] + nd.node_id = n + nd.save! + sequence += 1 + end + + old_way = OldWay.from_way(self) + old_way.timestamp = t + old_way.save_with_dependencies! + + # reload the way so that the nodes array points to the correct + # new set of nodes. + reload + + # update and commit the bounding box, now that way nodes + # have been updated and we're in a transaction. + cs.update_bbox!(bbox) unless nodes.empty? + + # tell the changeset we updated one element only + cs.add_changes! 1 + + cs.save! + end + end end