X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/631e233280eb6f4f12578e458757b36d66cfb18d..84a0c76ab2a09a05e10b9057c9087a342db5f7e2:/test/controllers/api/changeset_comments_controller_test.rb diff --git a/test/controllers/api/changeset_comments_controller_test.rb b/test/controllers/api/changeset_comments_controller_test.rb index 2a386b3e5..b16ea4502 100644 --- a/test/controllers/api/changeset_comments_controller_test.rb +++ b/test/controllers/api/changeset_comments_controller_test.rb @@ -21,22 +21,6 @@ module Api { :path => "/api/0.6/changeset/1/comment.json", :method => :post }, { :controller => "api/changeset_comments", :action => "create", :changeset_id => "1", :format => "json" } ) - assert_routing( - { :path => "/api/0.6/changeset/comment/1/hide", :method => :post }, - { :controller => "api/changeset_comments", :action => "destroy", :id => "1" } - ) - assert_routing( - { :path => "/api/0.6/changeset/comment/1/hide.json", :method => :post }, - { :controller => "api/changeset_comments", :action => "destroy", :id => "1", :format => "json" } - ) - assert_routing( - { :path => "/api/0.6/changeset/comment/1/unhide", :method => :post }, - { :controller => "api/changeset_comments", :action => "restore", :id => "1" } - ) - assert_routing( - { :path => "/api/0.6/changeset/comment/1/unhide.json", :method => :post }, - { :controller => "api/changeset_comments", :action => "restore", :id => "1", :format => "json" } - ) end def test_index @@ -353,120 +337,6 @@ module Api end end - def test_hide_by_unauthorized - comment = create(:changeset_comment) - - post changeset_comment_hide_path(comment) - - assert_response :unauthorized - assert comment.reload.visible - end - - def test_hide_by_normal_user - comment = create(:changeset_comment) - auth_header = bearer_authorization_header - - post changeset_comment_hide_path(comment), :headers => auth_header - - assert_response :forbidden - assert comment.reload.visible - end - - def test_hide_missing_comment - auth_header = bearer_authorization_header create(:moderator_user) - - post changeset_comment_hide_path(999111), :headers => auth_header - - assert_response :not_found - end - - def test_hide_without_required_scope - comment = create(:changeset_comment) - auth_header = bearer_authorization_header create(:moderator_user), :scopes => %w[read_prefs] - - post changeset_comment_hide_path(comment), :headers => auth_header - - assert_response :forbidden - assert comment.reload.visible - end - - def test_hide_with_write_changeset_comments_scope - comment = create(:changeset_comment) - auth_header = bearer_authorization_header create(:moderator_user), :scopes => %w[write_changeset_comments] - - post changeset_comment_hide_path(comment), :headers => auth_header - - assert_response :success - assert_not comment.reload.visible - end - - def test_hide_with_write_api_scope - comment = create(:changeset_comment) - auth_header = bearer_authorization_header create(:moderator_user), :scopes => %w[write_api] - - post changeset_comment_hide_path(comment), :headers => auth_header - - assert_response :success - assert_not comment.reload.visible - end - - def test_unhide_by_unauthorized - comment = create(:changeset_comment, :visible => false) - - post changeset_comment_unhide_path(comment) - - assert_response :unauthorized - assert_not comment.reload.visible - end - - def test_unhide_by_normal_user - comment = create(:changeset_comment, :visible => false) - auth_header = bearer_authorization_header - - post changeset_comment_unhide_path(comment), :headers => auth_header - - assert_response :forbidden - assert_not comment.reload.visible - end - - def test_unhide_missing_comment - auth_header = bearer_authorization_header create(:moderator_user) - - post changeset_comment_unhide_path(999111), :headers => auth_header - - assert_response :not_found - end - - def test_unhide_without_required_scope - comment = create(:changeset_comment, :visible => false) - auth_header = bearer_authorization_header create(:moderator_user), :scopes => %w[read_prefs] - - post changeset_comment_unhide_path(comment), :headers => auth_header - - assert_response :forbidden - assert_not comment.reload.visible - end - - def test_unhide_with_write_changeset_comments_scope - comment = create(:changeset_comment, :visible => false) - auth_header = bearer_authorization_header create(:moderator_user), :scopes => %w[write_changeset_comments] - - post changeset_comment_unhide_path(comment), :headers => auth_header - - assert_response :success - assert comment.reload.visible - end - - def test_unhide_with_write_api_scope - comment = create(:changeset_comment, :visible => false) - auth_header = bearer_authorization_header create(:moderator_user), :scopes => %w[write_api] - - post changeset_comment_unhide_path(comment), :headers => auth_header - - assert_response :success - assert comment.reload.visible - end - private ##