X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/67017dbca48198e413bd9bb09d70c58f4d837a6a..bd3a7e5f576a192fdc776700805433a8b167b1aa:/app/models/note.rb diff --git a/app/models/note.rb b/app/models/note.rb index 9531e2899..490ff43cb 100644 --- a/app/models/note.rb +++ b/app/models/note.rb @@ -14,6 +14,8 @@ class Note < ActiveRecord::Base validates_inclusion_of :status, :in => ["open", "closed", "hidden"] validate :validate_position + attr_accessible :lat, :lon + after_initialize :set_defaults # Sanity check the latitude and longitude and add an error if it's broken @@ -28,26 +30,14 @@ class Note < ActiveRecord::Base self.save end - # Return a flattened version of the comments for a note - def flatten_comment(separator_char, upto_timestamp = :nil) - resp = "" - comment_no = 1 - self.comments.each do |comment| - next if upto_timestamp != :nil and comment.created_at > upto_timestamp - resp += (comment_no == 1 ? "" : separator_char) - resp += comment.body if comment.body - resp += " [ " - resp += comment.author_name if comment.author_name - resp += " " + comment.created_at.to_s + " ]" - comment_no += 1 - end - - return resp - end - # Check if a note is visible def visible? - return status != "hidden" + status != "hidden" + end + + # Check if a note is closed + def closed? + not closed_at.nil? end # Return the author object, derived from the first comment @@ -60,16 +50,6 @@ class Note < ActiveRecord::Base self.comments.first.author_ip end - # Return the author id, derived from the first comment - def author_id - self.comments.first.author_id - end - - # Return the author name, derived from the first comment - def author_name - self.comments.first.author_name - end - private # Fill in default values for new notes