X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/67a03d44a171a05fc637e1b9ecfc8d3b7769dc85..1d49b0d71df85ca7f6d049c2ccd2bed0999f2a79:/app/models/diary_entry.rb?ds=inline diff --git a/app/models/diary_entry.rb b/app/models/diary_entry.rb index 99a56b2ce..143ddc1dc 100644 --- a/app/models/diary_entry.rb +++ b/app/models/diary_entry.rb @@ -1,40 +1,33 @@ class DiaryEntry < ActiveRecord::Base belongs_to :user, :counter_cache => true - belongs_to :language, :foreign_key => 'language_code' + belongs_to :language, :foreign_key => "language_code" - has_many :comments, :class_name => "DiaryComment", - :include => :user, - :order => "diary_comments.id" - has_many :visible_comments, :class_name => "DiaryComment", - :include => :user, - :conditions => { - :users => { :status => ["active", "confirmed" ] }, - :visible => true - }, - :order => "diary_comments.id" + has_many :comments, -> { order(:id).preload(:user) }, :class_name => "DiaryComment" + has_many :visible_comments, -> { joins(:user).where(:visible => true, :users => { :status => %w[active confirmed] }).order(:id) }, :class_name => "DiaryComment" + has_many :subscriptions, :class_name => "DiaryEntrySubscription" + has_many :subscribers, :through => :subscriptions, :source => :user - scope :visible, where(:visible => true) + scope :visible, -> { where(:visible => true) } - validates_presence_of :title, :body - validates_length_of :title, :within => 1..255 - #validates_length_of :language, :within => 2..5, :allow_nil => false - validates_numericality_of :latitude, :allow_nil => true, - :greater_than_or_equal_to => -90, :less_than_or_equal_to => 90 - validates_numericality_of :longitude, :allow_nil => true, - :greater_than_or_equal_to => -180, :less_than_or_equal_to => 180 - validates_associated :language + validates :title, :body, :presence => true + validates :title, :length => 1..255 + validates :latitude, :allow_nil => true, + :numericality => { :greater_than_or_equal_to => -90, + :less_than_or_equal_to => 90 } + validates :longitude, :allow_nil => true, + :numericality => { :greater_than_or_equal_to => -180, + :less_than_or_equal_to => 180 } + validates :language, :user, :associated => true - attr_accessible :title, :body, :language_code, :latitude, :longitude - - after_initialize :set_defaults + after_save :spam_check def body - RichText.new(read_attribute(:body_format), read_attribute(:body)) + RichText.new(self[:body_format], self[:body]) end -private + private - def set_defaults - self.body_format = "markdown" unless self.attribute_present?(:body_format) + def spam_check + user.spam_check end end