X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/6b09732854d0efa94b5211000afe3226e1f61da0..e434cb154c5ccecd7fc0ce672e4de79bd9e7e06f:/app/assets/javascripts/index/query.js?ds=inline diff --git a/app/assets/javascripts/index/query.js b/app/assets/javascripts/index/query.js index b0fdd54ef..9e82aa496 100644 --- a/app/assets/javascripts/index/query.js +++ b/app/assets/javascripts/index/query.js @@ -4,7 +4,7 @@ OSM.Query = function(map) { var protocol = document.location.protocol === "https:" ? "https:" : "http:", url = protocol + OSM.OVERPASS_URL, queryButton = $(".control-query .control-button"), - uninterestingTags = ['source', 'source_ref', 'source:ref', 'history', 'attribution', 'created_by', 'tiger:county', 'tiger:tlid', 'tiger:upload_uuid'], + uninterestingTags = ['source', 'source_ref', 'source:ref', 'history', 'attribution', 'created_by', 'tiger:county', 'tiger:tlid', 'tiger:upload_uuid', 'KSJ2:curve_id', 'KSJ2:lat', 'KSJ2:lon', 'KSJ2:coordinate', 'KSJ2:filename', 'note:ja'], marker; var featureStyle = { @@ -19,20 +19,18 @@ OSM.Query = function(map) { e.preventDefault(); e.stopPropagation(); - if (queryButton.hasClass("disabled")) return; - if (queryButton.hasClass("active")) { disableQueryMode(); - } else { + } else if (!queryButton.hasClass("disabled")) { enableQueryMode(); } - }).on("disabled", function (e) { + }).on("disabled", function () { if (queryButton.hasClass("active")) { map.off("click", clickHandler); $(map.getContainer()).removeClass("query-active").addClass("query-disabled"); $(this).tooltip("show"); } - }).on("enabled", function (e) { + }).on("enabled", function () { if (queryButton.hasClass("active")) { map.on("click", clickHandler); $(map.getContainer()).removeClass("query-disabled").addClass("query-active"); @@ -42,20 +40,20 @@ OSM.Query = function(map) { $("#sidebar_content") .on("mouseover", ".query-results li.query-result", function () { - var geometry = $(this).data("geometry") + var geometry = $(this).data("geometry"); if (geometry) map.addLayer(geometry); $(this).addClass("selected"); }) .on("mouseout", ".query-results li.query-result", function () { - var geometry = $(this).data("geometry") + var geometry = $(this).data("geometry"); if (geometry) map.removeLayer(geometry); $(this).removeClass("selected"); }) - .on("mousedown", ".query-results li.query-result", function (e) { + .on("mousedown", ".query-results li.query-result", function () { var moved = false; $(this).one("click", function (e) { if (!moved) { - var geometry = $(this).data("geometry") + var geometry = $(this).data("geometry"); if (geometry) map.removeLayer(geometry); if (!$(e.target).is('a')) { @@ -67,7 +65,7 @@ OSM.Query = function(map) { }); }); - function interestingFeature(feature, origin, radius) { + function interestingFeature(feature) { if (feature.tags) { for (var key in feature.tags) { if (uninterestingTags.indexOf(key) < 0) { @@ -83,25 +81,34 @@ OSM.Query = function(map) { var tags = feature.tags; var prefix = ""; - if (tags.boundary === "administrative") { - prefix = I18n.t("geocoder.search_osm_nominatim.admin_levels.level" + tags.admin_level) + if (tags.boundary === "administrative" && tags.admin_level) { + prefix = I18n.t("geocoder.search_osm_nominatim.admin_levels.level" + tags.admin_level, { + defaultValue: I18n.t("geocoder.search_osm_nominatim.prefix.boundary.administrative") + }); } else { var prefixes = I18n.t("geocoder.search_osm_nominatim.prefix"); + var key, value; - for (var key in tags) { - var value = tags[key]; + for (key in tags) { + value = tags[key]; if (prefixes[key]) { if (prefixes[key][value]) { return prefixes[key][value]; - } else { - var first = value.substr(0, 1).toUpperCase(), - rest = value.substr(1).replace(/_/g, " "); - - return first + rest; } } } + + for (key in tags) { + value = tags[key]; + + if (prefixes[key]) { + var first = value.substr(0, 1).toUpperCase(), + rest = value.substr(1).replace(/_/g, " "); + + return first + rest; + } + } } if (!prefix) { @@ -112,12 +119,19 @@ OSM.Query = function(map) { } function featureName(feature) { - var tags = feature.tags; + var tags = feature.tags, + locales = I18n.locales.get(); + + for (var i = 0; i < locales.length; i++) { + if (tags["name:" + locales[i]]) { + return tags["name:" + locales[i]]; + } + } - if (tags["name"]) { - return tags["name"]; - } else if (tags["ref"]) { - return tags["ref"]; + if (tags.name) { + return tags.name; + } else if (tags.ref) { + return tags.ref; } else if (tags["addr:housename"]) { return tags["addr:housename"]; } else if (tags["addr:housenumber"] && tags["addr:street"]) { @@ -181,7 +195,7 @@ OSM.Query = function(map) { for (var i = 0; i < elements.length; i++) { var element = elements[i]; - if (interestingFeature(element, latlng, radius)) { + if (interestingFeature(element)) { var $li = $("
  • ") .addClass("query-result") .data("geometry", featureGeometry(element)) @@ -197,7 +211,7 @@ OSM.Query = function(map) { } } - if ($ul.find("li").length == 0) { + if ($ul.find("li").length === 0) { $("
  • ") .text(I18n.t("javascripts.query.nothing_found")) .appendTo($ul); @@ -263,7 +277,7 @@ OSM.Query = function(map) { marker = L.circle(latlng, radius, featureStyle).addTo(map); $(document).everyTime(75, "fadeQueryMarker", function (i) { - if (i == 10) { + if (i === 10) { map.removeLayer(marker); } else { marker.setStyle({