X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/6ee672fe9500d854b66121879df8f65cfbbdf499..5cbd4038edb32b0304bd766e70fc680ea447b52b:/script/update-spam-blocks

diff --git a/script/update-spam-blocks b/script/update-spam-blocks
index 3cb9dcedd..772417774 100755
--- a/script/update-spam-blocks
+++ b/script/update-spam-blocks
@@ -5,41 +5,36 @@ require 'generator'
 
 addresses = User.count(
   :conditions => {
-    :status => ["suspended", "deleted"],
-    :creation_time => Time.now - 28.days .. Time.now
+    :status => %w(suspended deleted),
+    :creation_time => Time.now - 28.days..Time.now
   },
   :group => :creation_ip
 )
 
-addresses.each do |address,count|
-  if count > 1
-    acl = Acl.find(:first, :conditions => {
-      :address => address,
-    })
-
-    unless acl
-      Acl.create(
-        :address => address,
-        :k => "no_account_creation",
-        :v => "auto_spam_block"
-      )
-
-      puts "Blocked #{address}"
-    end
-  end
+addresses.each do |address, count|
+  next unless count > 1
+  next if Acl.where(:address => address).exists?
+
+  Acl.create({
+               :address => address,
+               :k => "no_account_creation",
+               :v => "auto_spam_block"
+             }, { :without_protection => true })
+
+  puts "Blocked #{address}"
 end
 
 acls = Acl.find(:all, :conditions => {
-  :k => "no_account_creation",
-  :v => "auto_spam_block"
-})
+                  :k => "no_account_creation",
+                  :v => "auto_spam_block"
+                })
 
 acls.each do |acl|
-  unless addresses[acl.address]
-    acl.delete
+  next if addresses[acl.address]
+
+  acl.delete
 
-    puts "Unblocked #{acl.address}"
-  end
+  puts "Unblocked #{acl.address}"
 end
 
 exit 0