X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/71f1554212620cd0078bb04b0e666e0cbf4eb95c..d74d4f8d195673250c3f2e841d28f185d74d8849:/test/functional/trace_controller_test.rb?ds=sidebyside diff --git a/test/functional/trace_controller_test.rb b/test/functional/trace_controller_test.rb index 812143c81..4f75308ef 100644 --- a/test/functional/trace_controller_test.rb +++ b/test/functional/trace_controller_test.rb @@ -4,15 +4,165 @@ class TraceControllerTest < ActionController::TestCase fixtures :users, :gpx_files set_fixture_class :gpx_files => 'Trace' + ## + # test all routes which lead to this controller + def test_routes + assert_routing( + { :path => "/api/0.6/gpx/create", :method => :post }, + { :controller => "trace", :action => "api_create" } + ) + assert_routing( + { :path => "/api/0.6/gpx/1", :method => :get }, + { :controller => "trace", :action => "api_read", :id => "1" } + ) + assert_routing( + { :path => "/api/0.6/gpx/1", :method => :put }, + { :controller => "trace", :action => "api_update", :id => "1" } + ) + assert_routing( + { :path => "/api/0.6/gpx/1", :method => :delete }, + { :controller => "trace", :action => "api_delete", :id => "1" } + ) + assert_recognizes( + { :controller => "trace", :action => "api_read", :id => "1" }, + { :path => "/api/0.6/gpx/1/details", :method => :get } + ) + assert_routing( + { :path => "/api/0.6/gpx/1/data", :method => :get }, + { :controller => "trace", :action => "api_data", :id => "1" } + ) + assert_routing( + { :path => "/api/0.6/gpx/1/data.xml", :method => :get }, + { :controller => "trace", :action => "api_data", :id => "1", :format => "xml" } + ) + + assert_routing( + { :path => "/traces", :method => :get }, + { :controller => "trace", :action => "list" } + ) + assert_routing( + { :path => "/traces/page/1", :method => :get }, + { :controller => "trace", :action => "list", :page => "1" } + ) + assert_routing( + { :path => "/traces/tag/tagname", :method => :get }, + { :controller => "trace", :action => "list", :tag => "tagname" } + ) + assert_routing( + { :path => "/traces/tag/tagname/page/1", :method => :get }, + { :controller => "trace", :action => "list", :tag => "tagname", :page => "1" } + ) + assert_routing( + { :path => "/user/username/traces", :method => :get }, + { :controller => "trace", :action => "list", :display_name => "username" } + ) + assert_routing( + { :path => "/user/username/traces/page/1", :method => :get }, + { :controller => "trace", :action => "list", :display_name => "username", :page => "1" } + ) + assert_routing( + { :path => "/user/username/traces/tag/tagname", :method => :get }, + { :controller => "trace", :action => "list", :display_name => "username", :tag => "tagname" } + ) + assert_routing( + { :path => "/user/username/traces/tag/tagname/page/1", :method => :get }, + { :controller => "trace", :action => "list", :display_name => "username", :tag => "tagname", :page => "1" } + ) + + assert_routing( + { :path => "/traces/mine", :method => :get }, + { :controller => "trace", :action => "mine" } + ) + assert_routing( + { :path => "/traces/mine/page/1", :method => :get }, + { :controller => "trace", :action => "mine", :page => "1" } + ) + assert_routing( + { :path => "/traces/mine/tag/tagname", :method => :get }, + { :controller => "trace", :action => "mine", :tag => "tagname" } + ) + assert_routing( + { :path => "/traces/mine/tag/tagname/page/1", :method => :get }, + { :controller => "trace", :action => "mine", :tag => "tagname", :page => "1" } + ) + + assert_routing( + { :path => "/traces/rss", :method => :get }, + { :controller => "trace", :action => "georss" } + ) + assert_routing( + { :path => "/traces/tag/tagname/rss", :method => :get }, + { :controller => "trace", :action => "georss", :tag => "tagname" } + ) + assert_routing( + { :path => "/user/username/traces/rss", :method => :get }, + { :controller => "trace", :action => "georss", :display_name => "username" } + ) + assert_routing( + { :path => "/user/username/traces/tag/tagname/rss", :method => :get }, + { :controller => "trace", :action => "georss", :display_name => "username", :tag => "tagname" } + ) + + assert_routing( + { :path => "/user/username/traces/1", :method => :get }, + { :controller => "trace", :action => "view", :display_name => "username", :id => "1" } + ) + assert_routing( + { :path => "/user/username/traces/1/picture", :method => :get }, + { :controller => "trace", :action => "picture", :display_name => "username", :id => "1" } + ) + assert_routing( + { :path => "/user/username/traces/1/icon", :method => :get }, + { :controller => "trace", :action => "icon", :display_name => "username", :id => "1" } + ) + + assert_routing( + { :path => "/trace/create", :method => :get }, + { :controller => "trace", :action => "create" } + ) + assert_routing( + { :path => "/trace/create", :method => :post }, + { :controller => "trace", :action => "create" } + ) + assert_routing( + { :path => "/trace/1/data", :method => :get }, + { :controller => "trace", :action => "data", :id => "1" } + ) + assert_routing( + { :path => "/trace/1/data.xml", :method => :get }, + { :controller => "trace", :action => "data", :id => "1", :format => "xml" } + ) + assert_routing( + { :path => "/trace/1/edit", :method => :get }, + { :controller => "trace", :action => "edit", :id => "1" } + ) + assert_routing( + { :path => "/trace/1/edit", :method => :post }, + { :controller => "trace", :action => "edit", :id => "1" } + ) + assert_routing( + { :path => "/trace/1/edit", :method => :put }, + { :controller => "trace", :action => "edit", :id => "1" } + ) + assert_routing( + { :path => "/trace/1/delete", :method => :post }, + { :controller => "trace", :action => "delete", :id => "1" } + ) + end + # Check that the list of changesets is displayed def test_list get :list - assert_response :success - assert_template 'list' + check_trace_list Trace.public + + get :list, :tag => "London" + check_trace_list Trace.tagged("London").public end # Check that I can get mine def test_list_mine + @request.cookies["_osm_username"] = users(:public_user).display_name + # First try to get it when not logged in get :mine assert_redirected_to :controller => 'user', :action => 'login', :referer => '/traces/mine' @@ -20,21 +170,52 @@ class TraceControllerTest < ActionController::TestCase # Now try when logged in get :mine, {}, {:user => users(:public_user).id} assert_redirected_to :controller => 'trace', :action => 'list', :display_name => users(:public_user).display_name + + # Fetch the actual list + get :list, {:display_name => users(:public_user).display_name}, {:user => users(:public_user).id} + check_trace_list users(:public_user).traces + end + + # Check the list of changesets for a specific user + def test_list_user + # Test a user with no traces + get :list, :display_name => users(:second_public_user).display_name + check_trace_list users(:second_public_user).traces.public + + # Test a user with some traces - should see only public ones + get :list, :display_name => users(:public_user).display_name + check_trace_list users(:public_user).traces.public + + @request.cookies["_osm_username"] = users(:normal_user).display_name + + # Should still see only public ones when authenticated as another user + get :list, {:display_name => users(:public_user).display_name}, {:user => users(:normal_user).id} + check_trace_list users(:public_user).traces.public + + @request.cookies["_osm_username"] = users(:public_user).display_name + + # Should see all traces when authenticated as the target user + get :list, {:display_name => users(:public_user).display_name}, {:user => users(:public_user).id} + check_trace_list users(:public_user).traces + + # Should only see traces with the correct tag when a tag is specified + get :list, {:display_name => users(:public_user).display_name, :tag => "London"}, {:user => users(:public_user).id} + check_trace_list users(:public_user).traces.tagged("London") end # Check that the rss loads def test_rss get :georss - assert_rss_success + check_trace_feed Trace.public - get :georss, :display_name => users(:normal_user).display_name - assert_rss_success - end + get :georss, :tag => "London" + check_trace_feed Trace.tagged("London").public - def assert_rss_success - assert_response :success - assert_template nil - assert_equal "application/rss+xml", @response.content_type + get :georss, :display_name => users(:public_user).display_name + check_trace_feed users(:public_user).traces.public + + get :georss, :display_name => users(:public_user).display_name, :tag => "Birmingham" + check_trace_feed users(:public_user).traces.tagged("Birmingham").public end # Check getting a specific trace through the api @@ -159,4 +340,49 @@ class TraceControllerTest < ActionController::TestCase delete :api_delete, :id => gpx_files(:public_trace_file).id assert_response :not_found end + +private + + def check_trace_feed(traces) + assert_response :success + assert_template nil + assert_equal "application/rss+xml", @response.content_type + assert_select "rss", :count => 1 do + assert_select "channel", :count => 1 do + assert_select "title" + assert_select "description" + assert_select "link" + assert_select "image" + assert_select "item", :count => traces.visible.count do |items| + traces.visible.order("timestamp DESC").zip(items).each do |trace,item| + assert_select item, "title", trace.name + assert_select item, "link", "http://test.host/user/#{trace.user.display_name}/traces/#{trace.id}" + assert_select item, "guid", "http://test.host/user/#{trace.user.display_name}/traces/#{trace.id}" + assert_select item, "description" + assert_select item, "author", trace.user.display_name + assert_select item, "pubDate", trace.timestamp.rfc822 + end + end + end + end + end + + def check_trace_list(traces) + assert_response :success + assert_template "list" + + if traces.count > 0 + assert_select "table#trace_list tbody", :count => 1 do + assert_select "tr", :count => traces.visible.count do |rows| + traces.visible.order("timestamp DESC").zip(rows).each do |trace,row| + assert_select row, "span.trace_summary", Regexp.new(Regexp.escape("(#{trace.size} points)")) + assert_select row, "td", Regexp.new(Regexp.escape(trace.description)) + assert_select row, "td", Regexp.new(Regexp.escape("by #{trace.user.display_name}")) + end + end + end + else + assert_select "h4", /Nothing here yet/ + end + end end