X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/7406ae5dcc9cbb177a8ea33085af9caf6e3ebb1b..4087f393a8bf82d44752151ca7215f01a418c8d5:/test/controllers/api/old_nodes_controller_test.rb diff --git a/test/controllers/api/old_nodes_controller_test.rb b/test/controllers/api/old_nodes_controller_test.rb index 737f11c73..a982705ed 100644 --- a/test/controllers/api/old_nodes_controller_test.rb +++ b/test/controllers/api/old_nodes_controller_test.rb @@ -15,7 +15,7 @@ module Api ) assert_routing( { :path => "/api/0.6/node/1/2", :method => :get }, - { :controller => "api/old_nodes", :action => "version", :id => "1", :version => "2" } + { :controller => "api/old_nodes", :action => "show", :id => "1", :version => "2" } ) assert_routing( { :path => "/api/0.6/node/1/history.json", :method => :get }, @@ -23,7 +23,7 @@ module Api ) assert_routing( { :path => "/api/0.6/node/1/2.json", :method => :get }, - { :controller => "api/old_nodes", :action => "version", :id => "1", :version => "2", :format => "json" } + { :controller => "api/old_nodes", :action => "show", :id => "1", :version => "2", :format => "json" } ) assert_routing( { :path => "/api/0.6/node/1/2/redact", :method => :post }, @@ -142,7 +142,7 @@ module Api # check all the versions versions.each_key do |key| - get node_version_path(:id => nodeid, :version => key.to_i) + get api_old_node_path(:id => nodeid, :version => key.to_i) assert_response :success, "couldn't get version #{key.to_i} of node #{nodeid}" @@ -283,12 +283,12 @@ module Api node_v1 = node.old_nodes.find_by(:version => 1) node_v1.redact!(create(:redaction)) - get node_version_path(:id => node_v1.node_id, :version => node_v1.version) + get api_old_node_path(:id => node_v1.node_id, :version => node_v1.version) assert_response :forbidden, "Redacted node shouldn't be visible via the version API." # not even to a logged-in user auth_header = basic_authorization_header create(:user).email, "test" - get node_version_path(:id => node_v1.node_id, :version => node_v1.version), :headers => auth_header + get api_old_node_path(:id => node_v1.node_id, :version => node_v1.version), :headers => auth_header assert_response :forbidden, "Redacted node shouldn't be visible via the version API, even when logged in." end @@ -325,9 +325,9 @@ module Api # check moderator can still see the redacted data, when passing # the appropriate flag - get node_version_path(:id => node_v3.node_id, :version => node_v3.version), :headers => auth_header + get api_old_node_path(:id => node_v3.node_id, :version => node_v3.version), :headers => auth_header assert_response :forbidden, "After redaction, node should be gone for moderator, when flag not passed." - get node_version_path(:id => node_v3.node_id, :version => node_v3.version), :params => { :show_redactions => "true" }, :headers => auth_header + get api_old_node_path(:id => node_v3.node_id, :version => node_v3.version), :params => { :show_redactions => "true" }, :headers => auth_header assert_response :success, "After redaction, node should not be gone for moderator, when flag passed." # and when accessed via history @@ -355,7 +355,7 @@ module Api auth_header = basic_authorization_header create(:user).email, "test" # check can't see the redacted data - get node_version_path(:id => node_v3.node_id, :version => node_v3.version), :headers => auth_header + get api_old_node_path(:id => node_v3.node_id, :version => node_v3.version), :headers => auth_header assert_response :forbidden, "Redacted node shouldn't be visible via the version API." # and when accessed via history @@ -408,7 +408,7 @@ module Api # check moderator can now see the redacted data, when not # passing the aspecial flag - get node_version_path(:id => node_v1.node_id, :version => node_v1.version), :headers => auth_header + get api_old_node_path(:id => node_v1.node_id, :version => node_v1.version), :headers => auth_header assert_response :success, "After unredaction, node should not be gone for moderator." # and when accessed via history @@ -420,7 +420,7 @@ module Api auth_header = basic_authorization_header create(:user).email, "test" # check normal user can now see the redacted data - get node_version_path(:id => node_v1.node_id, :version => node_v1.version), :headers => auth_header + get api_old_node_path(:id => node_v1.node_id, :version => node_v1.version), :headers => auth_header assert_response :success, "After unredaction, node should be visible to normal users." # and when accessed via history @@ -446,7 +446,7 @@ module Api end def do_redact_node(node, redaction, headers = {}) - get node_version_path(:id => node.node_id, :version => node.version), :headers => headers + get api_old_node_path(:id => node.node_id, :version => node.version), :headers => headers assert_response :success, "should be able to get version #{node.version} of node #{node.node_id}." # now redact it @@ -463,7 +463,7 @@ module Api assert_not_nil current_node, "getting node #{node_id} returned nil" # get the "old" version of the node from the old_node interface - get node_version_path(:id => node_id, :version => current_node.version) + get api_old_node_path(:id => node_id, :version => current_node.version) assert_response :success, "cant get old node #{node_id}, v#{current_node.version}" old_node = Node.from_xml(@response.body) @@ -472,7 +472,7 @@ module Api end def check_not_found_id_version(id, version) - get node_version_path(:id => id, :version => version) + get api_old_node_path(:id => id, :version => version) assert_response :not_found rescue ActionController::UrlGenerationError => e assert_match(/No route matches/, e.to_s)