X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/7441f15b4fd59735ae00a16b47cfcf7eb99260a6..7bdd4e6809cb596ee8f1d406c4898bbde1f06521:/.rubocop_todo.yml?ds=sidebyside diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index da801d681..5833a6e35 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,130 +1,114 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2017-10-05 10:04:24 +0100 using RuboCop version 0.50.0. +# on 2021-01-11 19:00:54 UTC using RuboCop version 1.8.1. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth. -# SupportedStyles: aligned, indented -Layout/MultilineOperationIndentation: - Exclude: - - 'lib/bounding_box.rb' - -# Offense count: 34 -Lint/AmbiguousOperator: - Exclude: - - 'test/controllers/amf_controller_test.rb' - - 'test/controllers/changeset_controller_test.rb' - - 'test/lib/bounding_box_test.rb' - - 'test/lib/country_test.rb' +# Work around erblint issues. +# https://github.com/openstreetmap/openstreetmap-website/issues/2472 +require: + - rubocop-minitest + - rubocop-performance + - rubocop-rails -# Offense count: 124 -Lint/AmbiguousRegexpLiteral: - Enabled: false +# Offense count: 544 +# Cop supports --auto-correct. +# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# URISchemes: http, https +Layout/LineLength: + Max: 254 -# Offense count: 32 +# Offense count: 36 # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: Exclude: + - 'app/controllers/api/traces_controller.rb' + - 'app/controllers/api/user_preferences_controller.rb' - 'app/controllers/application_controller.rb' - 'app/controllers/geocoder_controller.rb' - 'app/controllers/notes_controller.rb' - 'app/controllers/traces_controller.rb' - - 'app/controllers/user_controller.rb' - - 'app/controllers/user_preferences_controller.rb' + - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - - 'app/helpers/browse_helper.rb' + - 'app/helpers/browse_tags_helper.rb' + - 'app/mailers/user_mailer.rb' - 'app/models/client_application.rb' - - 'app/models/notifier.rb' - 'lib/nominatim.rb' - 'lib/osm.rb' - 'script/deliver-message' -# Offense count: 4 -Lint/HandleExceptions: - Exclude: - - 'app/controllers/amf_controller.rb' - - 'app/controllers/user_controller.rb' - -# Offense count: 3 -Lint/InterpolationCheck: - Exclude: - - 'test/controllers/node_controller_test.rb' - -# Offense count: 2 -Lint/ShadowingOuterLocalVariable: +# Offense count: 8 +# Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches. +Lint/DuplicateBranch: Exclude: - - 'app/views/changeset/list.atom.builder' + - 'app/controllers/api_controller.rb' + - 'app/controllers/diary_entries_controller.rb' + - 'app/controllers/geocoder_controller.rb' + - 'app/helpers/browse_tags_helper.rb' + - 'lib/password_hash.rb' -# Offense count: 666 +# Offense count: 487 +# Configuration parameters: IgnoredMethods, CountRepeatedAttributes. Metrics/AbcSize: - Max: 280 + Max: 235 -# Offense count: 41 -# Configuration parameters: CountComments, ExcludedMethods. +# Offense count: 62 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. +# IgnoredMethods: refine Metrics/BlockLength: - Max: 257 + Max: 71 -# Offense count: 12 +# Offense count: 15 # Configuration parameters: CountBlocks. Metrics/BlockNesting: Max: 5 -# Offense count: 63 -# Configuration parameters: CountComments. +# Offense count: 24 +# Configuration parameters: CountComments, CountAsOne. Metrics/ClassLength: - Max: 1797 + Max: 587 -# Offense count: 71 +# Offense count: 52 +# Configuration parameters: IgnoredMethods. Metrics/CyclomaticComplexity: - Max: 20 - -# Offense count: 3004 -# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. -# URISchemes: http, https -Metrics/LineLength: - Max: 1073 + Max: 26 -# Offense count: 675 -# Configuration parameters: CountComments. +# Offense count: 553 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. Metrics/MethodLength: Max: 179 -# Offense count: 2 -# Configuration parameters: CountComments. -Metrics/ModuleLength: - Max: 147 - -# Offense count: 4 -# Configuration parameters: CountKeywordArgs. +# Offense count: 1 +# Configuration parameters: CountKeywordArgs, MaxOptionalParameters. Metrics/ParameterLists: - Max: 9 + Max: 6 -# Offense count: 71 +# Offense count: 56 +# Configuration parameters: IgnoredMethods. Metrics/PerceivedComplexity: - Max: 23 + Max: 26 -# Offense count: 5 +# Offense count: 365 +Minitest/MultipleAssertions: + Max: 97 + +# Offense count: 4 Naming/AccessorMethodName: Exclude: - 'app/controllers/application_controller.rb' - 'app/helpers/title_helper.rb' - - 'app/models/old_way.rb' - 'lib/osm.rb' - - 'lib/potlatch.rb' # Offense count: 8 -# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist. +# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros. # NamePrefix: is_, has_, have_ -# NamePrefixBlacklist: is_, has_, have_ -# NameWhitelist: is_a? +# ForbiddenPrefixes: is_, has_, have_ +# AllowedMethods: is_a? +# MethodDefinitionMacros: define_method, define_singleton_method Naming/PredicateName: Exclude: - - 'spec/**/*' - 'app/models/changeset.rb' - 'app/models/old_node.rb' - 'app/models/old_relation.rb' @@ -132,13 +116,15 @@ Naming/PredicateName: - 'app/models/user.rb' - 'lib/classic_pagination/pagination.rb' -# Offense count: 2 -# Configuration parameters: Include. -# Include: app/**/*.rb, config/**/*.rb, lib/**/*.rb -Rails/Exit: +# Offense count: 5 +# Configuration parameters: Database, Include. +# SupportedDatabases: mysql, postgresql +# Include: db/migrate/*.rb +Rails/BulkChangeTable: Exclude: - - 'lib/**/*.rake' - - 'lib/daemons/gpx_import.rb' + - 'db/migrate/20111116184519_update_oauth.rb' + - 'db/migrate/20120208194454_add_domain_to_acl.rb' + - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' # Offense count: 2 # Configuration parameters: Include. @@ -148,6 +134,13 @@ Rails/HasAndBelongsToMany: - 'app/models/changeset.rb' - 'app/models/user.rb' +# Offense count: 3 +# Configuration parameters: Include. +# Include: app/helpers/**/*.rb +Rails/HelperInstanceVariable: + Exclude: + - 'app/helpers/title_helper.rb' + # Offense count: 5 # Configuration parameters: Include. # Include: db/migrate/*.rb @@ -159,71 +152,31 @@ Rails/NotNullColumn: - 'db/migrate/025_add_end_time_to_changesets.rb' - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' -# Offense count: 20 +# Offense count: 8 Rails/OutputSafety: Exclude: - - 'app/controllers/user_controller.rb' + - 'app/controllers/sessions_controller.rb' + - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - - 'app/helpers/changeset_helper.rb' - - 'app/helpers/geocoder_helper.rb' - - 'app/helpers/note_helper.rb' - - 'app/helpers/open_graph_helper.rb' - - 'app/helpers/user_blocks_helper.rb' - - 'app/helpers/user_roles_helper.rb' - 'lib/rich_text.rb' - 'test/helpers/application_helper_test.rb' -# Offense count: 86 -# Configuration parameters: EnforcedStyle, SupportedStyles. +# Offense count: 80 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. # SupportedStyles: strict, flexible Rails/TimeZone: Enabled: false -# Offense count: 1 -Style/AsciiComments: - Exclude: - - 'test/models/message_test.rb' - -# Offense count: 219 -Style/Documentation: - Enabled: false - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: MaxLineLength. -Style/IfUnlessModifier: - Exclude: - - 'app/controllers/way_controller.rb' - -# Offense count: 60 +# Offense count: 558 # Cop supports --auto-correct. -Style/LineEndConcatenation: - Exclude: - - 'db/migrate/008_remove_segments.rb' - - 'db/migrate/020_populate_node_tags_and_remove.rb' - - 'db/migrate/023_add_changesets.rb' - - 'lib/bounding_box.rb' - - 'lib/diff_reader.rb' - - 'lib/osm.rb' - - 'test/controllers/changeset_controller_test.rb' - - 'test/controllers/node_controller_test.rb' - - 'test/controllers/relation_controller_test.rb' - - 'test/controllers/way_controller_test.rb' +# Configuration parameters: EnforcedStyle. +# SupportedStyles: always, always_true, never +Style/FrozenStringLiteralComment: + Enabled: false -# Offense count: 75 +# Offense count: 54 # Cop supports --auto-correct. # Configuration parameters: Strict. Style/NumericLiterals: - MinDigits: 11 - -# Offense count: 95 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: compact, exploded -Style/RaiseArgs: - Enabled: false - -# Offense count: 2 -Style/RescueStandardError: - Exclude: - - 'app/helpers/browse_helper.rb' + MinDigits: 15