X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/77a2657d33f0066dbdda5fce831113b6e165a264..efc65b86a23032e7867314082f80e1da3654b51a:/test/abilities/api_capability_test.rb diff --git a/test/abilities/api_capability_test.rb b/test/abilities/api_capability_test.rb index 0f69ddba9..0945b6290 100644 --- a/test/abilities/api_capability_test.rb +++ b/test/abilities/api_capability_test.rb @@ -8,23 +8,19 @@ class ChangesetCommentApiCapabilityTest < ActiveSupport::TestCase scopes = Set.new ability = ApiAbility.new user, scopes - [:create, :destroy, :restore].each do |action| - assert ability.cannot? action, ChangesetComment - end + assert ability.cannot? :create, ChangesetComment + assert ability.cannot? :create, :changeset_comment_visibility + assert ability.cannot? :destroy, :changeset_comment_visibility end - test "as a normal user with write_api scope" do + test "as a normal user with write_changeset_comments scope" do user = create(:user) - scopes = Set.new %w[write_api] + scopes = Set.new %w[write_changeset_comments] ability = ApiAbility.new user, scopes - [:destroy, :restore].each do |action| - assert ability.cannot? action, ChangesetComment - end - - [:create].each do |action| - assert ability.can? action, ChangesetComment - end + assert ability.can? :create, ChangesetComment + assert ability.cannot? :create, :changeset_comment_visibility + assert ability.cannot? :destroy, :changeset_comment_visibility end test "as a moderator without scopes" do @@ -32,19 +28,19 @@ class ChangesetCommentApiCapabilityTest < ActiveSupport::TestCase scopes = Set.new ability = ApiAbility.new user, scopes - [:create, :destroy, :restore].each do |action| - assert ability.cannot? action, ChangesetComment - end + assert ability.cannot? :create, ChangesetComment + assert ability.cannot? :create, :changeset_comment_visibility + assert ability.cannot? :destroy, :changeset_comment_visibility end - test "as a moderator with write_api scope" do + test "as a moderator with write_changeset_comments scope" do user = create(:moderator_user) - scopes = Set.new %w[write_api] + scopes = Set.new %w[write_changeset_comments] ability = ApiAbility.new user, scopes - [:create, :destroy, :restore].each do |action| - assert ability.can? action, ChangesetComment - end + assert ability.can? :create, ChangesetComment + assert ability.can? :create, :changeset_comment_visibility + assert ability.can? :destroy, :changeset_comment_visibility end end