X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/77e8a16a153752b919a9153c1c9ded9834d387f7..8497760870a104044cfacc77971106b27884bfa8:/.rubocop_todo.yml?ds=inline diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 5f2a84fc9..7384a8d95 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,126 +1,206 @@ -# This configuration was generated by `rubocop --auto-gen-config` -# on 2015-02-25 00:27:05 +0000 using RuboCop version 0.29.1. +# This configuration was generated by +# `rubocop --auto-gen-config` +# on 2024-08-27 18:01:13 UTC using RuboCop version 1.65.1. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 13 -Lint/AmbiguousOperator: - Enabled: false - -# Offense count: 107 -Lint/AmbiguousRegexpLiteral: - Enabled: false +# Work around erblint issues. +# https://github.com/openstreetmap/openstreetmap-website/issues/2472 +require: + - rubocop-minitest + - rubocop-performance + - rubocop-rails + - rubocop-rake -# Offense count: 29 +# Offense count: 13 +# Configuration parameters: Include, MaxAmount. +# Include: **/*_spec.rb, **/spec/**/*, **/test/**/*, **/features/support/factories/**/*.rb +FactoryBot/ExcessiveCreateList: + Exclude: + - 'test/controllers/api/changeset_comments_controller_test.rb' + - 'test/controllers/api/messages_controller_test.rb' + - 'test/controllers/changesets_controller_test.rb' + - 'test/controllers/diary_entries_controller_test.rb' + - 'test/controllers/notes_controller_test.rb' + - 'test/controllers/traces_controller_test.rb' + - 'test/controllers/user_blocks_controller_test.rb' + - 'test/system/users_test.rb' + +# Offense count: 635 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns. +# URISchemes: http, https +Layout/LineLength: + Max: 234 + +# Offense count: 23 +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: - Enabled: false + Exclude: + - 'app/controllers/accounts_controller.rb' + - 'app/controllers/api/traces_controller.rb' + - 'app/controllers/api/user_preferences_controller.rb' + - 'app/controllers/geocoder_controller.rb' + - 'app/controllers/traces_controller.rb' + - 'app/controllers/users_controller.rb' + - 'app/helpers/application_helper.rb' + - 'app/helpers/browse_tags_helper.rb' + - 'app/mailers/user_mailer.rb' + - 'app/models/client_application.rb' + - 'lib/nominatim.rb' + - 'lib/osm.rb' + - 'script/deliver-message' + +# Offense count: 762 +# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes. +Metrics/AbcSize: + Max: 189 -# Offense count: 5 -Lint/HandleExceptions: - Enabled: false +# Offense count: 37 +# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns. +# AllowedMethods: refine +Metrics/BlockLength: + Max: 71 # Offense count: 8 -Lint/ParenthesesAsGroupedExpression: - Enabled: false - -# Offense count: 542 -Metrics/AbcSize: - Max: 280 - -# Offense count: 12 +# Configuration parameters: CountBlocks, CountModifierForms. Metrics/BlockNesting: Max: 5 -# Offense count: 60 -# Configuration parameters: CountComments. +# Offense count: 26 +# Configuration parameters: CountComments, CountAsOne. Metrics/ClassLength: - Max: 1552 + Max: 309 -# Offense count: 68 +# Offense count: 58 +# Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/CyclomaticComplexity: - Max: 21 - -# Offense count: 2092 -# Configuration parameters: AllowURI, URISchemes. -Metrics/LineLength: - Max: 694 + Max: 25 -# Offense count: 520 -# Configuration parameters: CountComments. +# Offense count: 844 +# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns. Metrics/MethodLength: Max: 179 -# Offense count: 4 -# Configuration parameters: CountKeywordArgs. +# Offense count: 1 +# Configuration parameters: CountKeywordArgs, MaxOptionalParameters. Metrics/ParameterLists: - Max: 9 + Max: 6 -# Offense count: 70 +# Offense count: 58 +# Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/PerceivedComplexity: - Max: 24 + Max: 26 + +# Offense count: 2784 +# This cop supports safe autocorrection (--autocorrect). +Minitest/EmptyLineBeforeAssertionMethods: + Enabled: false + +# Offense count: 695 +Minitest/MultipleAssertions: + Max: 60 + +# Offense count: 10 +# This cop supports unsafe autocorrection (--autocorrect-all). +Rails/ActionControllerFlashBeforeRender: + Exclude: + - 'app/controllers/application_controller.rb' + - 'app/controllers/confirmations_controller.rb' + - 'app/controllers/friendships_controller.rb' + - 'app/controllers/issue_comments_controller.rb' + - 'app/controllers/messages_controller.rb' + - 'app/controllers/passwords_controller.rb' + - 'app/controllers/traces_controller.rb' + - 'app/controllers/user_blocks_controller.rb' + - 'app/controllers/users_controller.rb' # Offense count: 2 # Configuration parameters: Include. +# Include: app/models/**/*.rb Rails/HasAndBelongsToMany: - Enabled: false + Exclude: + - 'app/models/changeset.rb' + - 'app/models/user.rb' -# Offense count: 5 -Style/AccessorMethodName: - Enabled: false +# Offense count: 3 +# Configuration parameters: Include. +# Include: app/helpers/**/*.rb +Rails/HelperInstanceVariable: + Exclude: + - 'app/helpers/title_helper.rb' + +# Offense count: 17 +# Configuration parameters: IgnoreScopes, Include. +# Include: app/models/**/*.rb +Rails/InverseOf: + Exclude: + - 'app/models/changeset.rb' + - 'app/models/diary_entry.rb' + - 'app/models/friendship.rb' + - 'app/models/issue.rb' + - 'app/models/message.rb' + - 'app/models/note.rb' + - 'app/models/user.rb' # Offense count: 1 -Style/AsciiComments: - Enabled: false - -# Offense count: 305 -Style/Documentation: - Enabled: false - -# Offense count: 39 -# Configuration parameters: MinBodyLength. -Style/GuardClause: - Enabled: false - -# Offense count: 60 -# Cop supports --auto-correct. -Style/LineEndConcatenation: - Enabled: false +# Configuration parameters: Include. +# Include: app/controllers/**/*.rb, app/mailers/**/*.rb +Rails/LexicallyScopedActionFilter: + Exclude: + - 'app/controllers/oauth2_applications_controller.rb' -# Offense count: 53 -# Cop supports --auto-correct. +# Offense count: 5 +# Configuration parameters: Database, Include. +# SupportedDatabases: mysql +# Include: db/**/*.rb +Rails/NotNullColumn: + Exclude: + - 'db/migrate/002_cleanup_osm_db.rb' + - 'db/migrate/020_populate_node_tags_and_remove.rb' + - 'db/migrate/021_move_to_innodb.rb' + - 'db/migrate/025_add_end_time_to_changesets.rb' + - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' + +# Offense count: 7 +Rails/OutputSafety: + Exclude: + - 'app/helpers/application_helper.rb' + - 'lib/rich_text.rb' + - 'test/helpers/application_helper_test.rb' + +# Offense count: 16 +# Configuration parameters: Include. +# Include: db/**/*.rb +Rails/ThreeStateBooleanColumn: + Exclude: + - 'db/migrate/001_create_osm_db.rb' + - 'db/migrate/006_tile_nodes.rb' + - 'db/migrate/007_add_relations.rb' + - 'db/migrate/054_refactor_map_bug_tables.rb' + - 'db/migrate/20140507110937_create_changeset_comments.rb' + +# Offense count: 6 +# This cop supports safe autocorrection (--autocorrect). +Rake/Desc: + Exclude: + - 'lib/tasks/auto_annotate_models.rake' + - 'lib/tasks/eslint.rake' + - 'lib/tasks/subscribe_diary_authors.rake' + - 'lib/tasks/subscribe_old_changesets.rake' + +# Offense count: 712 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: always, always_true, never +Style/FrozenStringLiteralComment: + Enabled: false + +# Offense count: 78 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: Strict, AllowedNumbers, AllowedPatterns. Style/NumericLiterals: - MinDigits: 11 - -# Offense count: 44 -# Cop supports --auto-correct. -Style/PerlBackrefs: - Enabled: false - -# Offense count: 8 -# Configuration parameters: NamePrefix, NamePrefixBlacklist. -Style/PredicateName: - Enabled: false - -# Offense count: 95 -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/RaiseArgs: - Enabled: false - -# Offense count: 2 -Style/RescueModifier: - Enabled: false - -# Offense count: 8 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/StringLiteralsInInterpolation: - Enabled: false - -# Offense count: 4 -# Cop supports --auto-correct. -# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, Whitelist. -Style/TrivialAccessors: - Enabled: false + MinDigits: 15