X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/7dbf8d83369cb73929080c4ba23fdd7dcd0184df..e89a78fff858d5db07f6959a39dd9655dc46008e:/app/controllers/reports_controller.rb diff --git a/app/controllers/reports_controller.rb b/app/controllers/reports_controller.rb index 8a1bed508..5c70d9704 100644 --- a/app/controllers/reports_controller.rb +++ b/app/controllers/reports_controller.rb @@ -2,27 +2,37 @@ class ReportsController < ApplicationController layout "site" before_action :authorize_web - before_action :require_user + before_action :set_locale + before_action :check_database_readable + + authorize_resource + + before_action :check_database_writable, :only => [:new, :create] def new if required_new_report_params_present? @report = Report.new @report.issue = Issue.find_or_initialize_by(create_new_report_params) else - redirect_to root_path, :notice => t("reports.new.missing_params") + redirect_to root_path, :notice => t(".missing_params") end end def create @report = current_user.reports.new(report_params) - @report.issue = Issue.find_or_initialize_by(:reportable_id => params[:report][:issue][:reportable_id], :reportable_type => params[:report][:issue][:reportable_type]) + @report.issue = Issue + .create_with(:assigned_role => default_assigned_role) + .find_or_initialize_by(issue_params) if @report.save - @report.issue.save - @report.issue.reopen! unless @report.issue.open? - redirect_to helpers.reportable_url(@report.issue.reportable), :notice => t("issues.create.successful_report") + @report.issue.assigned_role = "administrator" if default_assigned_role == "administrator" + @report.issue.reopen unless @report.issue.open? + @report.issue.save! + + redirect_to helpers.reportable_url(@report.issue.reportable), :notice => t(".successful_report") else - redirect_to new_report_path(:reportable_type => @report.issue.reportable_type, :reportable_id => @report.issue.reportable_id), :notice => t("issues.create.provide_details") + flash.now[:notice] = t(".provide_details") + render :action => "new" end end @@ -37,6 +47,24 @@ class ReportsController < ApplicationController end def report_params - params[:report].permit(:details, :category) + params.require(:report).permit(:details, :category) + end + + def issue_params + params.require(:report).require(:issue).permit(:reportable_id, :reportable_type) + end + + def default_assigned_role + case issue_params[:reportable_type] + when "Note" + "moderator" + when "User" + case report_params[:category] + when "vandal" then "moderator" + else "administrator" + end + else + "administrator" + end end end