X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/7eb181999d3357bf210ceb24e18c913bf3ef6ba3..873c1cb84e2fe475bc4ff566d71929fdcc35787d:/app/controllers/message_controller.rb

diff --git a/app/controllers/message_controller.rb b/app/controllers/message_controller.rb
index 395d56028..fd638e4e7 100644
--- a/app/controllers/message_controller.rb
+++ b/app/controllers/message_controller.rb
@@ -2,85 +2,140 @@ class MessageController < ApplicationController
   layout 'site'
 
   before_filter :authorize_web
+  before_filter :set_locale
   before_filter :require_user
+  before_filter :lookup_this_user, :only => [:new]
+  before_filter :check_database_readable
+  before_filter :check_database_writable, :only => [:new, :reply, :mark]
 
+  # Allow the user to write a new message to another user. This action also
+  # deals with the sending of that message to the other user when the user
+  # clicks send.
+  # The display_name param is the display name of the user that the message is being sent to.
   def new
-    @title = 'send message'
     if params[:message]
-      @message = Message.new(params[:message])
-      @message.to_user_id = params[:user_id]
-      @message.from_user_id = @user.id
-      @message.sent_on = Time.now
-   
-      if @message.save
-        flash[:notice] = 'Message sent'
-        Notifier::deliver_message_notification(@message)
-        redirect_to :controller => 'message', :action => 'inbox', :display_name => @user.display_name
-      end
-    end
-  end
+      if @user.sent_messages.where("sent_on >= ?", Time.now.getutc - 1.hour).count >= MAX_MESSAGES_PER_HOUR
+        flash[:error] = t 'message.new.limit_exceeded'
+      else
+        @message = Message.new(message_params)
+        @message.to_user_id = @this_user.id
+        @message.from_user_id = @user.id
+        @message.sent_on = Time.now.getutc
 
-  def destroy
-    @message = Message.find(params[:message_id], :conditions => ["to_user_id = ? or from_user_id = ?", @user.id, @user.id ])
-    if !@message.message_read
-      flash[:notice] = 'Message not read and so not deleted'
-      redirect_to :controller => 'message', :action => 'inbox', :display_name => @user.display_name
+        if @message.save
+          flash[:notice] = t 'message.new.message_sent'
+          Notifier.message_notification(@message).deliver
+          redirect_to :controller => 'message', :action => 'inbox', :display_name => @user.display_name
+        end
+      end
     else
-      flash[:notice] = "Message '#{@message.title}' deleted"
-      @message.destroy
-      redirect_to :controller => 'message', :action => 'inbox', :display_name => @user.display_name
+      @message = Message.new(:recipient => @this_user)
+      @title = t 'message.new.title'
     end
   end
 
+  # Allow the user to reply to another message.
   def reply
-    message = Message.find(params[:message_id], :conditions => ["to_user_id = ? or from_user_id = ?", @user.id, @user.id ])
-    title = message.title.sub(/^Re:\s*/, "Re: ")
-    redirect_to :action => 'new', :user_id => message.from_user_id, :title => title
+    message = Message.find(params[:message_id])
+
+    if message.to_user_id == @user.id then
+      message.update_attribute(:message_read, true)
+
+      @message = Message.new(
+        :recipient => message.sender,
+        :title => "Re: #{message.title.sub(/^Re:\s*/, '')}",
+        :body => "On #{message.sent_on} #{message.sender.display_name} wrote:\n\n#{message.body.gsub(/^/, '> ')}",
+      )
+
+      @title = @message.title
+
+      render :action => 'new'
+    else
+      flash[:notice] = t 'message.reply.wrong_user', :user => @user.display_name
+      redirect_to :controller => "user", :action => "login", :referer => request.fullpath
+    end
   rescue ActiveRecord::RecordNotFound
-    render :nothing => true, :status => :not_found
+    @title = t'message.no_such_message.title'
+    render :action => 'no_such_message', :status => :not_found
   end
 
+  # Show a message
   def read
-    @title = 'read message'
-    @message = Message.find(params[:message_id], :conditions => ["to_user_id = ? or from_user_id = ?", @user.id, @user.id ])
-    @message.message_read = 1 if @message.to_user_id == @user.id
-    @message.save
+    @title = t 'message.read.title'
+    @message = Message.find(params[:message_id])
+
+    if @message.to_user_id == @user.id or @message.from_user_id == @user.id then
+      @message.message_read = true if @message.to_user_id == @user.id
+      @message.save
+    else
+      flash[:notice] = t 'message.read.wrong_user', :user => @user.display_name
+      redirect_to :controller => "user", :action => "login", :referer => request.fullpath
+    end
   rescue ActiveRecord::RecordNotFound
-    render :nothing => true, :status => :not_found
+    @title = t'message.no_such_message.title'
+    render :action => 'no_such_message', :status => :not_found
   end
 
+  # Display the list of messages that have been sent to the user.
   def inbox
-    @title = 'inbox'
+    @title = t 'message.inbox.title'
     if @user and params[:display_name] == @user.display_name
     else
       redirect_to :controller => 'message', :action => 'inbox', :display_name => @user.display_name
     end
   end
 
+  # Display the list of messages that the user has sent to other users.
   def outbox
-    @title = 'outbox'
+    @title = t 'message.outbox.title'
     if @user and params[:display_name] == @user.display_name
     else
       redirect_to :controller => 'message', :action => 'outbox', :display_name => @user.display_name
     end
   end
 
+  # Set the message as being read or unread.
   def mark
-    if params[:message_id]
-      id = params[:message_id]
-      message = Message.find_by_id(id)
-      if params[:mark] == 'unread'
-        message_read = 0 
-        mark_type = 'unread'
+    @message = Message.where("to_user_id = ? OR from_user_id = ?", @user.id, @user.id).find(params[:message_id])
+    if params[:mark] == 'unread'
+      message_read = false
+      notice = t 'message.mark.as_unread'
+    else
+      message_read = true
+      notice = t 'message.mark.as_read'
+    end
+    @message.message_read = message_read
+    if @message.save and not request.xhr?
+      flash[:notice] = notice
+      redirect_to :controller => 'message', :action => 'inbox', :display_name => @user.display_name
+    end
+  rescue ActiveRecord::RecordNotFound
+    @title = t'message.no_such_message.title'
+    render :action => 'no_such_message', :status => :not_found
+  end
+
+  # Delete the message.
+  def delete
+    @message = Message.where("to_user_id = ? OR from_user_id = ?", @user.id, @user.id).find(params[:message_id])
+    @message.from_user_visible = false if @message.sender == @user
+    @message.to_user_visible = false if @message.recipient == @user
+    if @message.save and not request.xhr?
+      flash[:notice] = t 'message.delete.deleted'
+
+      if params[:referer]
+        redirect_to params[:referer]
       else
-        message_read = 1
-        mark_type = 'read'
-      end
-      message.message_read = message_read
-      if message.save
-        flash[:notice] = "Message marked as #{mark_type}"
         redirect_to :controller => 'message', :action => 'inbox', :display_name => @user.display_name
       end
     end
+  rescue ActiveRecord::RecordNotFound
+    @title = t'message.no_such_message.title'
+    render :action => 'no_such_message', :status => :not_found
+  end
+private
+  ##
+  # return permitted message parameters
+  def message_params
+    params.require(:message).permit(:title, :body)
   end
 end