X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/7f619c6484ae92d6ea12f1c3a9f67c3d421ae06a..12ac6f8f27dfe63d9674fba54862db13a9e6d89a:/app/controllers/api/changeset_comments_controller.rb?ds=sidebyside diff --git a/app/controllers/api/changeset_comments_controller.rb b/app/controllers/api/changeset_comments_controller.rb index 8b971834d..756e56dcc 100644 --- a/app/controllers/api/changeset_comments_controller.rb +++ b/app/controllers/api/changeset_comments_controller.rb @@ -17,6 +17,7 @@ module Api # Check the arguments are sane raise OSM::APIBadUserInput, "No id was given" unless params[:id] raise OSM::APIBadUserInput, "No text was given" if params[:text].blank? + raise OSM::APIRateLimitExceeded if rate_limit_exceeded? # Extract the arguments id = params[:id].to_i @@ -41,7 +42,7 @@ module Api # Return a copy of the updated changeset @changeset = changeset - render "api/changesets/changeset" + render "api/changesets/show" respond_to do |format| format.xml @@ -66,7 +67,7 @@ module Api # Return a copy of the updated changeset @changeset = comment.changeset - render "api/changesets/changeset" + render "api/changesets/show" respond_to do |format| format.xml @@ -91,12 +92,22 @@ module Api # Return a copy of the updated changeset @changeset = comment.changeset - render "api/changesets/changeset" + render "api/changesets/show" respond_to do |format| format.xml format.json end end + + private + + ## + # Check if the current user has exceed the rate limit for comments + def rate_limit_exceeded? + recent_comments = current_user.changeset_comments.where("created_at >= ?", Time.now.utc - 1.hour).count + + recent_comments >= current_user.max_changeset_comments_per_hour + end end end