X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/860887de5272c3e2a39cb7e0c9db6f0acba1b4c6..21683db838d66d5b14da08dd5fd467fae09515d4:/app/controllers/way_controller.rb?ds=sidebyside diff --git a/app/controllers/way_controller.rb b/app/controllers/way_controller.rb index c988545c7..e48073e10 100644 --- a/app/controllers/way_controller.rb +++ b/app/controllers/way_controller.rb @@ -15,8 +15,8 @@ class WayController < ApplicationController way = Way.from_xml(request.raw_post, true) # Assume that Way.from_xml has thrown an exception if there is an error parsing the xml - way.create_with_history @user - render :text => way.id.to_s, :content_type => "text/plain" + way.create_with_history current_user + render :plain => way.id.to_s end def read @@ -25,9 +25,9 @@ class WayController < ApplicationController response.last_modified = way.timestamp if way.visible - render :text => way.to_xml.to_s, :content_type => "text/xml" + render :xml => way.to_xml.to_s else - render :text => "", :status => :gone + head :gone end end @@ -36,11 +36,11 @@ class WayController < ApplicationController new_way = Way.from_xml(request.raw_post) unless new_way && new_way.id == way.id - raise OSM::APIBadUserInput.new("The id in the url (#{way.id}) is not the same as provided in the xml (#{new_way.id})") + raise OSM::APIBadUserInput, "The id in the url (#{way.id}) is not the same as provided in the xml (#{new_way.id})" end - way.update_from(new_way, @user) - render :text => way.version.to_s, :content_type => "text/plain" + way.update_from(new_way, current_user) + render :plain => way.version.to_s end # This is the API call to delete a way @@ -49,10 +49,10 @@ class WayController < ApplicationController new_way = Way.from_xml(request.raw_post) if new_way && new_way.id == way.id - way.delete_with_history!(new_way, @user) - render :text => way.version.to_s, :content_type => "text/plain" + way.delete_with_history!(new_way, current_user) + render :plain => way.version.to_s else - render :text => "", :status => :bad_request + head :bad_request end end @@ -73,22 +73,20 @@ class WayController < ApplicationController end doc.root << way.to_xml_node(visible_nodes, changeset_cache, user_display_name_cache) - render :text => doc.to_s, :content_type => "text/xml" + render :xml => doc.to_s else - render :text => "", :status => :gone + head :gone end end def ways unless params["ways"] - raise OSM::APIBadUserInput.new("The parameter ways is required, and must be of the form ways=id[,id[,id...]]") + raise OSM::APIBadUserInput, "The parameter ways is required, and must be of the form ways=id[,id[,id...]]" end ids = params["ways"].split(",").collect(&:to_i) - if ids.empty? - raise OSM::APIBadUserInput.new("No ways were given to search for") - end + raise OSM::APIBadUserInput, "No ways were given to search for" if ids.empty? doc = OSM::API.new.get_xml_doc @@ -96,7 +94,7 @@ class WayController < ApplicationController doc.root << way.to_xml_node end - render :text => doc.to_s, :content_type => "text/xml" + render :xml => doc.to_s end ## @@ -112,6 +110,6 @@ class WayController < ApplicationController doc.root << way.to_xml_node if way.visible end - render :text => doc.to_s, :content_type => "text/xml" + render :xml => doc.to_s end end