X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/8877427ab9e49f509414c2fa4d71ccc3e2ac8796..0d936de9c90f0bf7ab9fe672c3ca8c7397d9ac85:/.rubocop_todo.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index d3e51600d..d63584223 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -13,13 +13,15 @@ Lint/AssignmentInCondition: - 'app/controllers/application_controller.rb' - 'app/controllers/geocoder_controller.rb' - 'app/controllers/notes_controller.rb' + - 'app/controllers/api/traces_controller.rb' - 'app/controllers/traces_controller.rb' - - 'app/controllers/user_controller.rb' - - 'app/controllers/user_preferences_controller.rb' + - 'app/controllers/users_controller.rb' + - 'app/controllers/api/user_preferences_controller.rb' - 'app/helpers/application_helper.rb' - 'app/helpers/browse_helper.rb' + - 'app/helpers/browse_tags_helper.rb' - 'app/models/client_application.rb' - - 'app/models/notifier.rb' + - 'app/mailers/notifier.rb' - 'lib/nominatim.rb' - 'lib/osm.rb' - 'script/deliver-message' @@ -27,18 +29,18 @@ Lint/AssignmentInCondition: # Offense count: 4 Lint/HandleExceptions: Exclude: - - 'app/controllers/amf_controller.rb' - - 'app/controllers/user_controller.rb' + - 'app/controllers/api/amf_controller.rb' + - 'app/controllers/users_controller.rb' # Offense count: 692 Metrics/AbcSize: - Max: 280 + Max: 283 # Offense count: 40 # Configuration parameters: CountComments, ExcludedMethods. # ExcludedMethods: refine Metrics/BlockLength: - Max: 262 + Max: 263 # Offense count: 11 # Configuration parameters: CountBlocks. @@ -48,11 +50,11 @@ Metrics/BlockNesting: # Offense count: 63 # Configuration parameters: CountComments. Metrics/ClassLength: - Max: 1795 + Max: 1627 # Offense count: 72 Metrics/CyclomaticComplexity: - Max: 20 + Max: 23 # Offense count: 691 # Configuration parameters: CountComments. @@ -71,7 +73,7 @@ Metrics/ParameterLists: # Offense count: 72 Metrics/PerceivedComplexity: - Max: 23 + Max: 25 # Offense count: 6 Naming/AccessorMethodName: @@ -98,6 +100,11 @@ Naming/PredicateName: - 'app/models/user.rb' - 'lib/classic_pagination/pagination.rb' +# Disabled pending merge of fix for: +# https://github.com/rubocop-hq/rubocop/issues/6943 +Rails/ActiveRecordOverride: + Enabled: false + # Offense count: 6 # Configuration parameters: Database, Include. # SupportedDatabases: mysql, postgresql @@ -139,9 +146,9 @@ Rails/NotNullColumn: # Offense count: 20 Rails/OutputSafety: Exclude: - - 'app/controllers/user_controller.rb' + - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - - 'app/helpers/changeset_helper.rb' + - 'app/helpers/changesets_helper.rb' - 'app/helpers/geocoder_helper.rb' - 'app/helpers/note_helper.rb' - 'app/helpers/open_graph_helper.rb' @@ -177,7 +184,7 @@ Style/FrozenStringLiteralComment: # Cop supports --auto-correct. Style/IfUnlessModifier: Exclude: - - 'app/controllers/way_controller.rb' + - 'app/controllers/api/ways_controller.rb' # Offense count: 70 # Cop supports --auto-correct.