X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/898cc828dd1f1167f85abbf35c8e3f0ed640ac1e..15a7276a9f50821a7728b4da3af16849284f251b:/app/models/note.rb?ds=inline diff --git a/app/models/note.rb b/app/models/note.rb index bb56c5ce0..27357e58a 100644 --- a/app/models/note.rb +++ b/app/models/note.rb @@ -1,10 +1,7 @@ class Note < ActiveRecord::Base include GeoRecord - has_many :comments, :class_name => "NoteComment", - :foreign_key => :note_id, - :order => :created_at, - :conditions => { :visible => true } + has_many :comments, -> { where(:visible => true).order(:created_at) }, :class_name => "NoteComment", :foreign_key => :note_id validates_presence_of :id, :on => :update validates_uniqueness_of :id @@ -14,7 +11,8 @@ class Note < ActiveRecord::Base validates_inclusion_of :status, :in => ["open", "closed", "hidden"] validate :validate_position - attr_accessible :lat, :lon + scope :visible, -> { where("status != 'hidden'") } + scope :invisible, -> { where("status = 'hidden'") } after_initialize :set_defaults @@ -30,21 +28,11 @@ class Note < ActiveRecord::Base self.save end - # Return a flattened version of the comments for a note - def flatten_comment(separator_char, upto_timestamp = :nil) - resp = "" - comment_no = 1 - self.comments.each do |comment| - next if upto_timestamp != :nil and comment.created_at > upto_timestamp - resp += (comment_no == 1 ? "" : separator_char) - resp += comment.body if comment.body - resp += " [ " - resp += comment.author.display_name if comment.author - resp += " " + comment.created_at.to_s + " ]" - comment_no += 1 - end - - return resp + # Reopen a note + def reopen + self.status = "open" + self.closed_at = nil + self.save end # Check if a note is visible