X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/8a9dbc94c84980debfe0e0aa910775724561cd89..2c497aee7a45c31ae6d1a448c35ce1b3f0ebb608:/.rubocop_todo.yml?ds=inline diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 0a7edc2a5..c03cf665c 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2021-09-14 19:29:59 UTC using RuboCop version 1.21.0. +# on 2022-11-01 18:20:38 UTC using RuboCop version 1.38.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -14,30 +14,18 @@ require: - rubocop-rails - rubocop-rake -# Offense count: 524 -# Cop supports --auto-correct. -# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# Offense count: 555 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, IgnoredPatterns. # URISchemes: http, https Layout/LineLength: - Max: 270 + Max: 248 -# Offense count: 62 -# Cop supports --auto-correct. -Lint/AmbiguousOperatorPrecedence: - Exclude: - - 'app/controllers/geocoder_controller.rb' - - 'app/models/user.rb' - - 'lib/bounding_box.rb' - - 'lib/osm.rb' - - 'lib/rich_text.rb' - - 'lib/short_link.rb' - - 'test/controllers/api/old_nodes_controller_test.rb' - - 'test/lib/short_link_test.rb' - -# Offense count: 34 +# Offense count: 29 # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: Exclude: + - 'app/controllers/accounts_controller.rb' - 'app/controllers/api/traces_controller.rb' - 'app/controllers/api/user_preferences_controller.rb' - 'app/controllers/application_controller.rb' @@ -53,24 +41,14 @@ Lint/AssignmentInCondition: - 'lib/osm.rb' - 'script/deliver-message' -# Offense count: 8 -# Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches. -Lint/DuplicateBranch: - Exclude: - - 'app/controllers/api_controller.rb' - - 'app/controllers/diary_entries_controller.rb' - - 'app/controllers/geocoder_controller.rb' - - 'app/helpers/browse_tags_helper.rb' - - 'lib/password_hash.rb' - -# Offense count: 643 -# Configuration parameters: IgnoredMethods, CountRepeatedAttributes. +# Offense count: 676 +# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods, CountRepeatedAttributes. Metrics/AbcSize: Max: 189 -# Offense count: 69 -# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. -# IgnoredMethods: refine +# Offense count: 73 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods. +# AllowedMethods: refine Metrics/BlockLength: Max: 71 @@ -82,15 +60,15 @@ Metrics/BlockNesting: # Offense count: 25 # Configuration parameters: CountComments, CountAsOne. Metrics/ClassLength: - Max: 337 + Max: 316 # Offense count: 58 -# Configuration parameters: IgnoredMethods. +# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods. Metrics/CyclomaticComplexity: Max: 25 -# Offense count: 716 -# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. +# Offense count: 751 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods. Metrics/MethodLength: Max: 179 @@ -99,23 +77,21 @@ Metrics/MethodLength: Metrics/ParameterLists: Max: 6 -# Offense count: 62 -# Configuration parameters: IgnoredMethods. +# Offense count: 57 +# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods. Metrics/PerceivedComplexity: Max: 26 -# Offense count: 528 -Minitest/MultipleAssertions: - Max: 54 +# Offense count: 2495 +# This cop supports safe autocorrection (--autocorrect). +Minitest/EmptyLineBeforeAssertionMethods: + Enabled: false -# Offense count: 3 -Naming/AccessorMethodName: - Exclude: - - 'app/controllers/application_controller.rb' - - 'app/helpers/title_helper.rb' - - 'lib/osm.rb' +# Offense count: 560 +Minitest/MultipleAssertions: + Max: 52 -# Offense count: 8 +# Offense count: 1 # Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros. # NamePrefix: is_, has_, have_ # ForbiddenPrefixes: is_, has_, have_ @@ -123,12 +99,18 @@ Naming/AccessorMethodName: # MethodDefinitionMacros: define_method, define_singleton_method Naming/PredicateName: Exclude: - - 'app/models/changeset.rb' - - 'app/models/old_node.rb' - - 'app/models/old_relation.rb' - - 'app/models/old_way.rb' - 'app/models/user.rb' - - 'lib/classic_pagination/pagination.rb' + +# Offense count: 8 +# This cop supports unsafe autocorrection (--autocorrect-all). +Rails/ActionControllerFlashBeforeRender: + Exclude: + - 'app/controllers/confirmations_controller.rb' + - 'app/controllers/friendships_controller.rb' + - 'app/controllers/oauth_controller.rb' + - 'app/controllers/traces_controller.rb' + - 'app/controllers/user_blocks_controller.rb' + - 'app/controllers/users_controller.rb' # Offense count: 5 # Configuration parameters: Database, Include. @@ -140,12 +122,6 @@ Rails/BulkChangeTable: - 'db/migrate/20120208194454_add_domain_to_acl.rb' - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' -# Offense count: 43 -# Cop supports --auto-correct. -Rails/ContentTag: - Exclude: - - 'test/lib/locale_test.rb' - # Offense count: 2 # Configuration parameters: Include. # Include: app/models/**/*.rb @@ -161,12 +137,26 @@ Rails/HelperInstanceVariable: Exclude: - 'app/helpers/title_helper.rb' -# Offense count: 1 +# Offense count: 16 +# Configuration parameters: IgnoreScopes, Include. +# Include: app/models/**/*.rb +Rails/InverseOf: + Exclude: + - 'app/models/changeset.rb' + - 'app/models/diary_entry.rb' + - 'app/models/friendship.rb' + - 'app/models/issue.rb' + - 'app/models/message.rb' + - 'app/models/note.rb' + - 'app/models/user.rb' + +# Offense count: 2 # Configuration parameters: Include. -# Include: app/controllers/**/*.rb +# Include: app/controllers/**/*.rb, app/mailers/**/*.rb Rails/LexicallyScopedActionFilter: Exclude: - 'app/controllers/oauth2_applications_controller.rb' + - 'app/controllers/oauth2_authorizations_controller.rb' # Offense count: 5 # Configuration parameters: Include. @@ -188,15 +178,8 @@ Rails/OutputSafety: - 'lib/rich_text.rb' - 'test/helpers/application_helper_test.rb' -# Offense count: 91 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: strict, flexible -Rails/TimeZone: - Enabled: false - # Offense count: 6 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Rake/Desc: Exclude: - 'lib/tasks/auto_annotate_models.rake' @@ -204,15 +187,15 @@ Rake/Desc: - 'lib/tasks/subscribe_diary_authors.rake' - 'lib/tasks/subscribe_old_changesets.rake' -# Offense count: 602 -# Cop supports --auto-correct. +# Offense count: 625 +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: always, always_true, never Style/FrozenStringLiteralComment: Enabled: false -# Offense count: 73 -# Cop supports --auto-correct. -# Configuration parameters: Strict. +# Offense count: 72 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: Strict, AllowedNumbers, AllowedPatterns. Style/NumericLiterals: MinDigits: 15