X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/8a9dbc94c84980debfe0e0aa910775724561cd89..b5f06e06c14f440d3c014b348149fe9ec1b67657:/.rubocop_todo.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 0a7edc2a5..779b3a8fa 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2021-09-14 19:29:59 UTC using RuboCop version 1.21.0. +# on 2021-12-28 19:44:27 UTC using RuboCop version 1.24.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -14,7 +14,7 @@ require: - rubocop-rails - rubocop-rake -# Offense count: 524 +# Offense count: 544 # Cop supports --auto-correct. # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. # URISchemes: http, https @@ -38,6 +38,7 @@ Lint/AmbiguousOperatorPrecedence: # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: Exclude: + - 'app/controllers/accounts_controller.rb' - 'app/controllers/api/traces_controller.rb' - 'app/controllers/api/user_preferences_controller.rb' - 'app/controllers/application_controller.rb' @@ -53,7 +54,7 @@ Lint/AssignmentInCondition: - 'lib/osm.rb' - 'script/deliver-message' -# Offense count: 8 +# Offense count: 7 # Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches. Lint/DuplicateBranch: Exclude: @@ -61,14 +62,13 @@ Lint/DuplicateBranch: - 'app/controllers/diary_entries_controller.rb' - 'app/controllers/geocoder_controller.rb' - 'app/helpers/browse_tags_helper.rb' - - 'lib/password_hash.rb' -# Offense count: 643 +# Offense count: 663 # Configuration parameters: IgnoredMethods, CountRepeatedAttributes. Metrics/AbcSize: Max: 189 -# Offense count: 69 +# Offense count: 72 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. # IgnoredMethods: refine Metrics/BlockLength: @@ -82,14 +82,14 @@ Metrics/BlockNesting: # Offense count: 25 # Configuration parameters: CountComments, CountAsOne. Metrics/ClassLength: - Max: 337 + Max: 313 -# Offense count: 58 +# Offense count: 57 # Configuration parameters: IgnoredMethods. Metrics/CyclomaticComplexity: Max: 25 -# Offense count: 716 +# Offense count: 739 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. Metrics/MethodLength: Max: 179 @@ -99,14 +99,14 @@ Metrics/MethodLength: Metrics/ParameterLists: Max: 6 -# Offense count: 62 +# Offense count: 59 # Configuration parameters: IgnoredMethods. Metrics/PerceivedComplexity: Max: 26 -# Offense count: 528 +# Offense count: 549 Minitest/MultipleAssertions: - Max: 54 + Max: 52 # Offense count: 3 Naming/AccessorMethodName: @@ -140,12 +140,6 @@ Rails/BulkChangeTable: - 'db/migrate/20120208194454_add_domain_to_acl.rb' - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' -# Offense count: 43 -# Cop supports --auto-correct. -Rails/ContentTag: - Exclude: - - 'test/lib/locale_test.rb' - # Offense count: 2 # Configuration parameters: Include. # Include: app/models/**/*.rb @@ -167,6 +161,7 @@ Rails/HelperInstanceVariable: Rails/LexicallyScopedActionFilter: Exclude: - 'app/controllers/oauth2_applications_controller.rb' + - 'app/controllers/oauth2_authorizations_controller.rb' # Offense count: 5 # Configuration parameters: Include. @@ -188,13 +183,6 @@ Rails/OutputSafety: - 'lib/rich_text.rb' - 'test/helpers/application_helper_test.rb' -# Offense count: 91 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: strict, flexible -Rails/TimeZone: - Enabled: false - # Offense count: 6 # Cop supports --auto-correct. Rake/Desc: @@ -204,15 +192,15 @@ Rake/Desc: - 'lib/tasks/subscribe_diary_authors.rake' - 'lib/tasks/subscribe_old_changesets.rake' -# Offense count: 602 +# Offense count: 609 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: always, always_true, never Style/FrozenStringLiteralComment: Enabled: false -# Offense count: 73 +# Offense count: 72 # Cop supports --auto-correct. -# Configuration parameters: Strict. +# Configuration parameters: Strict, AllowedNumbers. Style/NumericLiterals: MinDigits: 15