X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/8dc91ce6a64db96d8295fd3d9dff2779c02e4a71..79c306ad06155549ff6e5929ff20a1149b4862c4:/.rubocop_todo.yml?ds=inline

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index b60dd5332..0dd79ea2a 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2021-12-28 19:44:27 UTC using RuboCop version 1.24.0.
+# on 2024-08-27 18:01:13 UTC using RuboCop version 1.65.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -14,36 +14,36 @@ require:
   - rubocop-rails
   - rubocop-rake
 
-# Offense count: 544
-# Cop supports --auto-correct.
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# Offense count: 13
+# Configuration parameters: Include, MaxAmount.
+# Include: **/*_spec.rb, **/spec/**/*, **/test/**/*, **/features/support/factories/**/*.rb
+FactoryBot/ExcessiveCreateList:
+  Exclude:
+    - 'test/controllers/api/changeset_comments_controller_test.rb'
+    - 'test/controllers/api/messages_controller_test.rb'
+    - 'test/controllers/changesets_controller_test.rb'
+    - 'test/controllers/diary_entries_controller_test.rb'
+    - 'test/controllers/notes_controller_test.rb'
+    - 'test/controllers/traces_controller_test.rb'
+    - 'test/controllers/user_blocks_controller_test.rb'
+    - 'test/system/users_test.rb'
+
+# Offense count: 635
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
 # URISchemes: http, https
 Layout/LineLength:
-  Max: 270
-
-# Offense count: 62
-# Cop supports --auto-correct.
-Lint/AmbiguousOperatorPrecedence:
-  Exclude:
-    - 'app/controllers/geocoder_controller.rb'
-    - 'app/models/user.rb'
-    - 'lib/bounding_box.rb'
-    - 'lib/osm.rb'
-    - 'lib/rich_text.rb'
-    - 'lib/short_link.rb'
-    - 'test/controllers/api/old_nodes_controller_test.rb'
-    - 'test/lib/short_link_test.rb'
+  Max: 234
 
-# Offense count: 34
+# Offense count: 23
+# This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:
     - 'app/controllers/accounts_controller.rb'
     - 'app/controllers/api/traces_controller.rb'
     - 'app/controllers/api/user_preferences_controller.rb'
-    - 'app/controllers/application_controller.rb'
     - 'app/controllers/geocoder_controller.rb'
-    - 'app/controllers/notes_controller.rb'
     - 'app/controllers/traces_controller.rb'
     - 'app/controllers/users_controller.rb'
     - 'app/helpers/application_helper.rb'
@@ -54,43 +54,34 @@ Lint/AssignmentInCondition:
     - 'lib/osm.rb'
     - 'script/deliver-message'
 
-# Offense count: 7
-# Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches.
-Lint/DuplicateBranch:
-  Exclude:
-    - 'app/controllers/api_controller.rb'
-    - 'app/controllers/diary_entries_controller.rb'
-    - 'app/controllers/geocoder_controller.rb'
-    - 'app/helpers/browse_tags_helper.rb'
-
-# Offense count: 663
-# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
+# Offense count: 762
+# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
 Metrics/AbcSize:
   Max: 189
 
-# Offense count: 72
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
-# IgnoredMethods: refine
+# Offense count: 37
+# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
+# AllowedMethods: refine
 Metrics/BlockLength:
   Max: 71
 
-# Offense count: 15
-# Configuration parameters: CountBlocks.
+# Offense count: 8
+# Configuration parameters: CountBlocks, CountModifierForms.
 Metrics/BlockNesting:
   Max: 5
 
-# Offense count: 25
+# Offense count: 26
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
-  Max: 313
+  Max: 309
 
-# Offense count: 57
-# Configuration parameters: IgnoredMethods.
+# Offense count: 58
+# Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/CyclomaticComplexity:
   Max: 25
 
-# Offense count: 739
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
+# Offense count: 844
+# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
   Max: 179
 
@@ -99,46 +90,33 @@ Metrics/MethodLength:
 Metrics/ParameterLists:
   Max: 6
 
-# Offense count: 59
-# Configuration parameters: IgnoredMethods.
+# Offense count: 58
+# Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/PerceivedComplexity:
   Max: 26
 
-# Offense count: 549
+# Offense count: 2784
+# This cop supports safe autocorrection (--autocorrect).
+Minitest/EmptyLineBeforeAssertionMethods:
+  Enabled: false
+
+# Offense count: 695
 Minitest/MultipleAssertions:
-  Max: 52
+  Max: 60
 
-# Offense count: 3
-Naming/AccessorMethodName:
+# Offense count: 10
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Rails/ActionControllerFlashBeforeRender:
   Exclude:
     - 'app/controllers/application_controller.rb'
-    - 'app/helpers/title_helper.rb'
-    - 'lib/osm.rb'
-
-# Offense count: 8
-# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
-# NamePrefix: is_, has_, have_
-# ForbiddenPrefixes: is_, has_, have_
-# AllowedMethods: is_a?
-# MethodDefinitionMacros: define_method, define_singleton_method
-Naming/PredicateName:
-  Exclude:
-    - 'app/models/changeset.rb'
-    - 'app/models/old_node.rb'
-    - 'app/models/old_relation.rb'
-    - 'app/models/old_way.rb'
-    - 'app/models/user.rb'
-    - 'lib/classic_pagination/pagination.rb'
-
-# Offense count: 5
-# Configuration parameters: Database, Include.
-# SupportedDatabases: mysql, postgresql
-# Include: db/migrate/*.rb
-Rails/BulkChangeTable:
-  Exclude:
-    - 'db/migrate/20111116184519_update_oauth.rb'
-    - 'db/migrate/20120208194454_add_domain_to_acl.rb'
-    - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
+    - 'app/controllers/confirmations_controller.rb'
+    - 'app/controllers/friendships_controller.rb'
+    - 'app/controllers/issue_comments_controller.rb'
+    - 'app/controllers/messages_controller.rb'
+    - 'app/controllers/passwords_controller.rb'
+    - 'app/controllers/traces_controller.rb'
+    - 'app/controllers/user_blocks_controller.rb'
+    - 'app/controllers/users_controller.rb'
 
 # Offense count: 2
 # Configuration parameters: Include.
@@ -155,16 +133,30 @@ Rails/HelperInstanceVariable:
   Exclude:
     - 'app/helpers/title_helper.rb'
 
+# Offense count: 17
+# Configuration parameters: IgnoreScopes, Include.
+# Include: app/models/**/*.rb
+Rails/InverseOf:
+  Exclude:
+    - 'app/models/changeset.rb'
+    - 'app/models/diary_entry.rb'
+    - 'app/models/friendship.rb'
+    - 'app/models/issue.rb'
+    - 'app/models/message.rb'
+    - 'app/models/note.rb'
+    - 'app/models/user.rb'
+
 # Offense count: 1
 # Configuration parameters: Include.
-# Include: app/controllers/**/*.rb
+# Include: app/controllers/**/*.rb, app/mailers/**/*.rb
 Rails/LexicallyScopedActionFilter:
   Exclude:
     - 'app/controllers/oauth2_applications_controller.rb'
 
 # Offense count: 5
-# Configuration parameters: Include.
-# Include: db/migrate/*.rb
+# Configuration parameters: Database, Include.
+# SupportedDatabases: mysql
+# Include: db/**/*.rb
 Rails/NotNullColumn:
   Exclude:
     - 'db/migrate/002_cleanup_osm_db.rb'
@@ -173,29 +165,27 @@ Rails/NotNullColumn:
     - 'db/migrate/025_add_end_time_to_changesets.rb'
     - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
 
-# Offense count: 9
+# Offense count: 7
 Rails/OutputSafety:
   Exclude:
-    - 'app/controllers/sessions_controller.rb'
-    - 'app/controllers/users_controller.rb'
     - 'app/helpers/application_helper.rb'
+    - 'app/helpers/user_mailer_helper.rb'
     - 'lib/rich_text.rb'
     - 'test/helpers/application_helper_test.rb'
 
-# Offense count: 23
-# Cop supports --auto-correct.
-Rails/RedundantPresenceValidationOnBelongsTo:
-  Enabled: false
-
-# Offense count: 90
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: strict, flexible
-Rails/TimeZone:
-  Enabled: false
+# Offense count: 16
+# Configuration parameters: Include.
+# Include: db/**/*.rb
+Rails/ThreeStateBooleanColumn:
+  Exclude:
+    - 'db/migrate/001_create_osm_db.rb'
+    - 'db/migrate/006_tile_nodes.rb'
+    - 'db/migrate/007_add_relations.rb'
+    - 'db/migrate/054_refactor_map_bug_tables.rb'
+    - 'db/migrate/20140507110937_create_changeset_comments.rb'
 
 # Offense count: 6
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 Rake/Desc:
   Exclude:
     - 'lib/tasks/auto_annotate_models.rake'
@@ -203,15 +193,15 @@ Rake/Desc:
     - 'lib/tasks/subscribe_diary_authors.rake'
     - 'lib/tasks/subscribe_old_changesets.rake'
 
-# Offense count: 609
-# Cop supports --auto-correct.
+# Offense count: 712
+# This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
 Style/FrozenStringLiteralComment:
   Enabled: false
 
-# Offense count: 72
-# Cop supports --auto-correct.
-# Configuration parameters: Strict, AllowedNumbers.
+# Offense count: 78
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: Strict, AllowedNumbers, AllowedPatterns.
 Style/NumericLiterals:
   MinDigits: 15