X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/908f9b5276602f21f7d492c9949c934dfb1e9365..c18e679be36b95fbf86a1dd5293d74ab70f6db4f:/test/controllers/messages_controller_test.rb diff --git a/test/controllers/messages_controller_test.rb b/test/controllers/messages_controller_test.rb index b5ca0dd3a..8e4d5eeb2 100644 --- a/test/controllers/messages_controller_test.rb +++ b/test/controllers/messages_controller_test.rb @@ -5,40 +5,40 @@ class MessagesControllerTest < ActionController::TestCase # test all routes which lead to this controller def test_routes assert_routing( - { :path => "/user/username/inbox", :method => :get }, - { :controller => "messages", :action => "inbox", :display_name => "username" } + { :path => "/messages/inbox", :method => :get }, + { :controller => "messages", :action => "inbox" } ) assert_routing( - { :path => "/user/username/outbox", :method => :get }, - { :controller => "messages", :action => "outbox", :display_name => "username" } + { :path => "/messages/outbox", :method => :get }, + { :controller => "messages", :action => "outbox" } ) assert_routing( { :path => "/message/new/username", :method => :get }, { :controller => "messages", :action => "new", :display_name => "username" } ) assert_routing( - { :path => "/message/new/username", :method => :post }, - { :controller => "messages", :action => "new", :display_name => "username" } + { :path => "/messages", :method => :post }, + { :controller => "messages", :action => "create" } ) assert_routing( - { :path => "/message/read/1", :method => :get }, - { :controller => "messages", :action => "show", :message_id => "1" } + { :path => "/messages/1", :method => :get }, + { :controller => "messages", :action => "show", :id => "1" } ) assert_routing( - { :path => "/message/mark/1", :method => :post }, + { :path => "/messages/1/mark", :method => :post }, { :controller => "messages", :action => "mark", :message_id => "1" } ) assert_routing( - { :path => "/message/reply/1", :method => :get }, + { :path => "/messages/1/reply", :method => :get }, { :controller => "messages", :action => "reply", :message_id => "1" } ) assert_routing( - { :path => "/message/reply/1", :method => :post }, + { :path => "/messages/1/reply", :method => :post }, { :controller => "messages", :action => "reply", :message_id => "1" } ) assert_routing( - { :path => "/message/delete/1", :method => :post }, - { :controller => "messages", :action => "destroy", :message_id => "1" } + { :path => "/messages/1", :method => :delete }, + { :controller => "messages", :action => "destroy", :id => "1" } ) end @@ -64,7 +64,8 @@ class MessagesControllerTest < ActionController::TestCase assert_response :success assert_template "new" assert_select "title", "Send message | OpenStreetMap" - assert_select "form[action='#{new_message_path(:display_name => recipient_user.display_name)}']", :count => 1 do + assert_select "form[action='/messages']", :count => 1 do + assert_select "input[type='hidden'][name='display_name'][value='#{recipient_user.display_name}']" assert_select "input#message_title", :count => 1 assert_select "textarea#message_body", :count => 1 assert_select "input[type='submit'][value='Send']", :count => 1 @@ -82,15 +83,18 @@ class MessagesControllerTest < ActionController::TestCase # Check that we can't send a message from a GET request assert_difference "ActionMailer::Base.deliveries.size", 0 do assert_difference "Message.count", 0 do - get :new, - :params => { :display_name => recipient_user.display_name, - :message => { :title => "Test Message", :body => "Test message body" } } + perform_enqueued_jobs do + get :new, + :params => { :display_name => recipient_user.display_name, + :message => { :title => "Test Message", :body => "Test message body" } } + end end end assert_response :success assert_template "new" assert_select "title", "Send message | OpenStreetMap" - assert_select "form[action='#{new_message_path(:display_name => recipient_user.display_name)}']", :count => 1 do + assert_select "form[action='/messages']", :count => 1 do + assert_select "input[type='hidden'][name='display_name'][value='#{recipient_user.display_name}']" assert_select "input#message_title", :count => 1 do assert_select "[value='Test Message']" end @@ -110,15 +114,18 @@ class MessagesControllerTest < ActionController::TestCase # Check that the subject is preserved over errors assert_difference "ActionMailer::Base.deliveries.size", 0 do assert_difference "Message.count", 0 do - post :new, - :params => { :display_name => recipient_user.display_name, - :message => { :title => "Test Message", :body => "" } } + perform_enqueued_jobs do + post :new, + :params => { :display_name => recipient_user.display_name, + :message => { :title => "Test Message", :body => "" } } + end end end assert_response :success assert_template "new" assert_select "title", "Send message | OpenStreetMap" - assert_select "form[action='#{new_message_path(:display_name => recipient_user.display_name)}']", :count => 1 do + assert_select "form[action='/messages']", :count => 1 do + assert_select "input[type='hidden'][name='display_name'][value='#{recipient_user.display_name}']" assert_select "input#message_title", :count => 1 do assert_select "[value='Test Message']" end @@ -138,15 +145,18 @@ class MessagesControllerTest < ActionController::TestCase # Check that the body text is preserved over errors assert_difference "ActionMailer::Base.deliveries.size", 0 do assert_difference "Message.count", 0 do - post :new, - :params => { :display_name => recipient_user.display_name, - :message => { :title => "", :body => "Test message body" } } + perform_enqueued_jobs do + post :new, + :params => { :display_name => recipient_user.display_name, + :message => { :title => "", :body => "Test message body" } } + end end end assert_response :success assert_template "new" assert_select "title", "Send message | OpenStreetMap" - assert_select "form[action='#{new_message_path(:display_name => recipient_user.display_name)}']", :count => 1 do + assert_select "form[action='/messages']", :count => 1 do + assert_select "input[type='hidden'][name='display_name'][value='#{recipient_user.display_name}']" assert_select "input#message_title", :count => 1 do assert_select "[value='']" end @@ -166,19 +176,21 @@ class MessagesControllerTest < ActionController::TestCase # Check that sending a message works assert_difference "ActionMailer::Base.deliveries.size", 1 do assert_difference "Message.count", 1 do - post :new, - :params => { :display_name => recipient_user.display_name, - :message => { :title => "Test Message", :body => "Test message body" } } + perform_enqueued_jobs do + post :create, + :params => { :display_name => recipient_user.display_name, + :message => { :title => "Test Message", :body => "Test message body" } } + end end end - assert_redirected_to inbox_path(:display_name => user.display_name) + assert_redirected_to inbox_messages_path assert_equal "Message sent", flash[:notice] e = ActionMailer::Base.deliveries.first assert_equal [recipient_user.email], e.to assert_equal "[OpenStreetMap] Test Message", e.subject - assert_match /Test message body/, e.text_part.decoded - assert_match /Test message body/, e.html_part.decoded - assert_match %r{#{SERVER_URL}/message/read/}, e.text_part.decoded + assert_match(/Test message body/, e.text_part.decoded) + assert_match(/Test message body/, e.html_part.decoded) + assert_match %r{#{SERVER_URL}/messages/[0-9]+}, e.text_part.decoded ActionMailer::Base.deliveries.clear m = Message.last assert_equal user.id, m.from_user_id @@ -191,7 +203,7 @@ class MessagesControllerTest < ActionController::TestCase # Asking to send a message with a bogus user name should fail get :new, :params => { :display_name => "non_existent_user" } assert_response :not_found - assert_template "user/no_such_user" + assert_template "users/no_such_user" assert_select "h1", "The user non_existent_user does not exist" end @@ -207,12 +219,14 @@ class MessagesControllerTest < ActionController::TestCase assert_no_difference "ActionMailer::Base.deliveries.size" do assert_no_difference "Message.count" do with_message_limit(0) do - post :new, - :params => { :display_name => recipient_user.display_name, - :message => { :title => "Test Message", :body => "Test message body" } } - assert_response :success - assert_template "new" - assert_select ".error", /wait a while/ + perform_enqueued_jobs do + post :create, + :params => { :display_name => recipient_user.display_name, + :message => { :title => "Test Message", :body => "Test message body" } } + assert_response :success + assert_template "new" + assert_select ".error", /wait a while/ + end end end end @@ -228,14 +242,14 @@ class MessagesControllerTest < ActionController::TestCase # Check that the message reply page requires us to login get :reply, :params => { :message_id => unread_message.id } - assert_redirected_to login_path(:referer => reply_message_path(:message_id => unread_message.id)) + assert_redirected_to login_path(:referer => message_reply_path(:message_id => unread_message.id)) # Login as the wrong user session[:user] = other_user.id # Check that we can't reply to somebody else's message get :reply, :params => { :message_id => unread_message.id } - assert_redirected_to login_path(:referer => reply_message_path(:message_id => unread_message.id)) + assert_redirected_to login_path(:referer => message_reply_path(:message_id => unread_message.id)) assert_equal "You are logged in as `#{other_user.display_name}' but the message you have asked to reply to was not sent to that user. Please login as the correct user in order to reply.", flash[:notice] # Login as the right user @@ -246,7 +260,8 @@ class MessagesControllerTest < ActionController::TestCase assert_response :success assert_template "new" assert_select "title", "Re: #{unread_message.title} | OpenStreetMap" - assert_select "form[action='#{new_message_path(:display_name => user.display_name)}']", :count => 1 do + assert_select "form[action='/messages']", :count => 1 do + assert_select "input[type='hidden'][name='display_name'][value='#{user.display_name}']" assert_select "input#message_title[value='Re: #{unread_message.title}']", :count => 1 assert_select "textarea#message_body", :count => 1 assert_select "input[type='submit'][value='Send']", :count => 1 @@ -273,22 +288,22 @@ class MessagesControllerTest < ActionController::TestCase unread_message = create(:message, :unread, :sender => user, :recipient => recipient_user) # Check that the show message page requires us to login - get :show, :params => { :message_id => unread_message.id } - assert_redirected_to login_path(:referer => message_path(:message_id => unread_message.id)) + get :show, :params => { :id => unread_message.id } + assert_redirected_to login_path(:referer => message_path(:id => unread_message.id)) # Login as the wrong user session[:user] = other_user.id # Check that we can't read the message - get :show, :params => { :message_id => unread_message.id } - assert_redirected_to login_path(:referer => message_path(:message_id => unread_message.id)) + get :show, :params => { :id => unread_message.id } + assert_redirected_to login_path(:referer => message_path(:id => unread_message.id)) assert_equal "You are logged in as `#{other_user.display_name}' but the message you have asked to read was not sent by or to that user. Please login as the correct user in order to read it.", flash[:notice] # Login as the message sender session[:user] = user.id # Check that the message sender can read the message - get :show, :params => { :message_id => unread_message.id } + get :show, :params => { :id => unread_message.id } assert_response :success assert_template "show" assert_equal false, Message.find(unread_message.id).message_read @@ -297,7 +312,7 @@ class MessagesControllerTest < ActionController::TestCase session[:user] = recipient_user.id # Check that the message recipient can read the message - get :show, :params => { :message_id => unread_message.id } + get :show, :params => { :id => unread_message.id } assert_response :success assert_template "show" assert_equal true, Message.find(unread_message.id).message_read @@ -308,7 +323,7 @@ class MessagesControllerTest < ActionController::TestCase end # Asking to read a message with a bogus ID should fail - get :show, :params => { :message_id => 99999 } + get :show, :params => { :id => 99999 } assert_response :not_found assert_template "no_such_message" end @@ -317,55 +332,45 @@ class MessagesControllerTest < ActionController::TestCase # test the inbox action def test_inbox user = create(:user) - other_user = create(:user) read_message = create(:message, :read, :recipient => user) # Check that the inbox page requires us to login - get :inbox, :params => { :display_name => user.display_name } - assert_redirected_to login_path(:referer => inbox_path(:display_name => user.display_name)) + get :inbox + assert_redirected_to login_path(:referer => inbox_messages_path) # Login session[:user] = user.id # Check that we can view our inbox when logged in - get :inbox, :params => { :display_name => user.display_name } + get :inbox assert_response :success assert_template "inbox" assert_select "table.messages", :count => 1 do assert_select "tr", :count => 2 assert_select "tr#inbox-#{read_message.id}.inbox-row", :count => 1 end - - # Check that we can't view somebody else's inbox when logged in - get :inbox, :params => { :display_name => other_user.display_name } - assert_redirected_to inbox_path(:display_name => user.display_name) end ## # test the outbox action def test_outbox user = create(:user) - other_user = create(:user) create(:message, :sender => user) # Check that the outbox page requires us to login - get :outbox, :params => { :display_name => user.display_name } - assert_redirected_to login_path(:referer => outbox_path(:display_name => user.display_name)) + get :outbox + assert_redirected_to login_path(:referer => outbox_messages_path) # Login session[:user] = user.id # Check that we can view our outbox when logged in - get :outbox, :params => { :display_name => user.display_name } + get :outbox assert_response :success assert_template "outbox" assert_select "table.messages", :count => 1 do assert_select "tr", :count => 2 assert_select "tr.inbox-row", :count => 1 end - - # Check that we can't view somebody else's outbox when logged in - get :outbox, :params => { :display_name => other_user.display_name } - assert_redirected_to outbox_path(:display_name => user.display_name) end ## @@ -393,12 +398,12 @@ class MessagesControllerTest < ActionController::TestCase # Check that the marking a message read works post :mark, :params => { :message_id => unread_message.id, :mark => "read" } - assert_redirected_to inbox_path(:display_name => recipient_user.display_name) + assert_redirected_to inbox_messages_path assert_equal true, Message.find(unread_message.id).message_read # Check that the marking a message unread works post :mark, :params => { :message_id => unread_message.id, :mark => "unread" } - assert_redirected_to inbox_path(:display_name => recipient_user.display_name) + assert_redirected_to inbox_messages_path assert_equal false, Message.find(unread_message.id).message_read # Check that the marking a message read via XHR works @@ -434,14 +439,14 @@ class MessagesControllerTest < ActionController::TestCase sent_message = create(:message, :unread, :recipient => second_user, :sender => user) # Check that destroying a message requires us to login - post :destroy, :params => { :message_id => read_message.id } + delete :destroy, :params => { :id => read_message.id } assert_response :forbidden # Login as a user with no messages session[:user] = other_user.id # Check that destroying a message we didn't send or receive fails - post :destroy, :params => { :message_id => read_message.id } + delete :destroy, :params => { :id => read_message.id } assert_response :not_found assert_template "no_such_message" @@ -449,16 +454,16 @@ class MessagesControllerTest < ActionController::TestCase session[:user] = user.id # Check that the destroy a received message works - post :destroy, :params => { :message_id => read_message.id } - assert_redirected_to inbox_path(:display_name => user.display_name) + delete :destroy, :params => { :id => read_message.id } + assert_redirected_to inbox_messages_path assert_equal "Message deleted", flash[:notice] m = Message.find(read_message.id) assert_equal true, m.from_user_visible assert_equal false, m.to_user_visible # Check that the destroying a sent message works - post :destroy, :params => { :message_id => sent_message.id, :referer => outbox_path(:display_name => user.display_name) } - assert_redirected_to outbox_path(:display_name => user.display_name) + delete :destroy, :params => { :id => sent_message.id, :referer => outbox_messages_path } + assert_redirected_to outbox_messages_path assert_equal "Message deleted", flash[:notice] m = Message.find(sent_message.id) assert_equal false, m.from_user_visible @@ -470,7 +475,7 @@ class MessagesControllerTest < ActionController::TestCase end # Asking to destroy a message with a bogus ID should fail - post :destroy, :params => { :message_id => 99999 } + delete :destroy, :params => { :id => 99999 } assert_response :not_found assert_template "no_such_message" end