X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/945ff7911ca51dc250ffaba71f62821b5c0c0a95..6a1a4a3f7deef24396f963318c0e9c1c7af5bc92:/app/controllers/node_controller.rb?ds=sidebyside diff --git a/app/controllers/node_controller.rb b/app/controllers/node_controller.rb index 8d29fd072..29651bceb 100644 --- a/app/controllers/node_controller.rb +++ b/app/controllers/node_controller.rb @@ -18,8 +18,8 @@ class NodeController < ApplicationController node = Node.from_xml(request.raw_post, true) # Assume that Node.from_xml has thrown an exception if there is an error parsing the xml - node.create_with_history @user - render :text => node.id.to_s, :content_type => "text/plain" + node.create_with_history current_user + render :plain => node.id.to_s end # Dump the details on a node given in params[:id] @@ -29,9 +29,9 @@ class NodeController < ApplicationController response.last_modified = node.timestamp if node.visible - render :text => node.to_xml.to_s, :content_type => "text/xml" + render :xml => node.to_xml.to_s else - render :text => "", :status => :gone + head :gone end end @@ -41,11 +41,11 @@ class NodeController < ApplicationController new_node = Node.from_xml(request.raw_post) unless new_node && new_node.id == node.id - raise OSM::APIBadUserInput.new("The id in the url (#{node.id}) is not the same as provided in the xml (#{new_node.id})") + raise OSM::APIBadUserInput, "The id in the url (#{node.id}) is not the same as provided in the xml (#{new_node.id})" end - node.update_from(new_node, @user) - render :text => node.version.to_s, :content_type => "text/plain" + node.update_from(new_node, current_user) + render :plain => node.version.to_s end # Delete a node. Doesn't actually delete it, but retains its history @@ -56,22 +56,22 @@ class NodeController < ApplicationController new_node = Node.from_xml(request.raw_post) unless new_node && new_node.id == node.id - raise OSM::APIBadUserInput.new("The id in the url (#{node.id}) is not the same as provided in the xml (#{new_node.id})") + raise OSM::APIBadUserInput, "The id in the url (#{node.id}) is not the same as provided in the xml (#{new_node.id})" end - node.delete_with_history!(new_node, @user) - render :text => node.version.to_s, :content_type => "text/plain" + node.delete_with_history!(new_node, current_user) + render :plain => node.version.to_s end # Dump the details on many nodes whose ids are given in the "nodes" parameter. def nodes unless params["nodes"] - raise OSM::APIBadUserInput.new("The parameter nodes is required, and must be of the form nodes=id[,id[,id...]]") + raise OSM::APIBadUserInput, "The parameter nodes is required, and must be of the form nodes=id[,id[,id...]]" end ids = params["nodes"].split(",").collect(&:to_i) if ids.empty? - raise OSM::APIBadUserInput.new("No nodes were given to search for") + raise OSM::APIBadUserInput, "No nodes were given to search for" end doc = OSM::API.new.get_xml_doc @@ -79,6 +79,6 @@ class NodeController < ApplicationController doc.root << node.to_xml_node end - render :text => doc.to_s, :content_type => "text/xml" + render :xml => doc.to_s end end