X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/9a9b045372a6f48420a9a6dacfde52c34ab7abce..4a9aa0a12e3a9f4dbe19f17b3117c727b62a43b9:/test/helpers/browse_helper_test.rb
diff --git a/test/helpers/browse_helper_test.rb b/test/helpers/browse_helper_test.rb
index 7878d10e0..798c69b43 100644
--- a/test/helpers/browse_helper_test.rb
+++ b/test/helpers/browse_helper_test.rb
@@ -23,6 +23,7 @@ class BrowseHelperTest < ActionView::TestCase
assert_dom_equal "18", printable_name(nodes(:node_with_name_redacted_version))
assert_dom_equal "Test Node (18, v2)", printable_name(nodes(:node_with_name_current_version), true)
assert_dom_equal "18, v1", printable_name(nodes(:node_with_name_redacted_version), true)
+ assert_dom_equal "3.1415926 (19)", printable_name(current_nodes(:node_with_ref_without_name))
I18n.locale = "pt"
@@ -32,6 +33,7 @@ class BrowseHelperTest < ActionView::TestCase
assert_dom_equal "18", printable_name(nodes(:node_with_name_redacted_version))
assert_dom_equal "Nó teste (18, v2)", printable_name(nodes(:node_with_name_current_version), true)
assert_dom_equal "18, v1", printable_name(nodes(:node_with_name_redacted_version), true)
+ assert_dom_equal "3.1415926 (19)", printable_name(current_nodes(:node_with_ref_without_name))
I18n.locale = "pt-BR"
@@ -41,6 +43,7 @@ class BrowseHelperTest < ActionView::TestCase
assert_dom_equal "18", printable_name(nodes(:node_with_name_redacted_version))
assert_dom_equal "Nó teste (18, v2)", printable_name(nodes(:node_with_name_current_version), true)
assert_dom_equal "18, v1", printable_name(nodes(:node_with_name_redacted_version), true)
+ assert_dom_equal "3.1415926 (19)", printable_name(current_nodes(:node_with_ref_without_name))
I18n.locale = "de"
@@ -50,6 +53,7 @@ class BrowseHelperTest < ActionView::TestCase
assert_dom_equal "18", printable_name(nodes(:node_with_name_redacted_version))
assert_dom_equal "Test Node (18, v2)", printable_name(nodes(:node_with_name_current_version), true)
assert_dom_equal "18, v1", printable_name(nodes(:node_with_name_redacted_version), true)
+ assert_dom_equal "3.1415926 (19)", printable_name(current_nodes(:node_with_ref_without_name))
end
def test_link_class
@@ -96,6 +100,9 @@ class BrowseHelperTest < ActionView::TestCase
html = format_value("wikidata", "Q42")
assert_dom_equal "Q42", html
+
+ html = format_value("operator:wikidata", "Q12;Q98")
+ assert_dom_equal "Q12;Q98", html
end
def test_icon_tags
@@ -142,31 +149,77 @@ class BrowseHelperTest < ActionView::TestCase
assert_equal "http://wiki.openstreetmap.org/wiki/Tag:highway=primary?uselang=tr", link
end
- def test_wikidata_link
- link = wikidata_link("foo", "Test")
- assert_nil link
+ def test_wikidata_links
+ ### Non-prefixed wikidata-tag (only one value allowed)
- link = wikidata_link("wikidata", "http://www.wikidata.org/wiki/Q1")
- assert_nil link
+ # Non-wikidata tag
+ links = wikidata_links("foo", "Test")
+ assert_nil links
- link = wikidata_link("wikidata", "en:Q1")
- assert_nil link
+ # No URLs allowed
+ links = wikidata_links("wikidata", "http://www.wikidata.org/wiki/Q1")
+ assert_nil links
- link = wikidata_link("wikidata", "1")
- assert_nil link
+ # No language-prefixes (as wikidata is multilanguage)
+ links = wikidata_links("wikidata", "en:Q1")
+ assert_nil links
- link = wikidata_link("wikidata", "Q0123")
- assert_nil link
+ # Needs a leading Q
+ links = wikidata_links("wikidata", "1")
+ assert_nil links
+
+ # No leading zeros allowed
+ links = wikidata_links("wikidata", "Q0123")
+ assert_nil links
- link = wikidata_link("wikidata", "Q42")
- assert_equal "//www.wikidata.org/wiki/Q42?uselang=en", link[:url]
- assert_equal "Q42", link[:title]
+ # A valid value
+ links = wikidata_links("wikidata", "Q42")
+ assert_equal 1, links.length
+ assert_equal "//www.wikidata.org/wiki/Q42?uselang=en", links[0][:url]
+ assert_equal "Q42", links[0][:title]
+ # the language of the wikidata-page should match the current locale
I18n.locale = "zh-CN"
+ links = wikidata_links("wikidata", "Q1234")
+ assert_equal 1, links.length
+ assert_equal "//www.wikidata.org/wiki/Q1234?uselang=zh-CN", links[0][:url]
+ assert_equal "Q1234", links[0][:title]
+ I18n.locale = "en"
+
+ ### Prefixed wikidata-tags
+
+ # Not anything is accepted as prefix (only limited set)
+ links = wikidata_links("anything:wikidata", "Q13")
+ assert_nil links
+
+ # This for example is an allowed key
+ links = wikidata_links("operator:wikidata", "Q24")
+ assert_equal "//www.wikidata.org/wiki/Q24?uselang=en", links[0][:url]
+ assert_equal "Q24", links[0][:title]
+
+ # Another allowed key, this time with multiple values and I18n
+ I18n.locale = "dsb"
+ links = wikidata_links("brand:wikidata", "Q936;Q2013;Q1568346")
+ assert_equal 3, links.length
+ assert_equal "//www.wikidata.org/wiki/Q936?uselang=dsb", links[0][:url]
+ assert_equal "Q936", links[0][:title]
+ assert_equal "//www.wikidata.org/wiki/Q2013?uselang=dsb", links[1][:url]
+ assert_equal "Q2013", links[1][:title]
+ assert_equal "//www.wikidata.org/wiki/Q1568346?uselang=dsb", links[2][:url]
+ assert_equal "Q1568346", links[2][:title]
+ I18n.locale = "en"
- link = wikidata_link("wikidata", "Q1234")
- assert_equal "//www.wikidata.org/wiki/Q1234?uselang=zh-CN", link[:url]
- assert_equal "Q1234", link[:title]
+ # and now with whitespaces...
+ links = wikidata_links("subject:wikidata", "Q6542248 ;\tQ180\n ;\rQ364\t\n\r ;\nQ4006")
+ assert_equal 4, links.length
+ assert_equal "//www.wikidata.org/wiki/Q6542248?uselang=en", links[0][:url]
+ assert_equal "Q6542248 ", links[0][:title]
+ assert_equal "//www.wikidata.org/wiki/Q180?uselang=en", links[1][:url]
+ assert_equal "\tQ180\n ", links[1][:title]
+ assert_equal "//www.wikidata.org/wiki/Q364?uselang=en", links[2][:url]
+ assert_equal "\rQ364\t\n\r ", links[2][:title]
+ assert_equal "//www.wikidata.org/wiki/Q4006?uselang=en", links[3][:url]
+ assert_equal "\nQ4006", links[3][:title]
end
def test_wikipedia_link