X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/9a9b045372a6f48420a9a6dacfde52c34ab7abce..7f611b295f39b8c42219a5ce6c84582db74ce8f7:/test/controllers/redactions_controller_test.rb

diff --git a/test/controllers/redactions_controller_test.rb b/test/controllers/redactions_controller_test.rb
index 1df2a6dff..b3bc4cf16 100644
--- a/test/controllers/redactions_controller_test.rb
+++ b/test/controllers/redactions_controller_test.rb
@@ -1,9 +1,6 @@
 require "test_helper"
-require "redactions_controller"
-
-class RedactionsControllerTest < ActionController::TestCase
-  api_fixtures
 
+class RedactionsControllerTest < ActionDispatch::IntegrationTest
   ##
   # test all routes which lead to this controller
   def test_routes
@@ -38,7 +35,9 @@ class RedactionsControllerTest < ActionController::TestCase
   end
 
   def test_index
-    get :index
+    create(:redaction)
+
+    get redactions_path
     assert_response :success
     assert_template :index
     assert_select "ul#redaction_list", 1 do
@@ -46,131 +45,132 @@ class RedactionsControllerTest < ActionController::TestCase
     end
   end
 
+  def test_show
+    redaction = create(:redaction, :title => "tested-redaction")
+
+    get redaction_path(redaction)
+    assert_response :success
+    assert_dom "h1", :text => /tested-redaction/
+    assert_dom "a[href='#{user_path redaction.user}']", :text => redaction.user.display_name
+  end
+
   def test_new
-    get :new
-    assert_response :redirect
+    get new_redaction_path
     assert_redirected_to login_path(:referer => new_redaction_path)
   end
 
   def test_new_moderator
-    session[:user] = users(:moderator_user).id
+    session_for(create(:moderator_user))
 
-    get :new
+    get new_redaction_path
     assert_response :success
     assert_template :new
   end
 
   def test_new_non_moderator
-    session[:user] = users(:public_user).id
+    session_for(create(:user))
 
-    get :new
-    assert_response :redirect
-    assert_redirected_to redactions_path
+    get new_redaction_path
+    assert_redirected_to :controller => "errors", :action => "forbidden"
   end
 
   def test_create_moderator
-    session[:user] = users(:moderator_user).id
+    session_for(create(:moderator_user))
 
-    post :create, :redaction => { :title => "Foo", :description => "Description here." }
-    assert_response :redirect
-    assert_redirected_to(redaction_path(Redaction.find_by_title("Foo")))
+    post redactions_path(:redaction => { :title => "Foo", :description => "Description here." })
+    assert_redirected_to(redaction_path(Redaction.find_by(:title => "Foo")))
   end
 
   def test_create_moderator_invalid
-    session[:user] = users(:moderator_user).id
+    session_for(create(:moderator_user))
 
-    post :create, :redaction => { :title => "Foo", :description => "" }
+    post redactions_path(:redaction => { :title => "Foo", :description => "" })
     assert_response :success
     assert_template :new
   end
 
   def test_create_non_moderator
-    session[:user] = users(:public_user).id
+    session_for(create(:user))
 
-    post :create, :redaction => { :title => "Foo", :description => "Description here." }
-    assert_response :forbidden
+    post redactions_path(:redaction => { :title => "Foo", :description => "Description here." })
+    assert_redirected_to :controller => "errors", :action => "forbidden"
   end
 
   def test_destroy_moderator_empty
-    session[:user] = users(:moderator_user).id
+    session_for(create(:moderator_user))
 
-    # remove all elements from the redaction
-    redaction = redactions(:example)
-    redaction.old_nodes.each     { |n| n.update!(:redaction => nil) }
-    redaction.old_ways.each      { |w| w.update!(:redaction => nil) }
-    redaction.old_relations.each { |r| r.update!(:redaction => nil) }
+    # create an empty redaction
+    redaction = create(:redaction)
 
-    delete :destroy, :id => redaction.id
-    assert_response :redirect
+    delete redaction_path(redaction)
     assert_redirected_to(redactions_path)
   end
 
   def test_destroy_moderator_non_empty
-    session[:user] = users(:moderator_user).id
+    session_for(create(:moderator_user))
 
-    # leave elements in the redaction
-    redaction = redactions(:example)
+    # create elements in the redaction
+    redaction = create(:redaction)
+    create(:old_node, :redaction => redaction)
 
-    delete :destroy, :id => redaction.id
-    assert_response :redirect
+    delete redaction_path(redaction)
     assert_redirected_to(redaction_path(redaction))
-    assert_match /^Redaction is not empty/, flash[:error]
+    assert_match(/^Redaction is not empty/, flash[:error])
   end
 
   def test_delete_non_moderator
-    session[:user] = users(:public_user).id
+    session_for(create(:user))
 
-    delete :destroy, :id => redactions(:example).id
-    assert_response :forbidden
+    delete redaction_path(create(:redaction))
+    assert_redirected_to :controller => "errors", :action => "forbidden"
   end
 
   def test_edit
-    get :edit, :id => redactions(:example).id
-    assert_response :redirect
-    assert_redirected_to login_path(:referer => edit_redaction_path(redactions(:example)))
+    redaction = create(:redaction)
+
+    get edit_redaction_path(redaction)
+    assert_redirected_to login_path(:referer => edit_redaction_path(redaction))
   end
 
   def test_edit_moderator
-    session[:user] = users(:moderator_user).id
+    session_for(create(:moderator_user))
 
-    get :edit, :id => redactions(:example).id
+    get edit_redaction_path(create(:redaction))
     assert_response :success
   end
 
   def test_edit_non_moderator
-    session[:user] = users(:public_user).id
+    session_for(create(:user))
 
-    get :edit, :id => redactions(:example).id
-    assert_response :redirect
-    assert_redirected_to(redactions_path)
+    get edit_redaction_path(create(:redaction))
+    assert_redirected_to :controller => "errors", :action => "forbidden"
   end
 
   def test_update_moderator
-    session[:user] = users(:moderator_user).id
+    session_for(create(:moderator_user))
 
-    redaction = redactions(:example)
+    redaction = create(:redaction)
 
-    put :update, :id => redaction.id, :redaction => { :title => "Foo", :description => "Description here." }
-    assert_response :redirect
+    put redaction_path(redaction, :redaction => { :title => "Foo", :description => "Description here." })
     assert_redirected_to(redaction_path(redaction))
   end
 
   def test_update_moderator_invalid
-    session[:user] = users(:moderator_user).id
+    session_for(create(:moderator_user))
 
-    redaction = redactions(:example)
+    redaction = create(:redaction)
 
-    put :update, :id => redaction.id, :redaction => { :title => "Foo", :description => "" }
+    put redaction_path(redaction, :redaction => { :title => "Foo", :description => "" })
     assert_response :success
     assert_template :edit
   end
 
   def test_updated_non_moderator
-    session[:user] = users(:public_user).id
+    session_for(create(:user))
 
-    redaction = redactions(:example)
+    redaction = create(:redaction)
 
-    put :update, :id => redaction.id, :redaction => { :title => "Foo", :description => "Description here." }
-    assert_response :forbidden
+    put redaction_path(redaction, :redaction => { :title => "Foo", :description => "Description here." })
+    assert_redirected_to :controller => "errors", :action => "forbidden"
   end
 end