X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/9caa2046cad2f7ee4294cfe1a932a6ad56e5c32d..ea9080ef80bc937af479cb2ab3a258419a832040:/app/models/trace.rb?ds=sidebyside diff --git a/app/models/trace.rb b/app/models/trace.rb index 39ecb416a..5e609786d 100644 --- a/app/models/trace.rb +++ b/app/models/trace.rb @@ -1,5 +1,14 @@ class Trace < ActiveRecord::Base - set_table_name 'gpx_files' + self.table_name = "gpx_files" + + belongs_to :user, :counter_cache => true + has_many :tags, :class_name => 'Tracetag', :foreign_key => 'gpx_id', :dependent => :delete_all + has_many :points, :class_name => 'Tracepoint', :foreign_key => 'gpx_id', :dependent => :delete_all + + scope :visible, where(:visible => true) + scope :visible_to, lambda { |u| visible.where("visibility IN ('public', 'identifiable') OR user_id = ?", u) } + scope :public, where(:visibility => ["public", "identifiable"]) + scope :tagged, lambda { |t| joins(:tags).where(:gpx_file_tags => { :tag => t }) } validates_presence_of :user_id, :name, :timestamp validates_presence_of :description, :on => :create @@ -9,10 +18,6 @@ class Trace < ActiveRecord::Base validates_inclusion_of :inserted, :in => [ true, false ] validates_inclusion_of :visibility, :in => ["private", "public", "trackable", "identifiable"] - belongs_to :user - has_many :tags, :class_name => 'Tracetag', :foreign_key => 'gpx_id', :dependent => :delete_all - has_many :points, :class_name => 'Tracepoint', :foreign_key => 'gpx_id', :dependent => :delete_all - def destroy super FileUtils.rm_f(trace_name) @@ -169,6 +174,52 @@ class Trace < ActiveRecord::Base return el1 end + # Read in xml as text and return it's Node object representation + def self.from_xml(xml, create=false) + begin + p = XML::Parser.string(xml) + doc = p.parse + + doc.find('//osm/gpx_file').each do |pt| + return Trace.from_xml_node(pt, create) + end + + raise OSM::APIBadXMLError.new("trace", xml, "XML doesn't contain an osm/gpx_file element.") + rescue LibXML::XML::Error, ArgumentError => ex + raise OSM::APIBadXMLError.new("trace", xml, ex.message) + end + end + + def self.from_xml_node(pt, create=false) + trace = Trace.new + + raise OSM::APIBadXMLError.new("trace", pt, "visibility missing") if pt['visibility'].nil? + trace.visibility = pt['visibility'] + + unless create + raise OSM::APIBadXMLError.new("trace", pt, "ID is required when updating.") if pt['id'].nil? + trace.id = pt['id'].to_i + # .to_i will return 0 if there is no number that can be parsed. + # We want to make sure that there is no id with zero anyway + raise OSM::APIBadUserInput.new("ID of trace cannot be zero when updating.") if trace.id == 0 + end + + # We don't care about the time, as it is explicitly set on create/update/delete + # We don't care about the visibility as it is implicit based on the action + # and set manually before the actual delete + trace.visible = true + + description = pt.find('description').first + raise OSM::APIBadXMLError.new("trace", pt, "description missing") if description.nil? + trace.description = description.content + + pt.find('tag').each do |tag| + trace.tags.build(:tag => tag.content) + end + + return trace + end + def xml_file # TODO *nix specific, could do to work on windows... would be functionally inferior though - check for '.gz' filetype = `/usr/bin/file -bz #{trace_name}`.chomp @@ -216,8 +267,8 @@ class Trace < ActiveRecord::Base # If there are any existing points for this trace then delete # them - we check for existing points first to avoid locking # the table in the common case where there aren't any. - if Tracepoint.find(:first, :conditions => ['gpx_id = ?', self.id]) - Tracepoint.delete_all(['gpx_id = ?', self.id]) + if Tracepoint.where(:gpx_id => self.id).exists? + Tracepoint.delete_all(:gpx_id => self.id) end gpx.points do |point|