X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/a25b7953b3889ce6847a13c579fa9fd32219b5e3..b44399fb7c1747a811ea613e7782f77849a6d2e1:/CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e298c944f..46fe63bb2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -20,7 +20,7 @@ development to check that your code matches our guidelines: ``` bundle exec rubocop bundle exec rails eslint -bundle exec erblint . +bundle exec erb_lint . ``` You can also install hooks to have git run checks automatically when @@ -87,7 +87,7 @@ and why it should be the way it is. ## i18n -If you make a change that involve the locale files (in `config/locales`) then please +If you make a change that involves the locale files (in `config/locales`) then please only submit changes to the `en.yml` file. The other files are updated via [Translatewiki](https://translatewiki.net/wiki/Translating:OpenStreetMap) and should not be included in your pull request. @@ -143,7 +143,7 @@ with making the reviews as straightforward as possible: large to review in one sitting, or if changes are requested, then the maintainer needs to repeatedly re-read code that has already been considered. * The commit history is important. This is a large codebase, developed over many - years by many developers. We frequently need to read the commit history (e.g. + years by many developers. We frequently need to read the commit history (for example using `git blame`) to figure out what is going on. So small, understandable, and relevant commits are important for other developers looking back at your work in future.