X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/a544895e6c82f29ff20dbcb588fbb9359120d8d1..8ba1ea0f5d069fe8f2c96fff0804de4fd794bd1e:/.rubocop_todo.yml?ds=sidebyside diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 5303fb051..fdc7c35a5 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2022-10-25 17:25:58 UTC using RuboCop version 1.37.1. +# on 2023-04-11 16:47:05 UTC using RuboCop version 1.50.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -14,14 +14,20 @@ require: - rubocop-rails - rubocop-rake -# Offense count: 555 +# Offense count: 11 +# Configuration parameters: Include, MaxAmount +FactoryBot/ExcessiveCreateList: + MaxAmount: 200 + +# Offense count: 557 # This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, IgnoredPatterns. +# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns. # URISchemes: http, https Layout/LineLength: Max: 248 # Offense count: 29 +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: Exclude: @@ -41,34 +47,34 @@ Lint/AssignmentInCondition: - 'lib/osm.rb' - 'script/deliver-message' -# Offense count: 676 -# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods, CountRepeatedAttributes. +# Offense count: 680 +# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes. Metrics/AbcSize: Max: 189 -# Offense count: 72 -# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods. +# Offense count: 73 +# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns. # AllowedMethods: refine Metrics/BlockLength: Max: 71 -# Offense count: 15 +# Offense count: 20 # Configuration parameters: CountBlocks. Metrics/BlockNesting: Max: 5 -# Offense count: 25 +# Offense count: 26 # Configuration parameters: CountComments, CountAsOne. Metrics/ClassLength: - Max: 316 + Max: 314 -# Offense count: 58 -# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods. +# Offense count: 59 +# Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/CyclomaticComplexity: - Max: 25 + Max: 29 -# Offense count: 751 -# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods. +# Offense count: 753 +# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns. Metrics/MethodLength: Max: 179 @@ -77,24 +83,25 @@ Metrics/MethodLength: Metrics/ParameterLists: Max: 6 -# Offense count: 57 -# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods. +# Offense count: 56 +# Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/PerceivedComplexity: - Max: 26 + Max: 30 -# Offense count: 559 +# Offense count: 2394 +# This cop supports safe autocorrection (--autocorrect). +Minitest/EmptyLineBeforeAssertionMethods: + Enabled: false + +# Offense count: 565 Minitest/MultipleAssertions: - Max: 52 + Max: 54 # Offense count: 1 -# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros. -# NamePrefix: is_, has_, have_ -# ForbiddenPrefixes: is_, has_, have_ -# AllowedMethods: is_a? -# MethodDefinitionMacros: define_method, define_singleton_method -Naming/PredicateName: +# This cop supports unsafe autocorrection (--autocorrect-all). +Rails/ActionControllerFlashBeforeRender: Exclude: - - 'app/models/user.rb' + - 'app/controllers/traces_controller.rb' # Offense count: 5 # Configuration parameters: Database, Include. @@ -153,15 +160,24 @@ Rails/NotNullColumn: - 'db/migrate/025_add_end_time_to_changesets.rb' - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' -# Offense count: 9 +# Offense count: 7 Rails/OutputSafety: Exclude: - - 'app/controllers/sessions_controller.rb' - - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - 'lib/rich_text.rb' - 'test/helpers/application_helper_test.rb' +# Offense count: 16 +# Configuration parameters: Include. +# Include: db/**/*.rb +Rails/ThreeStateBooleanColumn: + Exclude: + - 'db/migrate/001_create_osm_db.rb' + - 'db/migrate/006_tile_nodes.rb' + - 'db/migrate/007_add_relations.rb' + - 'db/migrate/054_refactor_map_bug_tables.rb' + - 'db/migrate/20140507110937_create_changeset_comments.rb' + # Offense count: 6 # This cop supports safe autocorrection (--autocorrect). Rake/Desc: @@ -171,7 +187,7 @@ Rake/Desc: - 'lib/tasks/subscribe_diary_authors.rake' - 'lib/tasks/subscribe_old_changesets.rake' -# Offense count: 625 +# Offense count: 632 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: always, always_true, never