X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/a66f0f32e977cb2d6ae7231e7014861c119cc657..fa0a933c24f9866db17694dbef667e3c4d7ed08f:/test/models/trace_test.rb diff --git a/test/models/trace_test.rb b/test/models/trace_test.rb index c9530b067..8bae041fc 100644 --- a/test/models/trace_test.rb +++ b/test/models/trace_test.rb @@ -3,17 +3,18 @@ require "digest" require "minitest/mock" class TraceTest < ActiveSupport::TestCase - fixtures :users - def setup @gpx_trace_dir = Object.send("remove_const", "GPX_TRACE_DIR") - Object.const_set("GPX_TRACE_DIR", File.dirname(__FILE__) + "/../traces") + Object.const_set("GPX_TRACE_DIR", Rails.root.join("test", "gpx", "traces")) @gpx_image_dir = Object.send("remove_const", "GPX_IMAGE_DIR") - Object.const_set("GPX_IMAGE_DIR", File.dirname(__FILE__) + "/../traces") + Object.const_set("GPX_IMAGE_DIR", Rails.root.join("test", "gpx", "images")) end def teardown + File.unlink(*Dir.glob(File.join(GPX_TRACE_DIR, "*.gpx"))) + File.unlink(*Dir.glob(File.join(GPX_IMAGE_DIR, "*.gif"))) + Object.send("remove_const", "GPX_TRACE_DIR") Object.const_set("GPX_TRACE_DIR", @gpx_trace_dir) @@ -28,21 +29,25 @@ class TraceTest < ActiveSupport::TestCase end def test_visible_to - public_trace_file = create(:trace, :visibility => "public", :user => users(:normal_user)) - anon_trace_file = create(:trace, :visibility => "private", :user => users(:public_user)) - identifiable_trace_file = create(:trace, :visibility => "identifiable", :user => users(:normal_user)) - pending_trace_file = create(:trace, :visibility => "public", :user => users(:public_user), :inserted => false) - trackable_trace_file = create(:trace, :visibility => "trackable", :user => users(:public_user)) - _other_trace_file = create(:trace, :visibility => "private", :user => users(:second_public_user)) - - check_query(Trace.visible_to(users(:normal_user).id), [ + first_user = create(:user) + second_user = create(:user) + third_user = create(:user) + fourth_user = create(:user) + public_trace_file = create(:trace, :visibility => "public", :user => first_user) + anon_trace_file = create(:trace, :visibility => "private", :user => second_user) + identifiable_trace_file = create(:trace, :visibility => "identifiable", :user => first_user) + pending_trace_file = create(:trace, :visibility => "public", :user => second_user, :inserted => false) + trackable_trace_file = create(:trace, :visibility => "trackable", :user => second_user) + _other_trace_file = create(:trace, :visibility => "private", :user => third_user) + + check_query(Trace.visible_to(first_user), [ public_trace_file, identifiable_trace_file, pending_trace_file ]) - check_query(Trace.visible_to(users(:public_user)), [ + check_query(Trace.visible_to(second_user), [ public_trace_file, anon_trace_file, trackable_trace_file, identifiable_trace_file, pending_trace_file ]) - check_query(Trace.visible_to(users(:inactive_user)), [ + check_query(Trace.visible_to(fourth_user), [ public_trace_file, identifiable_trace_file, pending_trace_file ]) end @@ -166,10 +171,7 @@ class TraceTest < ActiveSupport::TestCase end def test_large_picture - trace = create(:trace) - picture = trace.stub :large_picture_name, "#{GPX_IMAGE_DIR}/a.gif" do - trace.large_picture - end + picture = File.read(Rails.root.join("test", "gpx", "fixtures", "a.gif"), :mode => "rb") trace = Trace.create trace.large_picture = picture @@ -180,10 +182,7 @@ class TraceTest < ActiveSupport::TestCase end def test_icon_picture - trace = create(:trace) - picture = trace.stub :icon_picture_name, "#{GPX_IMAGE_DIR}/a_icon.gif" do - trace.icon_picture - end + picture = File.read(Rails.root.join("test", "gpx", "fixtures", "a_icon.gif"), :mode => "rb") trace = Trace.create trace.icon_picture = picture @@ -193,6 +192,66 @@ class TraceTest < ActiveSupport::TestCase trace.destroy end + # When testing the trace.import method, care needs to be taken regarding the icon + # fixture files, since the fixtures could be overwritten by newly generated files. + # We use FakeFS to temporarily protect the real fixture files from being overwritten. + + def test_import_removes_previous_tracepoints + FakeFS do + FakeFS::FileSystem.clone(Rails.root.join("test", "gpx")) + trace = create(:trace, :fixture => "a") + # Tracepoints don't have a primary key, so we use a specific latitude to + # check for successful deletion + create(:tracepoint, :latitude => 54321, :trace => trace) + assert_equal 1, Tracepoint.where(:latitude => 54321).count + + trace.import + + assert_equal 0, Tracepoint.where(:latitude => 54321).count + end + end + + def test_import_creates_tracepoints + FakeFS do + FakeFS::FileSystem.clone(Rails.root.join("test", "gpx")) + trace = create(:trace, :fixture => "a") + assert_equal 0, Tracepoint.where(:gpx_id => trace.id).count + + trace.import + + trace.reload + assert_equal 1, Tracepoint.where(:gpx_id => trace.id).count + end + end + + def test_import_creates_icon + FakeFS do + FakeFS::FileSystem.clone(Rails.root.join("test", "gpx")) + trace = create(:trace, :fixture => "a") + icon_path = File.join(GPX_IMAGE_DIR, "#{trace.id}_icon.gif") + FileUtils.rm(icon_path) + assert_equal false, File.exist?(icon_path) + + trace.import + + assert_equal true, File.exist?(icon_path) + end + end + + def test_import_creates_large_picture + FakeFS do + FakeFS::FileSystem.clone(Rails.root.join("test", "gpx")) + trace = create(:trace, :fixture => "a") + large_picture_path = File.join(GPX_IMAGE_DIR, "#{trace.id}.gif") + FileUtils.rm(large_picture_path) + assert_equal false, File.exist?(large_picture_path) + + trace.import + + assert_equal true, File.exist?(large_picture_path) + end + end + private def check_query(query, traces) @@ -201,24 +260,15 @@ class TraceTest < ActiveSupport::TestCase end def check_mime_type(id, mime_type) - trace = create(:trace) - trace.stub :trace_name, "#{GPX_TRACE_DIR}/#{id}.gpx" do - assert_equal mime_type, trace.mime_type - end + assert_equal mime_type, create(:trace, :fixture => id).mime_type end def check_extension_name(id, extension_name) - trace = create(:trace) - trace.stub :trace_name, "#{GPX_TRACE_DIR}/#{id}.gpx" do - assert_equal extension_name, trace.extension_name - end + assert_equal extension_name, create(:trace, :fixture => id).extension_name end def check_xml_file(id, md5sum) - trace = create(:trace) - trace.stub :trace_name, "#{GPX_TRACE_DIR}/#{id}.gpx" do - assert_equal md5sum, md5sum(trace.xml_file) - end + assert_equal md5sum, md5sum(create(:trace, :fixture => id).xml_file) end def trace_valid(attrs, result = true)