X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/b0ffe17cec6fdd9bb27c1e8a3deb37f46d2d37bf..c62286622426bd6d32e22438354ed2323c900ea2:/CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a3252807a..46fe63bb2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,6 +1,15 @@ +# Contributing + * https://www.ruby-lang.org/ - The homepage of Ruby which has more links and some great tutorials. * https://rubyonrails.org/ - The homepage of Rails, also has links and tutorials. +## Assigning Issues + +We don't assign issues to individual contributors. You are welcome to work on any +issue, and there's no need to ask first. + +For more details see [our FAQ](FAQ.md)] + ## Coding style We use [Rubocop](https://github.com/rubocop-hq/rubocop) (for ruby files) @@ -11,7 +20,7 @@ development to check that your code matches our guidelines: ``` bundle exec rubocop bundle exec rails eslint -bundle exec erblint . +bundle exec erb_lint . ``` You can also install hooks to have git run checks automatically when @@ -43,6 +52,12 @@ You can run the existing test suite with: bundle exec rails test:all ``` +You can run javascript tests with: + +``` +bundle exec teaspoon +``` + You can view test coverage statistics by browsing the `coverage` directory. The tests are automatically run on Pull Requests and other commits via github @@ -72,7 +87,7 @@ and why it should be the way it is. ## i18n -If you make a change that involve the locale files (in `config/locales`) then please +If you make a change that involves the locale files (in `config/locales`) then please only submit changes to the `en.yml` file. The other files are updated via [Translatewiki](https://translatewiki.net/wiki/Translating:OpenStreetMap) and should not be included in your pull request. @@ -128,7 +143,7 @@ with making the reviews as straightforward as possible: large to review in one sitting, or if changes are requested, then the maintainer needs to repeatedly re-read code that has already been considered. * The commit history is important. This is a large codebase, developed over many - years by many developers. We frequently need to read the commit history (e.g. + years by many developers. We frequently need to read the commit history (for example using `git blame`) to figure out what is going on. So small, understandable, and relevant commits are important for other developers looking back at your work in future.