X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/b4106383d99ccbf152d79b0f2c9deca95df9fb61..be0d3b49fd7cbb68f09c33d68edb20fe51b0ae2a:/.rubocop_todo.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index a64be7273..7d2c583eb 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,23 +1,11 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2018-06-19 09:02:55 +0100 using RuboCop version 0.57.2. +# on 2018-09-19 14:24:02 +0100 using RuboCop version 0.58.2. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 34 -Lint/AmbiguousOperator: - Exclude: - - 'test/controllers/amf_controller_test.rb' - - 'test/controllers/changeset_controller_test.rb' - - 'test/lib/bounding_box_test.rb' - - 'test/lib/country_test.rb' - -# Offense count: 96 -Lint/AmbiguousRegexpLiteral: - Enabled: false - # Offense count: 32 # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: @@ -26,12 +14,12 @@ Lint/AssignmentInCondition: - 'app/controllers/geocoder_controller.rb' - 'app/controllers/notes_controller.rb' - 'app/controllers/traces_controller.rb' - - 'app/controllers/user_controller.rb' + - 'app/controllers/users_controller.rb' - 'app/controllers/user_preferences_controller.rb' - 'app/helpers/application_helper.rb' - 'app/helpers/browse_helper.rb' - 'app/models/client_application.rb' - - 'app/models/notifier.rb' + - 'app/mailers/notifier.rb' - 'lib/nominatim.rb' - 'lib/osm.rb' - 'script/deliver-message' @@ -40,21 +28,17 @@ Lint/AssignmentInCondition: Lint/HandleExceptions: Exclude: - 'app/controllers/amf_controller.rb' - - 'app/controllers/user_controller.rb' - -# Offense count: 2 -Lint/ShadowingOuterLocalVariable: - Exclude: - - 'app/views/changeset/list.atom.builder' + - 'app/controllers/users_controller.rb' -# Offense count: 690 +# Offense count: 692 Metrics/AbcSize: - Max: 280 + Max: 283 -# Offense count: 41 +# Offense count: 40 # Configuration parameters: CountComments, ExcludedMethods. +# ExcludedMethods: refine Metrics/BlockLength: - Max: 258 + Max: 262 # Offense count: 11 # Configuration parameters: CountBlocks. @@ -64,13 +48,13 @@ Metrics/BlockNesting: # Offense count: 63 # Configuration parameters: CountComments. Metrics/ClassLength: - Max: 1795 + Max: 1801 # Offense count: 72 Metrics/CyclomaticComplexity: Max: 20 -# Offense count: 688 +# Offense count: 691 # Configuration parameters: CountComments. Metrics/MethodLength: Max: 179 @@ -85,7 +69,7 @@ Metrics/ModuleLength: Metrics/ParameterLists: Max: 9 -# Offense count: 71 +# Offense count: 72 Metrics/PerceivedComplexity: Max: 23 @@ -155,7 +139,7 @@ Rails/NotNullColumn: # Offense count: 20 Rails/OutputSafety: Exclude: - - 'app/controllers/user_controller.rb' + - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - 'app/helpers/changeset_helper.rb' - 'app/helpers/geocoder_helper.rb' @@ -178,10 +162,17 @@ Style/AsciiComments: Exclude: - 'test/models/message_test.rb' -# Offense count: 229 +# Offense count: 230 Style/Documentation: Enabled: false +# Offense count: 462 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: when_needed, always, never +Style/FrozenStringLiteralComment: + Enabled: false + # Offense count: 2 # Cop supports --auto-correct. Style/IfUnlessModifier: @@ -194,7 +185,7 @@ Style/IfUnlessModifier: Style/NumericLiterals: MinDigits: 11 -# Offense count: 3064 +# Offense count: 3080 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. # URISchemes: http, https Metrics/LineLength: