X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/b52327bf890f8f83f238eae21b3f48abecdebb8d..6b55cce25c2ed58c6513ae7f3f5dd24518cb489e:/app/controllers/geocoder_controller.rb?ds=sidebyside diff --git a/app/controllers/geocoder_controller.rb b/app/controllers/geocoder_controller.rb index 622e700af..43f276efa 100644 --- a/app/controllers/geocoder_controller.rb +++ b/app/controllers/geocoder_controller.rb @@ -1,327 +1,247 @@ class GeocoderController < ApplicationController - require 'uri' - require 'net/http' - require 'rexml/document' + require "cgi" + require "uri" + require "rexml/document" - before_filter :set_locale + before_action :authorize_web + before_action :set_locale + before_action :require_oauth, :only => [:search] + authorize_resource :class => false def search - query = params[:query] - results = Array.new - - query.sub(/^\s+/, "") - query.sub(/\s+$/, "") - - if query.match(/^[+-]?\d+(\.\d*)?\s*[\s,]\s*[+-]?\d+(\.\d*)?$/) - results.push search_latlon(query) - elsif query.match(/^\d{5}(-\d{4})?$/) - results.push search_us_postcode(query) - elsif query.match(/^(GIR 0AA|[A-PR-UWYZ]([0-9]{1,2}|([A-HK-Y][0-9]|[A-HK-Y][0-9]([0-9]|[ABEHMNPRV-Y]))|[0-9][A-HJKS-UW])\s*[0-9][ABD-HJLNP-UW-Z]{2})$/i) - results.push search_uk_postcode(query) - results.push search_osm_namefinder(query) - elsif query.match(/^[A-Z]\d[A-Z]\s*\d[A-Z]\d$/i) - results.push search_ca_postcode(query) - else - results.push search_osm_namefinder(query) - results.push search_geonames(query) + @params = normalize_params + @sources = [] + + if @params[:lat] && @params[:lon] + @sources.push(:name => "latlon", :url => root_path) + @sources.push(:name => "osm_nominatim_reverse", :url => nominatim_reverse_url(:format => "html")) + elsif @params[:query] + @sources.push(:name => "osm_nominatim", :url => nominatim_url(:format => "html")) end - results_count = count_results(results) - - render :update do |page| - page.replace_html :sidebar_content, :partial => 'results', :object => results - - if results_count == 1 - position = results.collect { |s| s[:results] }.compact.flatten[0] - page.call "setPosition", position[:lat].to_f, position[:lon].to_f, position[:zoom].to_i - else - page.call "openSidebar" - end + if @sources.empty? + head :bad_request + else + render :layout => map_layout end end - - def description - results = Array.new - lat = params[:lat] - lon = params[:lon] + def search_latlon + lat = params[:lat].to_f + lon = params[:lon].to_f - results.push description_osm_namefinder("cities", lat, lon, 2) - results.push description_osm_namefinder("towns", lat, lon, 4) - results.push description_osm_namefinder("places", lat, lon, 10) - results.push description_geonames(lat, lon) + if params[:latlon_digits] + # We've got two nondescript numbers for a query, which can mean both "lat, lon" or "lon, lat". + @results = [] - render :update do |page| - page.replace_html :sidebar_content, :partial => 'results', :object => results - page.call "openSidebar" - end - end - -private - - def search_latlon(query) - results = Array.new + if lat >= -90 && lat <= 90 && lon >= -180 && lon <= 180 + @results.push(:lat => params[:lat], :lon => params[:lon], + :zoom => params[:zoom], + :name => "#{params[:lat]}, #{params[:lon]}") + end - # decode the location - if m = query.match(/^([+-]?\d+(\.\d*)?)\s*[\s,]\s*([+-]?\d+(\.\d*)?)$/) - lat = m[1].to_f - lon = m[3].to_f - end + if lon >= -90 && lon <= 90 && lat >= -180 && lat <= 180 + @results.push(:lat => params[:lon], :lon => params[:lat], + :zoom => params[:zoom], + :name => "#{params[:lon]}, #{params[:lat]}") + end - # generate results - if lat < -90 or lat > 90 - return { :source => "Internal", :url => "http://openstreetmap.org/", :error => "Latitude #{lat} out of range" } - elsif lon < -180 or lon > 180 - return { :source => "Internal", :url => "http://openstreetmap.org/", :error => "Longitude #{lon} out of range" } + if @results.empty? + @error = "Latitude or longitude are out of range" + render :action => "error" + else + render :action => "results" + end else - results.push({:lat => lat, :lon => lon, - :zoom => APP_CONFIG['postcode_zoom'], - :name => "#{lat}, #{lon}"}) + # Coordinates in a query have come with markers for latitude and longitude. + if lat < -90 || lat > 90 + @error = "Latitude #{lat} out of range" + render :action => "error" + elsif lon < -180 || lon > 180 + @error = "Longitude #{lon} out of range" + render :action => "error" + else + @results = [{ :lat => params[:lat], :lon => params[:lon], + :zoom => params[:zoom], + :name => "#{params[:lat]}, #{params[:lon]}" }] - return { :source => "Internal", :url => "http://openstreetmap.org/", :results => results } + render :action => "results" + end end end - def search_us_postcode(query) - results = Array.new - - # ask geocoder.us (they have a non-commercial use api) - response = fetch_text("http://rpc.geocoder.us/service/csv?zip=#{escape_query(query)}") + def search_osm_nominatim + # ask nominatim + response = fetch_xml(nominatim_url(:format => "xml")) - # parse the response - unless response.match(/couldn't find this zip/) - data = response.split(/\s*,\s+/) # lat,long,town,state,zip - results.push({:lat => data[0], :lon => data[1], - :zoom => APP_CONFIG['postcode_zoom'], - :prefix => "#{data[2]}, #{data[3]}, ", - :name => data[4]}) - end - - return { :source => "Geocoder.us", :url => "http://geocoder.us/", :results => results } - rescue Exception => ex - return { :source => "Geocoder.us", :url => "http://geocoder.us/", :error => "Error contacting rpc.geocoder.us: #{ex.to_s}" } - end + # extract the results from the response + results = response.elements["searchresults"] - def search_uk_postcode(query) - results = Array.new + # create result array + @results = [] - # ask npemap.org.uk to do a combined npemap + freethepostcode search - response = fetch_text("http://www.npemap.org.uk/cgi/geocoder.fcgi?format=text&postcode=#{escape_query(query)}") + # create parameter hash for "more results" link + @more_params = params + .permit(:query, :minlon, :minlat, :maxlon, :maxlat, :exclude) + .merge(:exclude => results.attributes["exclude_place_ids"]) # parse the response - unless response.match(/Error/) - dataline = response.split(/\n/)[1] - data = dataline.split(/,/) # easting,northing,postcode,lat,long - postcode = data[2].gsub(/'/, "") - zoom = APP_CONFIG['postcode_zoom'] - postcode.count("#") - results.push({:lat => data[3], :lon => data[4], :zoom => zoom, - :name => postcode}) + results.elements.each("place") do |place| + lat = place.attributes["lat"] + lon = place.attributes["lon"] + klass = place.attributes["class"] + type = place.attributes["type"] + name = place.attributes["display_name"] + min_lat, max_lat, min_lon, max_lon = place.attributes["boundingbox"].split(",") + prefix_name = if type.empty? + "" + else + t "geocoder.search_osm_nominatim.prefix.#{klass}.#{type}", :default => type.tr("_", " ").capitalize + end + if klass == "boundary" && type == "administrative" + rank = (place.attributes["address_rank"].to_i + 1) / 2 + prefix_name = t "geocoder.search_osm_nominatim.admin_levels.level#{rank}", :default => prefix_name + place.elements["extratags"].elements.each("tag") do |extratag| + prefix_name = t "geocoder.search_osm_nominatim.prefix.place.#{extratag.attributes['value']}", :default => prefix_name if extratag.attributes["key"] == "linked_place" || extratag.attributes["key"] == "place" + end + end + prefix = t ".prefix_format", :name => prefix_name + object_type = place.attributes["osm_type"] + object_id = place.attributes["osm_id"] + + @results.push(:lat => lat, :lon => lon, + :min_lat => min_lat, :max_lat => max_lat, + :min_lon => min_lon, :max_lon => max_lon, + :prefix => prefix, :name => name, + :type => object_type, :id => object_id) end - return { :source => "NPEMap / FreeThePostcode", :url => "http://www.npemap.org.uk/", :results => results } - rescue Exception => ex - return { :source => "NPEMap / FreeThePostcode", :url => "http://www.npemap.org.uk/", :error => "Error contacting www.npemap.org.uk: #{ex.to_s}" } + render :action => "results" + rescue StandardError => e + host = URI(Settings.nominatim_url).host + @error = "Error contacting #{host}: #{e}" + render :action => "error" end - def search_ca_postcode(query) - results = Array.new + def search_osm_nominatim_reverse + # get query parameters + zoom = params[:zoom] - # ask geocoder.ca (note - they have a per-day limit) - response = fetch_xml("http://geocoder.ca/?geoit=XML&postal=#{escape_query(query)}") + # create result array + @results = [] + + # ask nominatim + response = fetch_xml(nominatim_reverse_url(:format => "xml")) # parse the response - if response.get_elements("geodata/error").empty? - results.push({:lat => response.get_text("geodata/latt").to_s, - :lon => response.get_text("geodata/longt").to_s, - :zoom => APP_CONFIG['postcode_zoom'], - :name => query.upcase}) + response.elements.each("reversegeocode/result") do |result| + lat = result.attributes["lat"] + lon = result.attributes["lon"] + object_type = result.attributes["osm_type"] + object_id = result.attributes["osm_id"] + description = result.text + + @results.push(:lat => lat, :lon => lon, + :zoom => zoom, + :name => description, + :type => object_type, :id => object_id) end - return { :source => "Geocoder.CA", :url => "http://geocoder.ca/", :results => results } - rescue Exception => ex - return { :source => "Geocoder.CA", :url => "http://geocoder.ca/", :error => "Error contacting geocoder.ca: #{ex.to_s}" } + render :action => "results" + rescue StandardError => e + host = URI(Settings.nominatim_url).host + @error = "Error contacting #{host}: #{e}" + render :action => "error" end - def search_osm_namefinder(query) - results = Array.new - - # ask OSM namefinder - response = fetch_xml("http://gazetteer.openstreetmap.org/namefinder/search.xml?find=#{escape_query(query)}") + private - # parse the response - response.elements.each("searchresults/named") do |named| - lat = named.attributes["lat"].to_s - lon = named.attributes["lon"].to_s - zoom = named.attributes["zoom"].to_s - place = named.elements["place/named"] || named.elements["nearestplaces/named"] - type = named.attributes["info"].to_s.capitalize - name = named.attributes["name"].to_s - description = named.elements["description"].to_s - - if name.empty? - prefix = "" - name = type - else - prefix = t "geocoder.results.namefinder.prefix", :type => type - end + def nominatim_url(format: nil) + # get query parameters + query = params[:query] + minlon = params[:minlon] + minlat = params[:minlat] + maxlon = params[:maxlon] + maxlat = params[:maxlat] - if place - distance = format_distance(place.attributes["approxdistance"].to_i) - direction = format_direction(place.attributes["direction"].to_i) - placename = format_name(place.attributes["name"].to_s) - suffix = t "geocoder.results.namefinder.suffix_place", :distance => distance, :direction => direction, :placename => placename - - if place.attributes["rank"].to_i <= 30 - parent = nil - parentrank = 0 - parentscore = 0 - - place.elements.each("nearestplaces/named") do |nearest| - nearestrank = nearest.attributes["rank"].to_i - nearestscore = nearestrank / nearest.attributes["distance"].to_f - - if nearestrank > 30 and - ( nearestscore > parentscore or - ( nearestscore == parentscore and nearestrank > parentrank ) ) - parent = nearest - parentrank = nearestrank - parentscore = nearestscore - end - end - - if parent - parentname = format_name(parent.attributes["name"].to_s) - - if place.attributes["info"].to_s == "suburb" - suffix = t "geocoder.results.namefinder.suffix_suburb", :suffix => suffix, :parentname => parentname - else - parentdistance = format_distance(parent.attributes["approxdistance"].to_i) - parentdirection = format_direction(parent.attributes["direction"].to_i) - suffix = t "geocoder.results.namefinder.suffix_parent", :suffix => suffix, :parentdistance => parentdistance, :parentdirection => parentdirection, :parentname => parentname - end - end - end - else - suffix = "" - end + # get view box + viewbox = "&viewbox=#{minlon},#{maxlat},#{maxlon},#{minlat}" if minlon && minlat && maxlon && maxlat - results.push({:lat => lat, :lon => lon, :zoom => zoom, - :prefix => prefix, :name => name, :suffix => suffix, - :description => description}) - end + # get objects to excude + exclude = "&exclude_place_ids=#{params[:exclude]}" if params[:exclude] - return { :source => "OpenStreetMap Namefinder", :url => "http://gazetteer.openstreetmap.org/namefinder/", :results => results } - rescue Exception => ex - return { :source => "OpenStreetMap Namefinder", :url => "http://gazetteer.openstreetmap.org/namefinder/", :error => "Error contacting gazetteer.openstreetmap.org: #{ex.to_s}" } + # build url + "#{Settings.nominatim_url}search?format=#{format}&extratags=1&q=#{escape_query(query)}#{viewbox}#{exclude}&accept-language=#{http_accept_language.user_preferred_languages.join(',')}" end - def search_geonames(query) - results = Array.new - - # ask geonames.org - response = fetch_xml("http://ws.geonames.org/search?q=#{escape_query(query)}&maxRows=20") - - # parse the response - response.elements.each("geonames/geoname") do |geoname| - lat = geoname.get_text("lat").to_s - lon = geoname.get_text("lng").to_s - name = geoname.get_text("name").to_s - country = geoname.get_text("countryName").to_s - results.push({:lat => lat, :lon => lon, - :zoom => APP_CONFIG['geonames_zoom'], - :name => name, - :suffix => ", #{country}"}) - end + def nominatim_reverse_url(format: nil) + # get query parameters + lat = params[:lat] + lon = params[:lon] + zoom = params[:zoom] - return { :source => "GeoNames", :url => "http://www.geonames.org/", :results => results } - rescue Exception => ex - return { :source => "GeoNames", :url => "http://www.geonames.org/", :error => "Error contacting ws.geonames.org: #{ex.to_s}" } + # build url + "#{Settings.nominatim_url}reverse?format=#{format}&lat=#{lat}&lon=#{lon}&zoom=#{zoom}&accept-language=#{http_accept_language.user_preferred_languages.join(',')}" end - def description_osm_namefinder(types, lat, lon, max) - results = Array.new - - # ask OSM namefinder - response = fetch_xml("http://gazetteer.openstreetmap.org/namefinder/search.xml?find=#{types}+near+#{lat},#{lon}&max=#{max}") + def fetch_text(url) + response = OSM.http_client.get(URI.parse(url)) - # parse the response - response.elements.each("searchresults/named") do |named| - lat = named.attributes["lat"].to_s - lon = named.attributes["lon"].to_s - zoom = named.attributes["zoom"].to_s - place = named.elements["place/named"] || named.elements["nearestplaces/named"] - type = named.attributes["info"].to_s - name = named.attributes["name"].to_s - description = named.elements["description"].to_s - distance = format_distance(place.attributes["approxdistance"].to_i) - direction = format_direction((place.attributes["direction"].to_i - 180) % 360) - prefix = "#{distance} #{direction} of #{type} " - results.push({:lat => lat, :lon => lon, :zoom => zoom, - :prefix => prefix.capitalize, :name => name, - :description => description}) + if response.success? + response.body + else + raise response.status.to_s end - - return { :type => types.capitalize, :source => "OpenStreetMap Namefinder", :url => "http://gazetteer.openstreetmap.org/namefinder/", :results => results } - rescue Exception => ex - return { :type => types.capitalize, :source => "OpenStreetMap Namefinder", :url => "http://gazetteer.openstreetmap.org/namefinder/", :error => "Error contacting gazetteer.openstreetmap.org: #{ex.to_s}" } end - def description_geonames(lat, lon) - results = Array.new - - # ask geonames.org - response = fetch_xml("http://ws.geonames.org/countrySubdivision?lat=#{lat}&lng=#{lon}") - - # parse the response - response.elements.each("geonames/countrySubdivision") do |geoname| - name = geoname.get_text("adminName1").to_s - country = geoname.get_text("countryName").to_s - results.push({:prefix => "#{name}, #{country}"}) - end - - return { :type => "Location", :source => "GeoNames", :url => "http://www.geonames.org/", :results => results } - rescue Exception => ex - return { :type => "Location", :source => "GeoNames", :url => "http://www.geonames.org/", :error => "Error contacting ws.geonames.org: #{ex.to_s}" } + def fetch_xml(url) + REXML::Document.new(fetch_text(url)) end - def fetch_text(url) - return Net::HTTP.get(URI.parse(url)) + def escape_query(query) + CGI.escape(query) end - def fetch_xml(url) - return REXML::Document.new(fetch_text(url)) - end + def normalize_params + if query = params[:query] + query.strip! - def format_distance(distance) - return t("geocoder.results.distance", :count => distance) - end + if latlon = query.match(/^(?[NS])\s*#{dms_regexp('ns')}\W*(?[EW])\s*#{dms_regexp('ew')}$/) || + query.match(/^#{dms_regexp('ns')}\s*(?[NS])\W*#{dms_regexp('ew')}\s*(?[EW])$/) + params.merge!(to_decdeg(latlon.named_captures.compact)).delete(:query) + + elsif latlon = query.match(%r{^(?[+-]?\d+(?:\.\d+)?)(?:\s+|\s*[,/]\s*)(?[+-]?\d+(?:\.\d+)?)$}) + params.merge!(:lat => latlon["lat"], :lon => latlon["lon"]).delete(:query) + + params[:latlon_digits] = true + end + end - def format_direction(bearing) - return t("geocoder.results.direction.south_west") if bearing >= 22.5 and bearing < 67.5 - return t("geocoder.results.direction.south") if bearing >= 67.5 and bearing < 112.5 - return t("geocoder.results.direction.south_east") if bearing >= 112.5 and bearing < 157.5 - return t("geocoder.results.direction.east") if bearing >= 157.5 and bearing < 202.5 - return t("geocoder.results.direction.north_east") if bearing >= 202.5 and bearing < 247.5 - return t("geocoder.results.direction.north") if bearing >= 247.5 and bearing < 292.5 - return t("geocoder.results.direction.north_west") if bearing >= 292.5 and bearing < 337.5 - return t("geocoder.results.direction.west") + params.permit(:query, :lat, :lon, :latlon_digits, :zoom, :minlat, :minlon, :maxlat, :maxlon) end - def format_name(name) - return name.gsub(/( *\[[^\]]*\])*$/, "") + def dms_regexp(name_prefix) + / + (?: (?<#{name_prefix}d>\d{1,3}(?:\.\d+)?)°? ) | + (?: (?<#{name_prefix}d>\d{1,3})°?\s*(?<#{name_prefix}m>\d{1,2}(?:\.\d+)?)['′]? ) | + (?: (?<#{name_prefix}d>\d{1,3})°?\s*(?<#{name_prefix}m>\d{1,2})['′]?\s*(?<#{name_prefix}s>\d{1,2}(?:\.\d+)?)["″]? ) + /x end - def count_results(results) - count = 0 + def to_decdeg(captures) + ns = captures.fetch("ns").casecmp?("s") ? -1 : 1 + nsd = BigDecimal(captures.fetch("nsd", "0")) + nsm = BigDecimal(captures.fetch("nsm", "0")) + nss = BigDecimal(captures.fetch("nss", "0")) - results.each do |source| - count += source[:results].length if source[:results] - end + ew = captures.fetch("ew").casecmp?("w") ? -1 : 1 + ewd = BigDecimal(captures.fetch("ewd", "0")) + ewm = BigDecimal(captures.fetch("ewm", "0")) + ews = BigDecimal(captures.fetch("ews", "0")) - return count - end + lat = ns * (nsd + (nsm / 60) + (nss / 3600)) + lon = ew * (ewd + (ewm / 60) + (ews / 3600)) - def escape_query(query) - return URI.escape(query, Regexp.new("[^#{URI::PATTERN::UNRESERVED}]", false, 'N')) + { :lat => lat.round(6).to_s("F"), :lon => lon.round(6).to_s("F") } end end