X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/b95e9d27599ee55b2fd61a444acc3264c7637265..d69a518b9e69107503b332728dfa583594293ea1:/app/controllers/node_controller.rb diff --git a/app/controllers/node_controller.rb b/app/controllers/node_controller.rb index 428d4b9c2..edc3675e5 100644 --- a/app/controllers/node_controller.rb +++ b/app/controllers/node_controller.rb @@ -1,110 +1,111 @@ +# The NodeController is the RESTful interface to Node objects + class NodeController < ApplicationController require 'xml/libxml' - before_filter :authorize + session :off + before_filter :authorize, :only => [:create, :update, :delete] + before_filter :check_write_availability, :only => [:create, :update, :delete] + before_filter :check_read_availability, :except => [:create, :update, :delete] + after_filter :compress_output + # Create a node from XML. def create if request.put? node = Node.from_xml(request.raw_post, true) if node node.user_id = @user.id - if node.save_with_history - - render :text => node.id - else - render :nothing => true, :status => 500 - end - return + node.visible = true + node.save_with_history! + render :text => node.id.to_s, :content_type => "text/plain" else - render :nothing => true, :status => 400 # if we got here the doc didnt parse - return + render :nothing => true, :status => :bad_request end + else + render :nothing => true, :status => :method_not_allowed end - - render :nothing => true, :status => 500 # something went very wrong end - def rest - unless Node.exists?(params[:id]) - render :nothing => true, :status => 404 - return - end - - node = Node.find(params[:id]) - - case request.method - - when :get - unless node - render :nothing => true, :status => 500 - return + # Dump the details on a node given in params[:id] + def read + begin + node = Node.find(params[:id]) + if node.visible + response.headers['Last-Modified'] = node.timestamp.rfc822 + render :text => node.to_xml.to_s, :content_type => "text/xml" + else + render :text => "", :status => :gone end + rescue ActiveRecord::RecordNotFound + render :nothing => true, :status => :not_found + end + end - unless node.visible - render :nothing => true, :status => 410 - return - end + # Update a node from given XML + def update + begin + node = Node.find(params[:id]) + new_node = Node.from_xml(request.raw_post) - render :text => node.to_xml.to_s - return + if new_node and new_node.id == node.id + node.user_id = @user.id + node.latitude = new_node.latitude + node.longitude = new_node.longitude + node.tags = new_node.tags + node.visible = true + node.save_with_history! - when :delete - if node.visible - node.visible = 0 - node.save_with_history render :nothing => true else - render :nothing => true, :status => 410 + render :nothing => true, :status => :bad_request end + rescue ActiveRecord::RecordNotFound + render :nothing => true, :status => :not_found + end + end - when :put - new_node = Node.from_xml(request.raw_post) - - node.timestamp = Time.now - node.user_id = @user.id + # Delete a node. Doesn't actually delete it, but retains its history in a wiki-like way. + # FIXME remove all the fricking SQL + def delete + begin + node = Node.find(params[:id]) - node.latitude = new_node.latitude - node.longitude = new_node.longitude - node.tags = new_node.tags + if node.visible + if WayNode.find(:first, :joins => "INNER JOIN current_ways ON current_ways.id = current_way_nodes.id", :conditions => [ "current_ways.visible = 1 AND current_way_nodes.node_id = ?", node.id ]) + render :text => "", :status => :precondition_failed + elsif RelationMember.find(:first, :joins => "INNER JOIN current_relations ON current_relations.id=current_relation_members.id", :conditions => [ "visible = 1 AND member_type='node' and member_id=?", params[:id]]) + render :text => "", :status => :precondition_failed + else + node.user_id = @user.id + node.visible = 0 + node.save_with_history! - if node.id == new_node.id and node.save_with_history - render :nothing => true, :status => 200 + render :nothing => true + end else - render :nothing => true, :status => 500 + render :text => "", :status => :gone end - return + rescue ActiveRecord::RecordNotFound + render :nothing => true, :status => :not_found end - end - def history - node = Node.find(params[:id]) + # WTF does this do? + def nodes + ids = params['nodes'].split(',').collect { |n| n.to_i } - unless node - render :nothing => true, :staus => 404 - return - end + if ids.length > 0 + doc = OSM::API.new.get_xml_doc - doc = XML::Document.new - doc.encoding = 'UTF-8' - root = XML::Node.new 'osm' - root['version'] = '0.4' - root['generator'] = 'OpenStreetMap server' - doc.root = root - - node.old_nodes.each do |old_node| - el1 = XML::Node.new 'node' - el1['id'] = old_node.id.to_s - el1['lat'] = old_node.latitude.to_s - el1['lon'] = old_node.longitude.to_s - Node.split_tags(el1, old_node.tags) - el1['visible'] = old_node.visible.to_s - el1['timestamp'] = old_node.timestamp.xmlschema - root << el1 - end + Node.find(ids).each do |node| + doc.root << node.to_xml_node + end - render :text => doc.to_s + render :text => doc.to_s, :content_type => "text/xml" + else + render :nothing => true, :status => :bad_request + end end end