X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/bb7f5ac2c8cf74669b421e7ae346a0cdd1ba5186..3d79f9fd88ab2784b292c8eafc46070472b2a4c9:/lib/osm_community_index/resource_backend.rb?ds=sidebyside diff --git a/lib/osm_community_index/resource_backend.rb b/lib/osm_community_index/resource_backend.rb index e16d951a4..3ed14e6de 100644 --- a/lib/osm_community_index/resource_backend.rb +++ b/lib/osm_community_index/resource_backend.rb @@ -8,7 +8,30 @@ module OsmCommunityIndex def self.load(file_path) resources = JSON.parse(File.read(file_path)) + resources["resources"].values.map! do |v| + v["strings"]["url"] = nil unless valid_url? v["strings"]["url"] + end resources["resources"].values end + + # This is to avoid any problems if upstream contains urls with `script:` or + # similar schemes, i.e. to guard against supply-chain attacks. + # Unfortunately the validates_url gem doesn't support `mailto:` or similar + # urls. This method is based on their approach to validation. + def self.valid_url?(url) + return true if url.nil? + + schemes = %w[http https mailto xmpp] + uri = URI.parse(url) + scheme = uri&.scheme + + valid_raw_url = scheme && url =~ /\A#{URI::DEFAULT_PARSER.make_regexp([scheme])}\z/ + valid_scheme = scheme && schemes.include?(scheme) + return true if valid_raw_url && valid_scheme + + false + rescue URI::InvalidURIError, URI::InvalidComponentError + false + end end end