X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/c91b86a1d1271c2bc801ee9dfc3a30fb2758aa9b..27532c3c3ad5b43af88dca96e54c88412d7ac601:/app/controllers/segment_controller.rb

diff --git a/app/controllers/segment_controller.rb b/app/controllers/segment_controller.rb
index 28c7580df..92825115f 100644
--- a/app/controllers/segment_controller.rb
+++ b/app/controllers/segment_controller.rb
@@ -14,9 +14,15 @@ class SegmentController < ApplicationController
 
         segment.from_node = Node.find(segment.node_a.to_i)
         segment.to_node = Node.find(segment.node_b.to_i)
+          
+        if segment.from_node == segment.to_node
+          render :nothing => true, :status => HTTP_EXPECTATION_FAILED
+          return
+        end
         
         unless segment.preconditions_ok? # are the nodes visible?
-          render :nothing => true, :status => 412
+          render :nothing => true, :status => HTTP_PRECONDITION_FAILED
+          return
         end
 
         if segment.save_with_history
@@ -25,7 +31,6 @@ class SegmentController < ApplicationController
           render :nothing => true, :status => 500
         end
         return
-
       else
         render :nothing => true, :status => 400 # if we got here the doc didnt parse
         return
@@ -52,9 +57,13 @@ class SegmentController < ApplicationController
 
     when :delete
       if segment.visible
-        segment.visible = 0
-        segment.save_with_history
-        render :nothing => true
+        if WaySegment.find(:first, :joins => "INNER JOIN current_ways ON current_ways.id = current_way_segments.id", :conditions => [ "current_ways.visible = 1 AND current_way_segments.segment_id = ?", segment.id ])
+          render :nothing => true, :status => HTTP_PRECONDITION_FAILED
+        else
+          segment.visible = 0
+          segment.save_with_history
+          render :nothing => true
+        end
       else
         render :nothing => true, :status => 410
       end
@@ -62,20 +71,32 @@ class SegmentController < ApplicationController
     when :put
       new_segment = Segment.from_xml(request.raw_post)
 
-      segment.timestamp = Time.now
-      segment.user_id = @user.id
+      if new_segment
+        if new_segment.node_a == new_segment.node_b
+          render :nothing => true, :status => HTTP_EXPECTATION_FAILED
+          return
+        end
+        
+        unless new_segment.preconditions_ok? # are the nodes visible?
+          render :nothing => true, :status => HTTP_PRECONDITION_FAILED
+          return
+        end
 
-      segment.node_a = new_segment.node_a
-      segment.node_b = new_segment.node_b
-      segment.tags = new_segment.tags
-      segment.visible = new_segment.visible
+        segment.timestamp = Time.now
+        segment.user_id = @user.id
+        segment.node_a = new_segment.node_a
+        segment.node_b = new_segment.node_b
+        segment.tags = new_segment.tags
+        segment.visible = new_segment.visible
 
-      if segment.id == new_segment.id and segment.save_with_history
-        render :nothing => true, :status => 200
+        if segment.id == new_segment.id and segment.save_with_history
+          render :nothing => true
+        else
+          render :nothing => true, :status => 500
+        end
       else
-        render :nothing => true, :status => 500
+        render :nothing => true, :status => 400 # if we got here the doc didnt parse
       end
-      return
     end
 
   end