X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/c9a3091ca8304a5695102d671fdb5546c952b946..6a3cadb52d010b333a4acea8942bc4c13394e236:/app/helpers/browse_helper.rb diff --git a/app/helpers/browse_helper.rb b/app/helpers/browse_helper.rb index 07dd866ba..090d1e9c3 100644 --- a/app/helpers/browse_helper.rb +++ b/app/helpers/browse_helper.rb @@ -2,7 +2,7 @@ module BrowseHelper def link_to_page(page, page_param) return link_to(page, page_param => page) end - + def printable_name(object, version=false) name = t 'printable_name.with_id', :id => object.id.to_s if version @@ -16,6 +16,14 @@ module BrowseHelper return name end + def link_class(type, object) + return type + " " + h(icon_tags(object).join(' ')) + (object.visible == false ? ' deleted' : '') + end + + def link_title(object) + return h(icon_tags(object).map { |k,v| k + '=' + v }.to_sentence) + end + def format_key(key) if url = wiki_link("key", key) link_to h(key), url, :title => t('browse.tag_details.wiki_link.key', :key => key) @@ -26,7 +34,7 @@ module BrowseHelper def format_value(key, value) if wp = wikipedia_link(key, value) - link_to h(wp['title']), wp['url'], :title => t('browse.tag_details.wiki_link.wikipedia', :page => wp['title']) + link_to h(wp[:title]), wp[:url], :title => t('browse.tag_details.wikipedia_link', :page => wp[:title]) elsif url = wiki_link("tag", "#{key}=#{value}") link_to h(value), url, :title => t('browse.tag_details.wiki_link.tag', :key => key, :value => value) else @@ -36,6 +44,15 @@ module BrowseHelper private + ICON_TAGS = [ + "aeroway", "amenity", "barrier", "building", "highway", "historic", "landuse", + "leisure", "man_made", "natural", "railway", "shop", "tourism", "waterway" + ] + + def icon_tags(object) + object.tags.find_all { |k,v| ICON_TAGS.include? k } + end + def wiki_link(type, lookup) locale = I18n.locale.to_s @@ -49,32 +66,31 @@ private end def wikipedia_link(key, value) - # English Wikipedia by default - lang = 'en' - - if key == 'wikipedia' or key =~ /^wikipedia:(\S+)$/ - mylang = $1 + # Some k/v's are wikipedia=http://en.wikipedia.org/wiki/Full%20URL + return nil if value =~ /^http:\/\// - # Some k/v's are wikipedia=http://en.wikipedia.org/wiki/Full%20URL - return nil if value =~ /^http:\/\// - - if mylang - lang = mylang + if key == "wikipedia" # This regex should match Wikipedia language codes, everything # from de to zh-classical - elsif value =~ /^([a-z-]{2,12}):(.+)$/ + if value =~ /^([a-z-]{2,12}):(.+)$/ + # Value is : so split it up lang = $1 - # Don't display e.g. "en:Foobar" as the title, just "Foobar" value = $2 + else + # Value is <title> so default to English Wikipedia + lang = 'en' end - - locale = I18n.locale.to_s - return { - 'url' => "http://#{lang}.wikipedia.org/wiki/#{value}?uselang=#{locale}", - 'title' => value - } + elsif key =~ /^wikipedia:(\S+)$/ + # Language is in the key, so assume value is a simple title + lang = $1 else + # Not a wikipedia key! return nil end + + return { + :url => "http://#{lang}.wikipedia.org/wiki/#{value}?uselang=#{I18n.locale}", + :title => value + } end end