X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/c9d35839befe92d916425baa4daec7dd77ade929..1cee23ddc2ddffa927906a3aab416b926ea2e137:/.rubocop_todo.yml?ds=inline diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 71d949dae..8c0827ab7 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,204 +1,218 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2015-08-18 20:27:49 +0100 using RuboCop version 0.33.0. +# on 2021-12-28 19:44:27 UTC using RuboCop version 1.24.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 34 -Lint/AmbiguousOperator: - Exclude: - - 'test/controllers/amf_controller_test.rb' - - 'test/controllers/changeset_controller_test.rb' - - 'test/lib/bounding_box_test.rb' - - 'test/lib/country_test.rb' +# Work around erblint issues. +# https://github.com/openstreetmap/openstreetmap-website/issues/2472 +require: + - rubocop-minitest + - rubocop-performance + - rubocop-rails + - rubocop-rake -# Offense count: 115 -Lint/AmbiguousRegexpLiteral: - Enabled: false +# Offense count: 544 +# Cop supports --auto-correct. +# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# URISchemes: http, https +Layout/LineLength: + Max: 270 + +# Offense count: 62 +# Cop supports --auto-correct. +Lint/AmbiguousOperatorPrecedence: + Exclude: + - 'app/controllers/geocoder_controller.rb' + - 'app/models/user.rb' + - 'lib/bounding_box.rb' + - 'lib/osm.rb' + - 'lib/rich_text.rb' + - 'lib/short_link.rb' + - 'test/controllers/api/old_nodes_controller_test.rb' + - 'test/lib/short_link_test.rb' -# Offense count: 29 +# Offense count: 34 # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: Exclude: + - 'app/controllers/accounts_controller.rb' + - 'app/controllers/api/traces_controller.rb' + - 'app/controllers/api/user_preferences_controller.rb' - 'app/controllers/application_controller.rb' - 'app/controllers/geocoder_controller.rb' - 'app/controllers/notes_controller.rb' - - 'app/controllers/trace_controller.rb' - - 'app/controllers/user_controller.rb' - - 'app/controllers/user_preference_controller.rb' + - 'app/controllers/traces_controller.rb' + - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - - 'app/helpers/browse_helper.rb' + - 'app/helpers/browse_tags_helper.rb' + - 'app/mailers/user_mailer.rb' - 'app/models/client_application.rb' - - 'app/models/notifier.rb' - 'lib/nominatim.rb' - 'lib/osm.rb' - 'script/deliver-message' -# Offense count: 3 -Lint/FormatParameterMismatch: - Exclude: - - 'app/controllers/swf_controller.rb' - -# Offense count: 5 -Lint/HandleExceptions: +# Offense count: 7 +# Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches. +Lint/DuplicateBranch: Exclude: - - 'app/controllers/amf_controller.rb' - - 'app/controllers/user_controller.rb' - - 'config/initializers/session.rb' - -# Offense count: 8 -Lint/ParenthesesAsGroupedExpression: - Exclude: - - 'test/controllers/amf_controller_test.rb' - - 'test/lib/bounding_box_test.rb' - - 'test/models/user_preference_test.rb' + - 'app/controllers/api_controller.rb' + - 'app/controllers/diary_entries_controller.rb' + - 'app/controllers/geocoder_controller.rb' + - 'app/helpers/browse_tags_helper.rb' -# Offense count: 671 +# Offense count: 663 +# Configuration parameters: IgnoredMethods, CountRepeatedAttributes. Metrics/AbcSize: - Max: 277 + Max: 189 + +# Offense count: 72 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. +# IgnoredMethods: refine +Metrics/BlockLength: + Max: 71 -# Offense count: 12 +# Offense count: 15 +# Configuration parameters: CountBlocks. Metrics/BlockNesting: Max: 5 -# Offense count: 62 -# Configuration parameters: CountComments. +# Offense count: 25 +# Configuration parameters: CountComments, CountAsOne. Metrics/ClassLength: - Max: 1653 + Max: 313 -# Offense count: 67 +# Offense count: 57 +# Configuration parameters: IgnoredMethods. Metrics/CyclomaticComplexity: - Max: 20 - -# Offense count: 2535 -# Configuration parameters: AllowURI, URISchemes. -Metrics/LineLength: - Max: 694 + Max: 25 -# Offense count: 628 -# Configuration parameters: CountComments. +# Offense count: 739 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. Metrics/MethodLength: Max: 179 # Offense count: 1 -# Configuration parameters: CountComments. -Metrics/ModuleLength: - Max: 126 - -# Offense count: 4 -# Configuration parameters: CountKeywordArgs. +# Configuration parameters: CountKeywordArgs, MaxOptionalParameters. Metrics/ParameterLists: - Max: 9 + Max: 6 -# Offense count: 69 +# Offense count: 59 +# Configuration parameters: IgnoredMethods. Metrics/PerceivedComplexity: - Max: 23 + Max: 26 + +# Offense count: 549 +Minitest/MultipleAssertions: + Max: 52 + +# Offense count: 3 +Naming/AccessorMethodName: + Exclude: + - 'app/controllers/application_controller.rb' + - 'app/helpers/title_helper.rb' + - 'lib/osm.rb' + +# Offense count: 8 +# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros. +# NamePrefix: is_, has_, have_ +# ForbiddenPrefixes: is_, has_, have_ +# AllowedMethods: is_a? +# MethodDefinitionMacros: define_method, define_singleton_method +Naming/PredicateName: + Exclude: + - 'app/models/changeset.rb' + - 'app/models/old_node.rb' + - 'app/models/old_relation.rb' + - 'app/models/old_way.rb' + - 'app/models/user.rb' + - 'lib/classic_pagination/pagination.rb' + +# Offense count: 5 +# Configuration parameters: Database, Include. +# SupportedDatabases: mysql, postgresql +# Include: db/migrate/*.rb +Rails/BulkChangeTable: + Exclude: + - 'db/migrate/20111116184519_update_oauth.rb' + - 'db/migrate/20120208194454_add_domain_to_acl.rb' + - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' # Offense count: 2 # Configuration parameters: Include. +# Include: app/models/**/*.rb Rails/HasAndBelongsToMany: Exclude: - 'app/models/changeset.rb' - 'app/models/user.rb' -# Offense count: 66 -# Configuration parameters: EnforcedStyle, SupportedStyles. -Rails/TimeZone: - Enabled: false - -# Offense count: 5 -Style/AccessorMethodName: +# Offense count: 3 +# Configuration parameters: Include. +# Include: app/helpers/**/*.rb +Rails/HelperInstanceVariable: Exclude: - - 'app/controllers/application_controller.rb' - 'app/helpers/title_helper.rb' - - 'app/models/old_way.rb' - - 'lib/osm.rb' - - 'lib/potlatch.rb' # Offense count: 1 -Style/AsciiComments: +# Configuration parameters: Include. +# Include: app/controllers/**/*.rb +Rails/LexicallyScopedActionFilter: Exclude: - - 'test/models/message_test.rb' + - 'app/controllers/oauth2_applications_controller.rb' + - 'app/controllers/oauth2_authorizations_controller.rb' -# Offense count: 310 -Style/Documentation: - Enabled: false +# Offense count: 5 +# Configuration parameters: Include. +# Include: db/migrate/*.rb +Rails/NotNullColumn: + Exclude: + - 'db/migrate/002_cleanup_osm_db.rb' + - 'db/migrate/020_populate_node_tags_and_remove.rb' + - 'db/migrate/021_move_to_innodb.rb' + - 'db/migrate/025_add_end_time_to_changesets.rb' + - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' -# Offense count: 38 -# Configuration parameters: MinBodyLength. -Style/GuardClause: +# Offense count: 9 +Rails/OutputSafety: Exclude: - - 'app/controllers/application_controller.rb' - - 'app/controllers/diary_entry_controller.rb' - - 'app/controllers/message_controller.rb' - - 'app/controllers/notes_controller.rb' - - 'app/controllers/site_controller.rb' - - 'app/controllers/user_blocks_controller.rb' - - 'app/controllers/user_controller.rb' - - 'app/controllers/user_roles_controller.rb' + - 'app/controllers/sessions_controller.rb' + - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - - 'app/models/changeset.rb' - - 'app/models/user.rb' - - 'lib/diff_reader.rb' - - 'lib/object_metadata.rb' + - 'lib/rich_text.rb' + - 'test/helpers/application_helper_test.rb' -# Offense count: 60 +# Offense count: 23 # Cop supports --auto-correct. -Style/LineEndConcatenation: - Exclude: - - 'db/migrate/008_remove_segments.rb' - - 'db/migrate/020_populate_node_tags_and_remove.rb' - - 'db/migrate/023_add_changesets.rb' - - 'lib/bounding_box.rb' - - 'lib/diff_reader.rb' - - 'lib/osm.rb' - - 'test/controllers/changeset_controller_test.rb' - - 'test/controllers/node_controller_test.rb' - - 'test/controllers/relation_controller_test.rb' - - 'test/controllers/way_controller_test.rb' +Rails/RedundantPresenceValidationOnBelongsTo: + Enabled: false -# Offense count: 69 +# Offense count: 90 # Cop supports --auto-correct. -Style/NumericLiterals: - MinDigits: 11 +# Configuration parameters: EnforcedStyle. +# SupportedStyles: strict, flexible +Rails/TimeZone: + Enabled: false -# Offense count: 42 +# Offense count: 6 # Cop supports --auto-correct. -Style/PerlBackrefs: +Rake/Desc: Exclude: - - 'app/controllers/amf_controller.rb' - - 'app/controllers/application_controller.rb' - - 'app/helpers/browse_helper.rb' - - 'config/initializers/paperclip.rb' - - 'lib/id.rb' - - 'lib/potlatch.rb' - - 'test/lib/i18n_test.rb' - -# Offense count: 8 -# Configuration parameters: NamePrefix, NamePrefixBlacklist. -Style/PredicateName: - Exclude: - - 'app/models/changeset.rb' - - 'app/models/old_node.rb' - - 'app/models/old_relation.rb' - - 'app/models/old_way.rb' - - 'app/models/user.rb' - - 'lib/classic_pagination/pagination.rb' + - 'lib/tasks/auto_annotate_models.rake' + - 'lib/tasks/eslint.rake' + - 'lib/tasks/subscribe_diary_authors.rake' + - 'lib/tasks/subscribe_old_changesets.rake' -# Offense count: 97 -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/RaiseArgs: +# Offense count: 609 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: always, always_true, never +Style/FrozenStringLiteralComment: Enabled: false -# Offense count: 2 -Style/RescueModifier: - Exclude: - - 'app/helpers/browse_helper.rb' - -# Offense count: 8 +# Offense count: 72 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/StringLiteralsInInterpolation: - Enabled: false +# Configuration parameters: Strict, AllowedNumbers. +Style/NumericLiterals: + MinDigits: 15