X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/cb3c4ec09b70e7eae62494af795187b32128fd0c..73170726e2e1c6f5dcbb649f82c4a845b9d6e980:/.rubocop.yml diff --git a/.rubocop.yml b/.rubocop.yml index fc2b5cd85..8b6ed0180 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,5 +1,19 @@ inherit_from: .rubocop_todo.yml +require: + - rubocop-capybara + - rubocop-factory_bot + - rubocop-minitest + - rubocop-performance + - rubocop-rails + - rubocop-rake + +AllCops: + TargetRubyVersion: 3.1 + NewCops: enable + Exclude: + - 'vendor/**/*' + Rails: Enabled: true @@ -9,59 +23,88 @@ Layout/ExtraSpacing: Lint/PercentStringArray: Exclude: - 'config/initializers/secure_headers.rb' + - 'app/controllers/application_controller.rb' - 'app/controllers/site_controller.rb' +Metrics/BlockLength: + Exclude: + - 'config/routes.rb' + +Metrics/ClassLength: + Exclude: + - 'test/**/*' + +Metrics/ModuleLength: + Max: 150 + Naming/FileName: Exclude: - 'script/deliver-message' - - 'script/locale/reload-languages' - 'script/update-spam-blocks' -Naming/UncommunicativeMethodParamName: +Naming/MethodParameterName: Enabled: false -Rails/ApplicationRecord: +# This conflicts with Strong Migrations, which can't check `change_table` +Rails/BulkChangeTable: Enabled: false Rails/CreateTableWithTimestamps: Enabled: false +Rails/FindBy: + IgnoreWhereFirst: false + +Rails/FindEach: + Enabled: false + Rails/HasManyOrHasOneDependent: Enabled: false Rails/HttpPositionalArguments: Enabled: false -Rails/InverseOf: +Rails/ReflectionClassName: Enabled: false Rails/SkipsModelValidations: Exclude: - 'db/migrate/*.rb' - - 'app/controllers/user_controller.rb' + - 'app/controllers/users_controller.rb' -Style/BracesAroundHashParameters: - EnforcedStyle: context_dependent +Style/Documentation: + Enabled: false Style/FormatStringToken: - EnforcedStyle: template + Exclude: + - 'config/routes.rb' Style/IfInsideElse: Enabled: false -Style/GlobalVars: - Exclude: - - 'lib/quad_tile/extconf.rb' - Style/GuardClause: Enabled: false +Style/HashEachMethods: + Enabled: true + Style/HashSyntax: EnforcedStyle: hash_rockets Exclude: - 'lib/tasks/testing.rake' - 'config/initializers/wrap_parameters.rb' +Style/HashTransformKeys: + Enabled: true + +Style/HashTransformValues: + Enabled: true + +Style/MixinUsage: + Exclude: + - 'bin/setup' + - 'bin/update' + Style/StringLiterals: EnforcedStyle: double_quotes