X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/cb87f02642d0097ebc067ca1f9371dde274a41e3..c47a40c1db59f0d0f836fbcd1b876390befe796e:/test/models/user_preference_test.rb?ds=sidebyside diff --git a/test/models/user_preference_test.rb b/test/models/user_preference_test.rb index bceec0719..ee91777c7 100644 --- a/test/models/user_preference_test.rb +++ b/test/models/user_preference_test.rb @@ -4,7 +4,7 @@ class UserPreferenceTest < ActiveSupport::TestCase # Checks that you cannot add a new preference, that is a duplicate def test_add_duplicate_preference up = create(:user_preference) - new_up = UserPreference.new + new_up = build(:user_preference) new_up.user = up.user new_up.k = up.k new_up.v = "some other value" @@ -15,12 +15,12 @@ class UserPreferenceTest < ActiveSupport::TestCase def test_check_valid_length key = "k" val = "v" - (1..255).each do |i| - up = UserPreference.new + [1, 255].each do |i| + up = build(:user_preference) up.user = create(:user) up.k = key * i up.v = val * i - assert up.valid? + assert_predicate up, :valid? assert up.save! resp = UserPreference.find(up.id) assert_equal key * i, resp.k, "User preference with #{i} #{key} chars (i.e. #{key.length * i} bytes) fails" @@ -32,11 +32,11 @@ class UserPreferenceTest < ActiveSupport::TestCase key = "k" val = "v" [0, 256].each do |i| - up = UserPreference.new + up = build(:user_preference) up.user = create(:user) up.k = key * i up.v = val * i - assert_equal false, up.valid? + assert_not_predicate up, :valid? assert_raise(ActiveRecord::RecordInvalid) { up.save! } end end