X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/cd72ee9a66a3a1810015269e378b6d1df93e9388..f8367c3ee1418548b5397b6a21f287c2407963e1:/app/controllers/search_controller.rb?ds=inline diff --git a/app/controllers/search_controller.rb b/app/controllers/search_controller.rb index 0a0b27ac5..6b83e3301 100644 --- a/app/controllers/search_controller.rb +++ b/app/controllers/search_controller.rb @@ -1,8 +1,7 @@ class SearchController < ApplicationController - # Support searching for nodes, segments, ways, or all + # Support searching for nodes, ways, or all # Can search by tag k, v, or both (type->k,value->v) # Can search by name (k=name,v=....) - after_filter :compress_output def search_all @@ -12,15 +11,14 @@ class SearchController < ApplicationController def search_ways do_search(true,false,false) end - def search_segments + def search_nodes do_search(false,true,false) end - def search_nodes + def search_relations do_search(false,false,true) end - - def do_search(do_ways,do_segments,do_nodes) + def do_search(do_ways,do_nodes,do_relations) type = params['type'] value = params['value'] unless type or value @@ -31,23 +29,48 @@ class SearchController < ApplicationController end end + if do_nodes + response.headers['Error'] = "Searching of nodes is currently unavailable" + render :nothing => true, :status => :service_unavailable + return false + end + + unless value + response.headers['Error'] = "Searching for a key without value is currently unavailable" + render :nothing => true, :status => :service_unavailable + return false + end + way_ids = Array.new ways = Array.new - segments = Array.new nodes = Array.new + relations = Array.new + + # Matching for tags table + cond_way = Array.new + sql = '1=1' + if type + sql += ' AND current_way_tags.k=?' + cond_way += [type] + end + if value + sql += ' AND current_way_tags.v=? AND MATCH (current_way_tags.v) AGAINST (? IN BOOLEAN MODE)' + cond_way += [value,'"' + value.sub(/[-+*<>"~()]/, ' ') + '"'] + end + cond_way = [sql] + cond_way # Matching for tags table - cond_tbl = Array.new + cond_rel = Array.new sql = '1=1' if type - sql += ' AND k=?' - cond_tbl += [type] + sql += ' AND current_relation_tags.k=?' + cond_rel += [type] end if value - sql += ' AND v=?' - cond_tbl += [value] + sql += ' AND current_relation_tags.v=? AND MATCH (current_relation_tags.v) AGAINST (? IN BOOLEAN MODE)' + cond_rel += [value,'"' + value.sub(/[-+*<>"~()]/, ' ') + '"'] end - cond_tbl = [sql] + cond_tbl + cond_rel = [sql] + cond_rel # Matching for tags column if type and value @@ -68,57 +91,44 @@ class SearchController < ApplicationController cond_tags = ['1=1'] end - - # First up, look for the ids of the ways we want - if do_ways - ways_tmp = WayTag.find(:all, :conditions => cond_tbl) - way_ids = ways_tmp.collect {|way| way.id } + # First up, look for the relations we want + if do_relations + relations = Relation.find(:all, + :joins => "INNER JOIN current_relation_tags ON current_relation_tags.id = current_relations.id", + :conditions => cond_rel, :limit => 100) end - # Now, segments matching - if do_segments - segs = Segment.find(:all, :conditions => cond_tags) + # then ways + if do_ways + ways = Way.find(:all, + :joins => "INNER JOIN current_way_tags ON current_way_tags.id = current_ways.id", + :conditions => cond_way, :limit => 100) end # Now, nodes if do_nodes - nodes = Node.find(:all, :conditions => cond_tags) - end - - # Get the remaining objects: - # Fetch the ways (until now only had their ids) - ways = Way.find(way_ids) - - # Fetch any segments needed for our ways (only have matching segments so far) - seg_ids = Array.new - ways.each do |way| - seg_ids += way.segs - end - segments += Segment.find(seg_ids) - - # Fetch any nodes needed for our segments (only have matching nodes so far) - node_ids = Array.new - segments.each do |seg| - node_ids += seg.node_a - node_ids += seg.node_b + nodes = Node.find(:all, :conditions => cond_tags, :limit => 2000) end - nodes += Node.find(node_ids) + # Fetch any node needed for our ways (only have matching nodes so far) + nodes += Node.find(ways.collect { |w| w.nds }.uniq) # Print + visible_nodes = {} + user_display_name_cache = {} doc = OSM::API.new.get_xml_doc nodes.each do |node| - doc.root << node.to_xml_node() + doc.root << node.to_xml_node(user_display_name_cache) + visible_nodes[node.id] = node end - segments.each do |segment| - doc.root << segment.to_xml_node() - end - ways.each do |way| - doc.root << way.to_xml_node() + doc.root << way.to_xml_node(visible_nodes, user_display_name_cache) end + relations.each do |rel| + doc.root << rel.to_xml_node(user_display_name_cache) + end render :text => doc.to_s, :content_type => "text/xml" end end