X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/cdaebd22ebb8e0d28a614ec8792a28620569910f..c04d05686f4014a1f729b7194913a0fe1b36e915:/.rubocop_todo.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index a5a160a02..e983c51c6 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2019-10-19 16:05:52 +0000 using RuboCop version 0.75.0. +# on 2020-09-02 06:16:56 UTC using RuboCop version 0.90.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -9,17 +9,18 @@ # Work around erblint issues. # https://github.com/openstreetmap/openstreetmap-website/issues/2472 require: + - rubocop-minitest - rubocop-performance - rubocop-rails -# Offense count: 3338 +# Offense count: 568 # Cop supports --auto-correct. # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. # URISchemes: http, https Layout/LineLength: - Max: 260 + Max: 250 -# Offense count: 35 +# Offense count: 36 # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: Exclude: @@ -32,26 +33,19 @@ Lint/AssignmentInCondition: - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - 'app/helpers/browse_tags_helper.rb' - - 'app/mailers/notifier.rb' + - 'app/mailers/user_mailer.rb' - 'app/models/client_application.rb' - 'lib/nominatim.rb' - 'lib/osm.rb' - 'script/deliver-message' -# Offense count: 4 -# Configuration parameters: AllowComments. -Lint/SuppressedException: - Exclude: - - 'app/controllers/api/amf_controller.rb' - - 'app/controllers/users_controller.rb' - - 'app/controllers/site_controller.rb' - -# Offense count: 701 +# Offense count: 682 +# Configuration parameters: IgnoredMethods. Metrics/AbcSize: - Max: 189 + Max: 194 -# Offense count: 39 -# Configuration parameters: CountComments, ExcludedMethods. +# Offense count: 72 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods. # ExcludedMethods: refine Metrics/BlockLength: Max: 71 @@ -62,66 +56,48 @@ Metrics/BlockNesting: Max: 5 # Offense count: 25 -# Configuration parameters: CountComments. +# Configuration parameters: CountComments, CountAsOne. Metrics/ClassLength: - Max: 645 + Max: 643 -# Offense count: 74 +# Offense count: 68 +# Configuration parameters: IgnoredMethods. Metrics/CyclomaticComplexity: - Max: 22 + Max: 26 -# Offense count: 722 -# Configuration parameters: CountComments, ExcludedMethods. +# Offense count: 735 +# Configuration parameters: CountComments, CountAsOne, ExcludedMethods. Metrics/MethodLength: Max: 179 -# Offense count: 2 -# Configuration parameters: CountComments. -Metrics/ModuleLength: - Max: 117 - # Offense count: 4 # Configuration parameters: CountKeywordArgs. Metrics/ParameterLists: Max: 9 -# Offense count: 72 +# Offense count: 69 +# Configuration parameters: IgnoredMethods. Metrics/PerceivedComplexity: - Max: 25 - -# Offense count: 2 -# Cop supports --auto-correct. -Minitest/AssertEmpty: - Exclude: - - 'test/controllers/api/amf_controller_test.rb' + Max: 26 -# Offense count: 6 -# Cop supports --auto-correct. -Minitest/AssertEqual: - Exclude: - - 'test/controllers/api/amf_controller_test.rb' +# Offense count: 540 +Minitest/MultipleAssertions: + Max: 81 -# Offense count: 27 +# Offense count: 26 # Cop supports --auto-correct. -Minitest/AssertIncludes: +Minitest/TestMethodName: Exclude: - - 'test/controllers/api/amf_controller_test.rb' + - 'test/abilities/api_capability_test.rb' - 'test/controllers/api/nodes_controller_test.rb' + - 'test/controllers/api/old_nodes_controller_test.rb' + - 'test/controllers/api/relations_controller_test.rb' + - 'test/controllers/api/ways_controller_test.rb' - 'test/helpers/browse_helper_test.rb' - - 'test/lib/i18n_test.rb' - - 'test/models/node_test.rb' - - 'test/models/old_node_test.rb' - - 'test/models/user_test.rb' - -# Offense count: 104 -# Cop supports --auto-correct. -Minitest/AssertTruthy: - Enabled: false - -# Offense count: 110 -# Cop supports --auto-correct. -Minitest/RefuteFalse: - Enabled: false + - 'test/integration/client_applications_test.rb' + - 'test/integration/short_links_test.rb' + - 'test/integration/user_blocks_test.rb' + - 'test/integration/user_creation_test.rb' # Offense count: 6 Naming/AccessorMethodName: @@ -133,10 +109,10 @@ Naming/AccessorMethodName: - 'lib/potlatch.rb' # Offense count: 8 -# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros. +# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros. # NamePrefix: is_, has_, have_ -# NamePrefixBlacklist: is_, has_, have_ -# NameWhitelist: is_a? +# ForbiddenPrefixes: is_, has_, have_ +# AllowedMethods: is_a? # MethodDefinitionMacros: define_method, define_singleton_method Naming/PredicateName: Exclude: @@ -149,21 +125,12 @@ Naming/PredicateName: - 'lib/classic_pagination/pagination.rb' # Offense count: 5 -# Cop supports --auto-correct. -Performance/RegexpMatch: - Exclude: - - 'app/helpers/browse_tags_helper.rb' - - 'app/validators/characters_validator.rb' - - 'app/validators/whitespace_validator.rb' - -# Offense count: 6 # Configuration parameters: Database, Include. # SupportedDatabases: mysql, postgresql # Include: db/migrate/*.rb Rails/BulkChangeTable: Exclude: - 'db/migrate/20111116184519_update_oauth.rb' - - 'db/migrate/20120208122334_merge_acl_address_and_mask.rb' - 'db/migrate/20120208194454_add_domain_to_acl.rb' - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' @@ -175,14 +142,12 @@ Rails/HasAndBelongsToMany: - 'app/models/changeset.rb' - 'app/models/user.rb' -# Offense count: 11 +# Offense count: 4 # Configuration parameters: Include. # Include: app/helpers/**/*.rb Rails/HelperInstanceVariable: Exclude: - - 'app/helpers/application_helper.rb' - 'app/helpers/title_helper.rb' - - 'app/helpers/trace_helper.rb' # Offense count: 5 # Configuration parameters: Include. @@ -195,60 +160,54 @@ Rails/NotNullColumn: - 'db/migrate/025_add_end_time_to_changesets.rb' - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' -# Offense count: 18 +# Offense count: 19 Rails/OutputSafety: Exclude: - 'app/controllers/users_controller.rb' - 'app/helpers/application_helper.rb' - 'app/helpers/changesets_helper.rb' - 'app/helpers/geocoder_helper.rb' - - 'app/helpers/note_helper.rb' - - 'app/helpers/open_graph_helper.rb' - 'app/helpers/user_blocks_helper.rb' - 'lib/rich_text.rb' - 'test/helpers/application_helper_test.rb' -# Offense count: 94 +# Offense count: 95 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: strict, flexible Rails/TimeZone: Enabled: false -# Offense count: 1 -# Configuration parameters: AllowedChars. -Style/AsciiComments: - Exclude: - - 'test/models/message_test.rb' - -# Offense count: 27 -# Configuration parameters: EnforcedStyle. -# SupportedStyles: annotated, template, unannotated -Style/FormatStringToken: - Exclude: - - 'app/models/concerns/geo_record.rb' - - 'app/views/api/map/_bounds.xml.builder' - - 'lib/bounding_box.rb' - - 'test/controllers/api/map_controller_test.rb' - - 'test/controllers/api/relations_controller_test.rb' - - 'test/controllers/api/ways_controller_test.rb' - - 'test/lib/bounding_box_test.rb' - -# Offense count: 539 +# Offense count: 572 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. -# SupportedStyles: always, never +# SupportedStyles: always, always_true, never Style/FrozenStringLiteralComment: Enabled: false -# Offense count: 2 -# Cop supports --auto-correct. -Style/IfUnlessModifier: - Exclude: - - 'app/controllers/api/ways_controller.rb' - -# Offense count: 70 +# Offense count: 78 # Cop supports --auto-correct. # Configuration parameters: Strict. Style/NumericLiterals: MinDigits: 11 + +# Offense count: 20 +Style/OptionalBooleanParameter: + Exclude: + - 'app/controllers/api/notes_controller.rb' + - 'app/controllers/application_controller.rb' + - 'app/helpers/browse_helper.rb' + - 'app/models/changeset.rb' + - 'app/models/node.rb' + - 'app/models/relation.rb' + - 'app/models/trace.rb' + - 'app/models/tracepoint.rb' + - 'app/models/way.rb' + - 'test/models/diary_entry_test.rb' + - 'test/models/trace_test.rb' + - 'test/models/tracetag_test.rb' + +# Offense count: 28 +# Cop supports --auto-correct. +Style/StringConcatenation: + Enabled: false