X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/cf4cfc530ae54abee7b6a0dccbc9d4603ab35611..e268af48b4329253e2d9cc6438e60d809f368c11:/test/controllers/issues_controller_test.rb

diff --git a/test/controllers/issues_controller_test.rb b/test/controllers/issues_controller_test.rb
index 6eacac11d..a988fc909 100644
--- a/test/controllers/issues_controller_test.rb
+++ b/test/controllers/issues_controller_test.rb
@@ -1,109 +1,232 @@
-require 'test_helper'
-
-class IssuesControllerTest < ActionController::TestCase
-  fixtures :users,:user_roles
+require "test_helper"
+
+class IssuesControllerTest < ActionDispatch::IntegrationTest
+  def test_index
+    # Access issues list without login
+    get issues_path
+    assert_redirected_to login_path(:referer => issues_path)
+
+    # Access issues list as normal user
+    session_for(create(:user))
+    get issues_path
+    assert_redirected_to :controller => :errors, :action => :forbidden
+
+    # Access issues list as administrator
+    session_for(create(:administrator_user))
+    get issues_path
+    assert_response :success
 
-  def test_new_issue_without_login
-    # Test creation of a new issue and a new report without logging in
-    get :new, {reportable_id: 1, reportable_type: "DiaryEntry", reported_user_id: 1}
-    assert_response :redirect
-    assert_redirected_to login_path(:referer => new_issue_path(:reportable_id=>1, :reportable_type=>"DiaryEntry",:reported_user_id=> 1))
+    # Access issues list as moderator
+    session_for(create(:moderator_user))
+    get issues_path
+    assert_response :success
   end
 
-  def test_new_issue_after_login
-    # Test creation of a new issue and a new report
+  def test_show_moderator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator")
+
+    # Access issue without login
+    get issue_path(:id => issue)
+    assert_redirected_to login_path(:referer => issue_path(issue))
+
+    # Access issue as normal user
+    session_for(create(:user))
+    get issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
 
-    # Login
-    session[:user] = users(:normal_user).id
+    # Access issue as administrator
+    session_for(create(:administrator_user))
+    get issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
 
-    get :new, {reportable_id: 1, reportable_type: "DiaryEntry", reported_user_id: 1}
+    # Access issue as moderator
+    session_for(create(:moderator_user))
+    get issue_path(:id => issue)
     assert_response :success
-    assert_difference "Issue.count",1 do 
-      details = "Details of a report"
-      post :create, { :report => { :details => details},
-                      :issue => { reportable_id: 1, reportable_type: "DiaryEntry", reported_user_id: 1} }
-    end
-    assert_response :redirect
   end
 
-  def test_new_report
-    # Test creation of a new report for an existing issue
+  def test_show_administrator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator")
 
-    # Login
-    session[:user] = users(:normal_user).id
+    # Access issue without login
+    get issue_path(:id => issue)
+    assert_redirected_to login_path(:referer => issue_path(issue))
 
-    get :new, {reportable_id: 1, reportable_type: "DiaryEntry", reported_user_id: 1}
-    assert_response :success
-    assert_difference "Issue.count",1 do 
-      details = "Details of a report"
-      post :create, { :report => { :details => details},
-                      :issue => { reportable_id: 1, reportable_type: "DiaryEntry", reported_user_id: 1} }
-    end
-    assert_response :redirect
-    
-    get :new, {reportable_id: 1, reportable_type: "DiaryEntry", reported_user_id: 1}
+    # Access issue as normal user
+    session_for(create(:user))
+    get issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
+
+    # Access issue as moderator
+    session_for(create(:moderator_user))
+    get issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+
+    # Access issue as administrator
+    session_for(create(:administrator_user))
+    get issue_path(:id => issue)
     assert_response :success
-    assert_no_difference "Issue.count" do
-      details = "Details of another report under the same issue"
-      post :create, { :report => { :details => details},
-                      :issue => { reportable_id: 1, reportable_type: "DiaryEntry", reported_user_id: 1} }
-    end
-    assert_response :redirect
-    assert_equal Issue.find_by_reportable_id_and_reportable_type(1,"DiaryEntry").reports.count,2
   end
 
-  def test_change_status_by_normal_user
-    # Login as normal user
-    session[:user] = users(:normal_user).id
-    
-    # Create Issue
+  def test_resolve_moderator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator")
 
-    get :new, {reportable_id: 1, reportable_type: "DiaryEntry", reported_user_id: 1}
-    assert_response :success
-    assert_difference "Issue.count",1 do 
-      details = "Details of a report"
-      post :create, { :report => { :details => details},
-                      :issue => { reportable_id: 1, reportable_type: "DiaryEntry", reported_user_id: 1} }
-    end
-    assert_response :redirect
-    
-    get :resolve, id: Issue.find_by_reportable_id_and_reportable_type(1,"DiaryEntry").id
+    # Resolve issue without login
+    post resolve_issue_path(:id => issue)
+    assert_response :forbidden
+
+    # Resolve issue as normal user
+    session_for(create(:user))
+    post resolve_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
+
+    # Resolve issue as administrator
+    session_for(create(:administrator_user))
+    post resolve_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+    assert_not issue.reload.resolved?
+
+    # Resolve issue as moderator
+    session_for(create(:moderator_user))
+    post resolve_issue_path(:id => issue)
     assert_response :redirect
-    assert_redirected_to root_path
+    assert_predicate issue.reload, :resolved?
   end
 
-  def test_change_status_by_admin
-    # Login as normal user
-    session[:user] = users(:normal_user).id
+  def test_resolve_administrator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator")
 
-    # Create Issue
+    # Resolve issue without login
+    post resolve_issue_path(:id => issue)
+    assert_response :forbidden
 
-    get :new, {reportable_id: 1, reportable_type: "DiaryEntry", reported_user_id: 1}
-    assert_response :success
-    assert_difference "Issue.count",1 do 
-      details = "Details of a report"
-      post :create, { :report => { :details => details},
-                      :issue => { reportable_id: 1, reportable_type: "DiaryEntry", reported_user_id: 1} }
-    end
+    # Resolve issue as normal user
+    session_for(create(:user))
+    post resolve_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
+
+    # Resolve issue as moderator
+    session_for(create(:moderator_user))
+    post resolve_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+    assert_not issue.reload.resolved?
+
+    # Resolve issue as administrator
+    session_for(create(:administrator_user))
+    post resolve_issue_path(:id => issue)
     assert_response :redirect
+    assert_predicate issue.reload, :resolved?
+  end
+
+  def test_ignore_moderator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator")
 
-    # Login as administrator
-    session[:user] = users(:administrator_user).id
-   
-    # Test 'Resolved'
-    get :resolve, id: Issue.find_by_reportable_id_and_reportable_type(1,"DiaryEntry").id
-    assert_equal Issue.find_by_reportable_id_and_reportable_type(1,"DiaryEntry").resolved?, true
+    # Ignore issue without login
+    post ignore_issue_path(:id => issue)
+    assert_response :forbidden
+
+    # Ignore issue as normal user
+    session_for(create(:user))
+    post ignore_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
+
+    # Ignore issue as administrator
+    session_for(create(:administrator_user))
+    post ignore_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+    assert_not issue.reload.ignored?
+
+    # Ignore issue as moderator
+    session_for(create(:moderator_user))
+    post ignore_issue_path(:id => issue)
     assert_response :redirect
+    assert_predicate issue.reload, :ignored?
+  end
+
+  def test_ignore_administrator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator")
+
+    # Ignore issue without login
+    post ignore_issue_path(:id => issue)
+    assert_response :forbidden
 
-    # Test 'Reopen'
-    get :reopen, id: Issue.find_by_reportable_id_and_reportable_type(1,"DiaryEntry").id
-    assert_equal Issue.find_by_reportable_id_and_reportable_type(1,"DiaryEntry").open?, true
+    # Ignore issue as normal user
+    session_for(create(:user))
+    post ignore_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
+
+    # Ignore issue as moderator
+    session_for(create(:moderator_user))
+    post ignore_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+    assert_not issue.reload.ignored?
+
+    # Ignore issue as administrator
+    session_for(create(:administrator_user))
+    post ignore_issue_path(:id => issue)
     assert_response :redirect
+    assert_predicate issue.reload, :ignored?
+  end
+
+  def test_reopen_moderator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator")
+
+    issue.resolve!
 
-    # Test 'Ignored'
-    get :ignore, id: Issue.find_by_reportable_id_and_reportable_type(1,"DiaryEntry").id
-    assert_equal Issue.find_by_reportable_id_and_reportable_type(1,"DiaryEntry").ignored?, true
+    # Reopen issue without login
+    post reopen_issue_path(:id => issue)
+    assert_response :forbidden
+
+    # Reopen issue as normal user
+    session_for(create(:user))
+    post reopen_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
+
+    # Reopen issue as administrator
+    session_for(create(:administrator_user))
+    post reopen_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+    assert_not issue.reload.open?
+
+    # Reopen issue as moderator
+    session_for(create(:moderator_user))
+    post reopen_issue_path(:id => issue)
     assert_response :redirect
+    assert_predicate issue.reload, :open?
   end
 
+  def test_reopen_administrator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator")
+
+    issue.resolve!
+
+    # Reopen issue without login
+    post reopen_issue_path(:id => issue)
+    assert_response :forbidden
+
+    # Reopen issue as normal user
+    session_for(create(:user))
+    post reopen_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
+
+    # Reopen issue as moderator
+    session_for(create(:moderator_user))
+    post reopen_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+    assert_not issue.reload.open?
+
+    # Reopen issue as administrator
+    session_for(create(:administrator_user))
+    post reopen_issue_path(:id => issue)
+    assert_response :redirect
+    assert_predicate issue.reload, :open?
+  end
 end