X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/cfbdd3f7e1c688e2c875ded9fd847fcc1c3a4caf..532d1085369e8bed5eb7bd2fc9cb1d81b63027ac:/app/controllers/search_controller.rb?ds=sidebyside diff --git a/app/controllers/search_controller.rb b/app/controllers/search_controller.rb index b3e7ca97b..dd7c2febe 100644 --- a/app/controllers/search_controller.rb +++ b/app/controllers/search_controller.rb @@ -2,22 +2,24 @@ class SearchController < ApplicationController # Support searching for nodes, ways, or all # Can search by tag k, v, or both (type->k,value->v) # Can search by name (k=name,v=....) - + skip_before_filter :verify_authenticity_token after_filter :compress_output def search_all - do_search(true,true) + do_search(true,true,true) end def search_ways - do_search(true,false) + do_search(true,false,false) end def search_nodes - do_search(false,true) + do_search(false,true,false) + end + def search_relations + do_search(false,false,true) end - - def do_search(do_ways,do_nodes) + def do_search(do_ways,do_nodes,do_relations) type = params['type'] value = params['value'] unless type or value @@ -28,67 +30,68 @@ class SearchController < ApplicationController end end - way_ids = Array.new - ways = Array.new - nodes = Array.new - - # Matching for tags table - cond_tbl = Array.new - sql = 'id IN (SELECT id FROM current_way_tags WHERE 1=1' - if type - sql += ' AND k=?' - cond_tbl += [type] + if do_nodes + response.headers['Error'] = "Searching of nodes is currently unavailable" + render :text => "", :status => :service_unavailable + return false end - if value - sql += ' AND v=?' - cond_tbl += [value] + + unless value + response.headers['Error'] = "Searching for a key without value is currently unavailable" + render :text => "", :status => :service_unavailable + return false end - sql += ')' - cond_tbl = [sql] + cond_tbl - # Matching for tags column - if type and value - cond_tags = ['tags LIKE ? OR tags LIKE ? OR tags LIKE ? OR tags LIKE ?', - ''+type+'='+value+'', - ''+type+'='+value+';%', - '%;'+type+'='+value+';%', - '%;'+type+'='+value+'' ] - elsif type - cond_tags = ['tags LIKE ? OR tags LIKE ?', - ''+type+'=%', - '%;'+type+'=%' ] - elsif value - cond_tags = ['tags LIKE ? OR tags LIKE ?', - '%='+value+';%', - '%='+value+'' ] + # Matching for node tags table + if do_nodes + nodes = Node.joins(:node_tags) + nodes = nodes.where(:current_node_tags => { :k => type }) if type + nodes = nodes.where(:current_node_tags => { :v => value }) if value + nodes = nodes.limit(100) else - cond_tags = ['1=1'] + nodes = Array.new end - - # First up, look for the ways we want + # Matching for way tags table if do_ways - ways = Way.find(:all, :conditions => cond_tbl, :limit => 100) + ways = Way.joins(:way_tags) + ways = ways.where(:current_way_tags => { :k => type }) if type + ways = ways.where(:current_way_tags => { :v => value }) if value + ways = ways.limit(100) + else + ways = Array.new end - # Now, nodes - if do_nodes - nodes = Node.find(:all, :conditions => cond_tags, :limit => 2000) + # Matching for relation tags table + if do_relations + relations = Relation.joins(:relation_tags) + relations = relations.where(:current_relation_tags => { :k => type }) if type + relations = relations.where(:current_relation_tags => { :v => value }) if value + relations = relations.limit(2000) + else + relations = Array.new end # Fetch any node needed for our ways (only have matching nodes so far) nodes += Node.find(ways.collect { |w| w.nds }.uniq) # Print + visible_nodes = {} + changeset_cache = {} user_display_name_cache = {} doc = OSM::API.new.get_xml_doc nodes.each do |node| - doc.root << node.to_xml_node(user_display_name_cache) + doc.root << node.to_xml_node(changeset_cache, user_display_name_cache) + visible_nodes[node.id] = node end ways.each do |way| - doc.root << way.to_xml_node(user_display_name_cache) - end + doc.root << way.to_xml_node(visible_nodes, changeset_cache, user_display_name_cache) + end + + relations.each do |rel| + doc.root << rel.to_xml_node(nil, changeset_cache, user_display_name_cache) + end render :text => doc.to_s, :content_type => "text/xml" end