X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/d3700e6201b4b78a70bbb2941572edc985b63c2c..e22266f8c4a1ffa0aaed8f76c0ccaaaaa08e7df5:/test/controllers/issues_controller_test.rb diff --git a/test/controllers/issues_controller_test.rb b/test/controllers/issues_controller_test.rb index ff99b0cdc..af0a86028 100644 --- a/test/controllers/issues_controller_test.rb +++ b/test/controllers/issues_controller_test.rb @@ -1,69 +1,144 @@ require "test_helper" class IssuesControllerTest < ActionController::TestCase - teardown do - # cleanup any emails set off by the test - ActionMailer::Base.deliveries.clear - end - - def test_view_dashboard_without_auth - # Access issues_path without login + def test_index + # Access issues list without login get :index assert_response :redirect assert_redirected_to login_path(:referer => issues_path) - # Access issues_path as normal user + # Access issues list as normal user session[:user] = create(:user).id get :index assert_response :redirect - assert_redirected_to root_path + assert_redirected_to :controller => :errors, :action => :forbidden - # Access issues_path by admin + # Access issues list as administrator session[:user] = create(:administrator_user).id get :index assert_response :success - # Access issues_path by moderator + # Access issues list as moderator session[:user] = create(:moderator_user).id get :index assert_response :success end - def test_change_status_by_normal_user + def test_show target_user = create(:user) issue = create(:issue, :reportable => target_user, :reported_user => target_user) - # Login as normal user + # Access issue without login + get :show, :params => { :id => issue.id } + assert_response :redirect + assert_redirected_to login_path(:referer => issue_path(issue)) + + # Access issue as normal user session[:user] = create(:user).id + get :show, :params => { :id => issue.id } + assert_response :redirect + assert_redirected_to :controller => :errors, :action => :forbidden + + # Access issue as administrator + session[:user] = create(:administrator_user).id + get :show, :params => { :id => issue.id } + assert_response :success + + # Access issue as moderator + session[:user] = create(:moderator_user).id + get :show, :params => { :id => issue.id } + assert_response :success + end + + def test_resolve + target_user = create(:user) + issue = create(:issue, :reportable => target_user, :reported_user => target_user) + + # Resolve issue without login + get :resolve, :params => { :id => issue.id } + assert_response :redirect + assert_redirected_to login_path(:referer => resolve_issue_path(issue)) - assert_equal 1, Issue.count + # Resolve issue as normal user + session[:user] = create(:user).id + get :resolve, :params => { :id => issue.id } + assert_response :redirect + assert_redirected_to :controller => :errors, :action => :forbidden + # Resolve issue as administrator + session[:user] = create(:administrator_user).id get :resolve, :params => { :id => issue.id } + assert_response :redirect + assert_equal true, issue.reload.resolved? + issue.reopen! + + # Resolve issue as moderator + session[:user] = create(:moderator_user).id + get :resolve, :params => { :id => issue.id } assert_response :redirect - assert_redirected_to root_path + assert_equal true, issue.reload.resolved? end - def test_change_status_by_admin + def test_ignore target_user = create(:user) issue = create(:issue, :reportable => target_user, :reported_user => target_user) - # Login as administrator + # Ignore issue without login + get :ignore, :params => { :id => issue.id } + assert_response :redirect + assert_redirected_to login_path(:referer => ignore_issue_path(issue)) + + # Ignore issue as normal user + session[:user] = create(:user).id + get :ignore, :params => { :id => issue.id } + assert_response :redirect + assert_redirected_to :controller => :errors, :action => :forbidden + + # Ignore issue as administrator session[:user] = create(:administrator_user).id + get :ignore, :params => { :id => issue.id } + assert_response :redirect + assert_equal true, issue.reload.ignored? - # Test 'Resolved' - get :resolve, :params => { :id => issue.id } - assert_equal true, Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").resolved? + issue.reopen! + + # Ignore issue as moderator + session[:user] = create(:moderator_user).id + get :ignore, :params => { :id => issue.id } + assert_response :redirect + assert_equal true, issue.reload.ignored? + end + + def test_reopen + target_user = create(:user) + issue = create(:issue, :reportable => target_user, :reported_user => target_user) + + issue.resolve! + + # Reopen issue without login + get :reopen, :params => { :id => issue.id } assert_response :redirect + assert_redirected_to login_path(:referer => reopen_issue_path(issue)) - # Test 'Reopen' + # Reopen issue as normal user + session[:user] = create(:user).id get :reopen, :params => { :id => issue.id } - assert_equal true, Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").open? assert_response :redirect + assert_redirected_to :controller => :errors, :action => :forbidden - # Test 'Ignored' - get :ignore, :params => { :id => issue.id } - assert_equal true, Issue.find_by(:reportable_id => target_user, :reportable_type => "User").ignored? + # Reopen issue as administrator + session[:user] = create(:administrator_user).id + get :reopen, :params => { :id => issue.id } + assert_response :redirect + assert_equal true, issue.reload.open? + + issue.resolve! + + # Reopen issue as moderator + session[:user] = create(:moderator_user).id + get :reopen, :params => { :id => issue.id } assert_response :redirect + assert_equal true, issue.reload.open? end end