X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/d49922eb630abb73c7faffb650ab97b3c5d94c52..2de33c2f1d5c2fc352fff1433b46e53e45253206:/app/controllers/issues_controller.rb?ds=inline diff --git a/app/controllers/issues_controller.rb b/app/controllers/issues_controller.rb index 6ca61b4ce..c24054f77 100644 --- a/app/controllers/issues_controller.rb +++ b/app/controllers/issues_controller.rb @@ -2,48 +2,60 @@ class IssuesController < ApplicationController layout "site" before_action :authorize_web - before_action :check_permission, only: [:index, :show, :resolve,:open,:ignore] - before_action :find_issue, only: [:show, :resolve, :reopen, :ignore] + before_action :set_locale + before_action :check_database_readable - def index - @issues = Issue.all - end - - def show - @read_reports = @issue.read_reports - @unread_reports = @issue.unread_reports - end + authorize_resource - def new - unless create_new_issue_params.blank? - @issue = Issue.find_or_initialize_by(create_new_issue_params) - end - end + before_action :find_issue, :only => [:show, :resolve, :reopen, :ignore] + before_action :check_database_writable, :only => [:resolve, :ignore, :reopen] - def create - @issue = Issue.find_by_reportable_id_and_reportable_type(params[:reportable_id],params[:reportable_type]) - if !@issue - @issue = Issue.find_or_initialize_by(issue_params) - @admins = UserRole.where(role: "administrator") - @admins.each do |user| - Notifier.new_issue_notification(User.find(user.user_id)).deliver_now + def index + @title = t ".title" + + @issue_types = [] + @issue_types.push("Note", "User") if current_user.moderator? + @issue_types.push("DiaryEntry", "DiaryComment", "User") if current_user.administrator? + + @users = User.joins(:roles).where(:user_roles => { :role => current_user.roles.map(&:role) }).distinct + @issues = Issue.visible_to(current_user).order(:updated_at => :desc) + + # If search + if params[:search_by_user].present? + @find_user = User.find_by(:display_name => params[:search_by_user]) + if @find_user + @issues = @issues.where(:reported_user => @find_user) + else + @issues = @issues.none + flash.now[:warning] = t(".user_not_found") end end - @report = @issue.reports.build(report_params) + @issues = @issues.where(:status => params[:status]) if params[:status].present? - if @issue.save - redirect_to @issue, notice: 'Issue was successfully created.' - else - render :new + @issues = @issues.where(:reportable_type => params[:issue_type]) if params[:issue_type].present? + + if params[:last_updated_by].present? + last_updated_by = params[:last_updated_by].to_s == "nil" ? nil : params[:last_updated_by].to_i + @issues = @issues.where(:updated_by => last_updated_by) end end - # Status Transistions + def show + @title = t ".title", :status => @issue.status.humanize, :issue_id => @issue.id + @read_reports = @issue.read_reports + @unread_reports = @issue.unread_reports + @comments = @issue.comments + @related_issues = @issue.reported_user.issues.where(:assigned_role => current_user.roles.map(&:role)) if @issue.reported_user + @new_comment = IssueComment.new(:issue => @issue) + end + + # Status Transitions def resolve if @issue.resolve + @issue.updated_by = current_user.id @issue.save! - redirect_to @issue, notice: "Issue status has been set to: 'Resolved'" + redirect_to @issue, :notice => t(".resolved") else render :show end @@ -51,8 +63,9 @@ class IssuesController < ApplicationController def ignore if @issue.ignore + @issue.updated_by = current_user.id @issue.save! - redirect_to @issue, notice: "Issue status has been set to: 'Ignored'" + redirect_to @issue, :notice => t(".ignored") else render :show end @@ -60,8 +73,9 @@ class IssuesController < ApplicationController def reopen if @issue.reopen + @issue.updated_by = current_user.id @issue.save! - redirect_to @issue, notice: "Issue status has been set to: 'Open'" + redirect_to @issue, :notice => t(".reopened") else render :show end @@ -69,26 +83,9 @@ class IssuesController < ApplicationController private - def find_issue - @issue = Issue.find(params[:id]) - end - - def check_permission - unless @user.administrator? - flash[:error] = t("application.require_admin.not_an_admin") - redirect_to root_path - end - end - - def create_new_issue_params - params.permit(:reportable_id, :reportable_type, :user_id) - end - - def issue_params - params[:issue].permit(:reportable_id, :reportable_type,:user_id) - end - - def report_params - params[:report].permit(:details, :user_id) - end + def find_issue + @issue = Issue.visible_to(current_user).find(params[:id]) + rescue ActiveRecord::RecordNotFound + redirect_to :controller => "errors", :action => "not_found" + end end