X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/d887252eeb49f905a979c21f2559c85d9a0455bd..94d19ae567dc7723129ee2f00576023aaee18fc7:/app/controllers/api_controller.rb diff --git a/app/controllers/api_controller.rb b/app/controllers/api_controller.rb index 735e1bd59..cb3d71d49 100644 --- a/app/controllers/api_controller.rb +++ b/app/controllers/api_controller.rb @@ -1,105 +1,30 @@ class ApiController < ApplicationController skip_before_action :verify_authenticity_token - before_action :api_deny_access_handler - authorize_resource :class => false + def authorize(realm = "Web Password", errormessage = "Couldn't authenticate you") + # make the current_user object from any auth sources we have + setup_user_auth - before_action :check_api_readable - around_action :api_call_handle_error, :api_call_timeout - - # This is probably the most common call of all. It is used for getting the - # OSM data for a specified bounding box, usually for editing. First the - # bounding box (bbox) is checked to make sure that it is sane. All nodes - # are searched, then all the ways that reference those nodes are found. - # All Nodes that are referenced by those ways are fetched and added to the list - # of nodes. - # Then all the relations that reference the already found nodes and ways are - # fetched. All the nodes and ways that are referenced by those ways are then - # fetched. Finally all the xml is returned. - def map - # Figure out the bbox - # check boundary is sane and area within defined - # see /config/application.yml - begin - bbox = BoundingBox.from_bbox_params(params) - bbox.check_boundaries - bbox.check_size - rescue StandardError => err - report_error(err.message) - return - end - - nodes = Node.bbox(bbox).where(:visible => true).includes(:node_tags).limit(MAX_NUMBER_OF_NODES + 1) - - node_ids = nodes.collect(&:id) - if node_ids.length > MAX_NUMBER_OF_NODES - report_error("You requested too many nodes (limit is #{MAX_NUMBER_OF_NODES}). Either request a smaller area, or use planet.osm") - return + # handle authenticate pass/fail + unless current_user + # no auth, the user does not exist or the password was wrong + response.headers["WWW-Authenticate"] = "Basic realm=\"#{realm}\"" + render :plain => errormessage, :status => :unauthorized + return false end + end - doc = OSM::API.new.get_xml_doc - - # add bounds - doc.root << bbox.add_bounds_to(XML::Node.new("bounds")) - - # get ways - # find which ways are needed - ways = [] - if node_ids.empty? - list_of_way_nodes = [] + def deny_access(_exception) + if current_token + set_locale + report_error t("oauth.permissions.missing"), :forbidden + elsif current_user + head :forbidden else - way_nodes = WayNode.where(:node_id => node_ids) - way_ids = way_nodes.collect { |way_node| way_node.id[0] } - ways = Way.preload(:way_nodes, :way_tags).find(way_ids) - - list_of_way_nodes = ways.collect do |way| - way.way_nodes.collect(&:node_id) - end - list_of_way_nodes.flatten! + realm = "Web Password" + errormessage = "Couldn't authenticate you" + response.headers["WWW-Authenticate"] = "Basic realm=\"#{realm}\"" + render :plain => errormessage, :status => :unauthorized end - - # - [0] in case some thing links to node 0 which doesn't exist. Shouldn't actually ever happen but it does. FIXME: file a ticket for this - nodes_to_fetch = (list_of_way_nodes.uniq - node_ids) - [0] - - nodes += Node.includes(:node_tags).find(nodes_to_fetch) unless nodes_to_fetch.empty? - - visible_nodes = {} - changeset_cache = {} - user_display_name_cache = {} - - nodes.each do |node| - if node.visible? - doc.root << node.to_xml_node(changeset_cache, user_display_name_cache) - visible_nodes[node.id] = node - end - end - - way_ids = [] - ways.each do |way| - if way.visible? - doc.root << way.to_xml_node(visible_nodes, changeset_cache, user_display_name_cache) - way_ids << way.id - end - end - - relations = Relation.nodes(visible_nodes.keys).visible + - Relation.ways(way_ids).visible - - # we do not normally return the "other" partners referenced by an relation, - # e.g. if we return a way A that is referenced by relation X, and there's - # another way B also referenced, that is not returned. But we do make - # an exception for cases where an relation references another *relation*; - # in that case we return that as well (but we don't go recursive here) - relations += Relation.relations(relations.collect(&:id)).visible - - # this "uniq" may be slightly inefficient; it may be better to first collect and output - # all node-related relations, then find the *not yet covered* way-related ones etc. - relations.uniq.each do |relation| - doc.root << relation.to_xml_node(changeset_cache, user_display_name_cache) - end - - response.headers["Content-Disposition"] = "attachment; filename=\"map.osm\"" - - render :xml => doc.to_s end end